fix: correct argument parsing error handling in datacrumbs scripts

Author: hariharan-devarajan

scripts/datacrumbs/datacrumbs_args.in

@@ -630,7 +630,9 @@ dc_args_pretty_print() {
 				fi
 			fi
 		done
-		((any == 1)) && debug ""
+		if ((any == 1)); then
+			debug ""
+		fi
 	}
 	print_group "MANDATORY" "Mandatory options:"
 	print_group "OPTIONAL" "Optional options:"

scripts/datacrumbs/datacrumbs_create_log_dir.in

@@ -25,7 +25,7 @@ for __dc_a in "$@"; do
 	fi
 done
 
-dc_args_parse "$APP" "datacrumbs_create_log_dir" "$@" || true
+dc_args_parse "$APP" "datacrumbs_create_log_dir" "$@"
 if [[ $? -ne 0 ]]; then
 	echo "Error: Argument parsing failed."
 	show_help

scripts/datacrumbs/datacrumbs_run.in

@@ -20,7 +20,7 @@ dc_args_add_option "DATACRUMBS" "nodes" "OPTIONAL" "Set number of nodes" "int" "
 dc_args_add_option "DATACRUMBS" "ppn" "OPTIONAL" "Set processes per node" "int" "1"
 dc_args_add_subcommand "DATACRUMBS" "enable_mpi" "1" "nodes" "ppn"
 
-dc_args_parse "DATACRUMBS" "datacrumbs_run" "$@" || true
+dc_args_parse "DATACRUMBS" "datacrumbs_run" "$@"
 
 if [[ $? -ne 0 ]]; then
 	echo "Error: Argument parsing failed."

scripts/datacrumbs/datacrumbs_utility.in

@@ -53,6 +53,11 @@ function datacrumbs_init() {
 }
 
 function datacrumbs_start_server() {
+	if [[ "$DATACRUMBS_IS_ROOT" == "1" ]]; then
+		mkdir -p "$DATACRUMBS_SERVER_RUN_DIR"
+	else
+		sudo mkdir -p "$DATACRUMBS_SERVER_RUN_DIR"
+	fi
 	if [[ ! -w "$DATACRUMBS_SERVER_RUN_DIR" ]]; then
 		warn "Cannot write to DATACRUMBS_SERVER_RUN_DIR: $DATACRUMBS_SERVER_RUN_DIR. Trying sudo."
 		sudo mkdir -p "$DATACRUMBS_SERVER_RUN_DIR"