Skip to content

Commit f73ddf9

Browse files
Fix errors of nested types are left unhandled
When an error occurs in a nested type the error is currently unhandled, which means that the error output terminal will return "no error". Fixed by connecting all error terminals in "JSON to LVObject" Closes #19
1 parent 74086a4 commit f73ddf9

5 files changed

Lines changed: 6 additions & 4 deletions

File tree

.vipb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
<VI_Package_Builder_Settings Version="2018" Created_Date="2021-03-19 22:45:16" Modified_Date="2021-04-19 19:17:08" Creator="Pascal Neuperger" Comments="" ID="8b3b5a9e685e4a1a64b34f6e2b60f319">
1+
<VI_Package_Builder_Settings Version="2018" Created_Date="2021-03-19 22:45:16" Modified_Date="2021-06-12 10:04:54" Creator="Pascal Neuperger" Comments="" ID="191e8c0b12e9dad55c61892413679591">
22
<Library_General_Settings>
33
<Package_File_Name>PNR_lib_JSONtext_Object_Serialization</Package_File_Name>
4-
<Library_Version>1.0.0.21</Library_Version>
4+
<Library_Version>1.0.1.22</Library_Version>
55
<Auto_Increment_Version>false</Auto_Increment_Version>
66
<Library_Source_Folder>.</Library_Source_Folder>
77
<Library_Output_Folder>..</Library_Output_Folder>
@@ -47,7 +47,7 @@ Only serializes classes that inherit from JSON Serializable that defines methods
4747
<Copyright>Copyright (c) 2021, Pascal Neuperger</Copyright>
4848
<Packager/>
4949
<URL>https://github.com/LogMANOriginal/JSONtext-Object-Serialization</URL>
50-
<Release_Notes>First release</Release_Notes>
50+
<Release_Notes>- [#19] Fixed an issue in "Generic Object Serializer", which resulted in errors not being reported to the caller.</Release_Notes>
5151
</Description>
5252
<Destinations>
5353
<Toolkit_VIs>
@@ -298,7 +298,7 @@ Only serializes classes that inherit from JSON Serializable that defines methods
298298
<Path>JSON Serializable Serializer Constant.vi</Path>
299299
<VI_Title/>
300300
</Items_Data>
301-
<GUID>265AE485DB231ABBB4C78B46CFBD77AE</GUID>
301+
<GUID>F9C3C92EBC223B1DDBDBEF166FFB0D6F</GUID>
302302
</Functions_Palette_Data>
303303
</Library_Palette_Definition>
304304
</VI_Package_Builder_Settings>

Generic Object Serializer Tests/Generic Object Serializer Tests.lvlib

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,6 @@
4141
<Item Name="JSON to LVObject - Warning Input - Returns Same Warning.vi" Type="VI" URL="../JSON to LVObject - Warning Input - Returns Same Warning.vi"/>
4242
<Item Name="JSON to LVObject - Warning Input - Returns Specified Object.vi" Type="VI" URL="../JSON to LVObject - Warning Input - Returns Specified Object.vi"/>
4343
<Item Name="JSON to LVObject - Offset - Returns Specified Object.vi" Type="VI" URL="../JSON to LVObject - Offset - Returns Specified Object.vi"/>
44+
<Item Name="JSON to LVObject - Invalid Nested Type - Returns Error.vi" Type="VI" URL="../JSON to LVObject - Invalid Nested Type - Returns Error.vi"/>
45+
<Item Name="JSON to LVObject - Invalid Type in nested Class - Returns Error.vi" Type="VI" URL="../JSON to LVObject - Invalid Type in nested Class - Returns Error.vi"/>
4446
</Library>
Binary file not shown.
-932 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)