Unexpected behavior for `filepath.join("/","one")`

[oderwat]

I would expect this at least for Linux & OSX:

should.equal(filepath.join("/","one"),"/one")

At least those will give that same result:

• Go path/filepath with filepath.Join("/", "one")
• Python os.path.join("/", "one")
• Rust Path::new("/").join("one")

[lpil]

You've not said what it does 😄

[oderwat]

It returns "one".

[lpil]

Oh dear! Thank you

[oderwat]

I just started to work on a PR to fix it. But you were faster. I added some more tests, and they all pass with your new implementation but of test 17.

pub fn join_13_test() {
  filepath.join("/", "")
  |> should.equal("/")
}

pub fn join_14_test() {
  filepath.join("/", "/")
  |> should.equal("/")
}

pub fn join_15_test() {
  filepath.join("", "/")
  |> should.equal("/")
}

pub fn join_16_test() {
  filepath.join("/", "/one")
  |> should.equal("/one")
}

// This still fails. I think it should not remove the "/" in this case.
pub fn join_17_test() {
  filepath.join("", "/one")
  |> should.equal("/one")
}```

[lpil]

Good catch!