refactor: Add leading \ before function invocation to speed up resolving (#176)

* refactor: Add leading \ before function invocation to speed up resolving

* ci(travis): Add cs-fixer to travis tests

Author: damianopetrungaro

.gitignore

@@ -3,3 +3,4 @@ build/
 /vendor
 composer.lock
 /.idea/
+.php_cs.cache

.php_cs.dist

@@ -0,0 +1,8 @@
+<?php
+
+return PhpCsFixer\Config::create()
+    ->setRiskyAllowed(true)
+    ->setRules([
+        'native_function_invocation' => true,
+    ])
+    ->setFinder(PhpCsFixer\Finder::create()->exclude('tests')->in(__DIR__));

.travis.yml

@@ -12,4 +12,7 @@ matrix:
     - php: nightly
 
 before_script: composer install
-script: vendor/bin/phpunit --debug
+
+script:
+  - vendor/bin/php-cs-fixer fix --dry-run --diff --config=.php_cs.dist
+  - vendor/bin/phpunit --debug

composer.json

@@ -18,7 +18,8 @@
         "php": "~7"
     },
     "require-dev": {
-        "phpunit/phpunit": "~6"
+        "phpunit/phpunit": "~6",
+        "friendsofphp/php-cs-fixer": "^2.13"
     },
     "autoload": {
         "psr-4": {"Functional\\": "src/Functional"},

src/Functional/Average.php

@@ -40,7 +40,7 @@ function average($collection)
 
     foreach ($collection as $element) {
 
-        if (is_numeric($element)) {
+        if (\is_numeric($element)) {
             $sum += $element;
             ++$divisor;
         }

src/Functional/ButLast.php

@@ -34,8 +34,8 @@ function but_last($collection)
 {
     InvalidArgumentException::assertCollection($collection, __FUNCTION__, 1);
 
-    $butLast = is_array($collection) ? $collection : iterator_to_array($collection);
-    array_pop($butLast);
+    $butLast = \is_array($collection) ? $collection : \iterator_to_array($collection);
+    \array_pop($butLast);
 
     return $butLast;
 }

src/Functional/CompareObjectHashOn.php

@@ -22,8 +22,6 @@
  */
 namespace Functional;
 
-use function Functional\compose;
-
 /**
  * Returns a comparison function that can be used with e.g. `usort()`
  *

src/Functional/Compose.php

@@ -22,8 +22,6 @@
  */
 namespace Functional;
 
-use function Functional\id;
-
 /**
  * Return a new function that composes all functions in $functions into a single callable
  *
@@ -34,7 +32,7 @@
  */
 function compose(...$functions)
 {
-    return array_reduce(
+    return \array_reduce(
         $functions,
         function ($carry, $item) {
             return function ($x) use ($carry, $item) {

src/Functional/Concat.php

@@ -25,10 +25,10 @@
 /**
  * Concatenates zero or more strings
  *
- * @param string[] $functions
+ * @param string[] $strings
  * @return string
  */
 function concat(string ...$strings)
 {
-    return implode('', $strings);
+    return \implode('', $strings);
 }

src/Functional/Curry.php

@@ -36,14 +36,14 @@
  */
 function curry(callable $function, $required = true)
 {
-    if (method_exists('Closure','fromCallable')) {
+    if (\method_exists('Closure','fromCallable')) {
         $reflection = new ReflectionFunction(Closure::fromCallable($function));
     } else {
-        if (is_string($function) && strpos($function, '::', 1) !== false) {
+        if (\is_string($function) && \strpos($function, '::', 1) !== false) {
             $reflection = new ReflectionMethod($function);
-        } elseif (is_array($function) && count($function) === 2) {
+        } elseif (\is_array($function) && \count($function) === 2) {
             $reflection = new ReflectionMethod($function[0], $function[1]);
-        } elseif (is_object($function) && method_exists($function, '__invoke')) {
+        } elseif (\is_object($function) && \method_exists($function, '__invoke')) {
             $reflection = new ReflectionMethod($function, '__invoke');
         } else {
             $reflection = new ReflectionFunction($function);