Skip to content

Commit d7ea567

Browse files
committed
fix: fix #lint by marking tacticDocs as public (leanprover-community#33322)
This PR fixes `#lint`, which had been reporting > Unknown constant `_private.Mathlib.Tactic.Linter.TacticDocumentation.0.tacticDocs` by marking `tacticDocs` as `public`. See [#mathlib4 > #lint is broken @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/.23lint.20is.20broken/near/565443234).
1 parent 9732e9f commit d7ea567

2 files changed

Lines changed: 18 additions & 4 deletions

File tree

Mathlib/Tactic/Linter/TacticDocumentation.lean

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ Authors: Anne Baanen
55
-/
66
module
77

8-
meta import Batteries.Tactic.Lint.Basic
9-
meta import Lean.Elab.Tactic.Doc
10-
import Lean.Parser.Tactic.Doc
8+
public meta import Batteries.Tactic.Lint.Basic
9+
public meta import Lean.Elab.Tactic.Doc
10+
public meta import Lean.Parser.Tactic.Doc
1111
import Mathlib.Tactic.Linter.Header
1212

1313
/-! # The `tacticDocs` linter
@@ -25,7 +25,7 @@ meta def isNonemptyDoc (doc : TacticDoc) : Bool :=
2525
doc.docString.isSome || doc.extensionDocs.any (! ·.isEmpty)
2626

2727
/-- Check that all tactics available in Mathlib have a docstring. -/
28-
@[env_linter] meta def tacticDocs : Batteries.Tactic.Lint.Linter where
28+
@[env_linter] public meta def tacticDocs : Batteries.Tactic.Lint.Linter where
2929
noErrorsFound := "No tactics are missing documentation."
3030
errorsFound := "TACTICS ARE MISSING DOCUMENTATION STRINGS:"
3131
test tac := do

MathlibTest/HashLint.lean

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
module
2+
3+
import Mathlib.Init
4+
5+
/-! Checks that a basic `#lint` works. -/
6+
7+
/--
8+
info: -- Found 0 errors in 0 declarations (plus 0 automatically generated ones) in the current file with 16 linters
9+
10+
11+
-- All linting checks passed!
12+
-/
13+
#guard_msgs in
14+
#lint

0 commit comments

Comments
 (0)