Skip to content

Commit 4f3f68b

Browse files
committed
Adding "Loading..." text to dialogs
1 parent 7e2d306 commit 4f3f68b

4 files changed

Lines changed: 8 additions & 9 deletions

File tree

TODO.md

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,6 @@ This project was put together rather quickly, and there are many polishing
55
tasks that should be done to improve the overall quality of this module.
66
I list them in this file.
77

8-
## Functionality
9-
10-
* When the file browser, show a "loading..." message until it is
11-
populated.
12-
138
## Aesthetics
149

1510
* The open/save dialogs are extremely ugly, because near-zero CSS styling
@@ -21,8 +16,8 @@ I list them in this file.
2116
* The Open, Save, and Cancel buttons are defined in
2217
[dialog.html](dialog.html), and you can see their element types and
2318
IDs there.
24-
* In that same HTML file you will find the IDs for the files list and
25-
buttons footer.
19+
* In that same HTML file you will find the IDs for the files list, the
20+
buttons footer, and the "Loading..." text.
2621
* Other tidbits appear in the existing [dialog.css](dialog.css) file.
2722
* Consider replacing them entirely with
2823
[jquery.filebrowser](https://github.com/jcubic/jquery.filebrowser)

example/example.html

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@
55
<head>
66
<!-- Import the cloud storage module. -->
77
<script src='https://cdn.jsdelivr.net/gh/lurchmath/cloud-storage@v2.0.1/release/cloud-storage.js'></script>
8+
<!-- Developers testing cloud-storage updates can use this line: -->
9+
<!--
10+
<script src='../release/cloud-storage.js'></script>
11+
-->
812
<!-- We aim to test the Dropbox backend, so we need its SDK. -->
913
<script src='https://unpkg.com/dropbox/dist/Dropbox-sdk.min.js'>
1014
</script>

release/cloud-storage.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

source/dialog.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
</head>
1515
<body>
1616
<!-- The files/folders list is displayed in the following DIV. -->
17-
<div id='filesList'></div>
17+
<div id='filesList'><span id='loading'>Loading...</span></div>
1818
<!--
1919
The following footer appears at the bottom of the dialog, placed
2020
there by CSS styling in dialog.css. Its various elements are not

0 commit comments

Comments
 (0)