Skip to content

Commit 099506c

Browse files
George G. Davisgregkh
authored andcommitted
serial: sh-sci: disable DMA for uart_console
As noted in commit 84b40e3 ("serial: 8250: omap: Disable DMA for console UART"), UART console lines use low-level PIO only access functions which will conflict with use of the line when DMA is enabled, e.g. when the console line is also used for systemd messages. So disable DMA support for UART console lines. Reported-by: Michael Rodin <mrodin@de.adit-jv.com> Link: https://patchwork.kernel.org/patch/10929511/ Tested-by: Eugeniu Rosca <erosca@de.adit-jv.com> Reviewed-by: Simon Horman <horms+renesas@verge.net.au> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Cc: stable@vger.kernel.org Signed-off-by: George G. Davis <george_davis@mentor.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 8178eeb commit 099506c

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

drivers/tty/serial/sh-sci.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1557,6 +1557,13 @@ static void sci_request_dma(struct uart_port *port)
15571557

15581558
dev_dbg(port->dev, "%s: port %d\n", __func__, port->line);
15591559

1560+
/*
1561+
* DMA on console may interfere with Kernel log messages which use
1562+
* plain putchar(). So, simply don't use it with a console.
1563+
*/
1564+
if (uart_console(port))
1565+
return;
1566+
15601567
if (!port->dev->of_node)
15611568
return;
15621569

0 commit comments

Comments
 (0)