Revert "ASoC: SOF: Intel: MTL: Enable DMI L1"

ujfalusi · ujfalusi · commit eb236d546b5b · 2023-03-10T16:06:59.000+02:00
This reverts commit 04f818c. It came to our attention that the access to the EM2 register is restricted to the DSP side on MTL compared to prior platforms. Writing to it from the host side has no effect (negative or positive), it is better to remove the code to not cause confusion and wrong impression. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
diff --git a/sound/soc/sof/intel/mtl.c b/sound/soc/sof/intel/mtl.c
@@ -283,9 +283,6 @@ static int mtl_dsp_post_fw_run(struct snd_sof_dev *sdev)
 	}
 
 	hda_sdw_int_enable(sdev, true);
-
-	/* enable DMI L1 */
-	snd_sof_dsp_update_bits(sdev, HDA_DSP_HDA_BAR, MTL_EM2, MTL_EM2_L1SEN, MTL_EM2_L1SEN);
 	return 0;
 }
 
diff --git a/sound/soc/sof/intel/mtl.h b/sound/soc/sof/intel/mtl.h
@@ -28,8 +28,6 @@
 #define MTL_HFINTIPPTR_PTR_MASK		GENMASK(20, 0)
 
 #define MTL_HDA_VS_D0I3C		0x1D4A
-#define MTL_EM2				0x1c44
-#define MTL_EM2_L1SEN			BIT(13)
 
 #define MTL_DSP2CXCAP_PRIMARY_CORE	0x178D00
 #define MTL_DSP2CXCTL_PRIMARY_CORE	0x178D04

Original file line number	Diff line number	Diff line change
`@@ -283,9 +283,6 @@ static int mtl_dsp_post_fw_run(struct snd_sof_dev *sdev)`
`283`	`283`	`}`
`284`	`284`
`285`	`285`	`hda_sdw_int_enable(sdev, true);`
`286`		`-`
`287`		`- /* enable DMI L1 */`
`288`		`- snd_sof_dsp_update_bits(sdev, HDA_DSP_HDA_BAR, MTL_EM2, MTL_EM2_L1SEN, MTL_EM2_L1SEN);`
`289`	`286`	`return 0;`
`290`	`287`	`}`
`291`	`288`