Skip to content

Commit 63fffef

Browse files
e2e: update backward compat for multicast group Index requirement
1 parent f78596e commit 63fffef

1 file changed

Lines changed: 14 additions & 16 deletions

File tree

e2e/compatibility_test.go

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -91,24 +91,22 @@ func before(v string) []versionRange {
9191
}
9292

9393
var knownIncompatibilities = map[string]knownIncompat{
94-
// multicast_group_create: The MulticastGroupCreateArgs Borsh struct changed in v0.8.1.
95-
// The index and bump_seed fields were removed. Older CLIs send the old format which
96-
// causes Borsh deserialization failure in the current program.
97-
"write/multicast_group_create": {ranges: before("0.8.1")},
94+
// multicast_group_create: The CreateMulticastGroup instruction now requires an Index
95+
// account for unique code enforcement. All CLIs before v0.17.0 don't pass this account,
96+
// causing "insufficient account keys for instruction".
97+
"write/multicast_group_create": {ranges: before("0.17.0")},
9898

9999
// All multicast operations that depend on multicast_group_create. When the group
100-
// can't be created (< 0.8.1), these all fail with "MulticastGroup not found".
101-
"write/multicast_group_wait_activated": {ranges: before("0.8.1")},
102-
// multicast_group_update: In addition to the dependency above, v0.8.1-v0.8.8 parsed
103-
// --max-bandwidth as a plain integer. v0.8.9 added validate_parse_bandwidth (a855ca7a)
104-
// which accepts unit strings like "200Mbps".
105-
"write/multicast_group_update": {ranges: before("0.8.9")},
106-
"write/multicast_group_pub_allowlist_add": {ranges: before("0.8.1")},
107-
"write/multicast_group_pub_allowlist_remove": {ranges: before("0.8.1")},
108-
"write/multicast_group_sub_allowlist_add": {ranges: before("0.8.1")},
109-
"write/multicast_group_sub_allowlist_remove": {ranges: before("0.8.1")},
110-
"write/multicast_group_get": {ranges: before("0.8.1")},
111-
"write/multicast_group_delete": {ranges: before("0.8.1")},
100+
// can't be created, these all fail with "MulticastGroup not found".
101+
"write/multicast_group_wait_activated": {ranges: before("0.17.0")},
102+
"write/multicast_group_update": {ranges: before("0.17.0")},
103+
"write/multicast_group_pub_allowlist_add": {ranges: before("0.17.0")},
104+
"write/multicast_group_pub_allowlist_remove": {ranges: before("0.17.0")},
105+
"write/multicast_group_sub_allowlist_add": {ranges: before("0.17.0")},
106+
"write/multicast_group_sub_allowlist_remove": {ranges: before("0.17.0")},
107+
"write/multicast_group_get": {ranges: before("0.17.0")},
108+
"write/multicast_group_delete": {ranges: before("0.17.0")},
109+
"write/user_subscribe": {ranges: before("0.17.0")},
112110

113111
// set-health commands: The CLI subcommand was added in commit eb7ea308 (Jan 16).
114112
// mainnet-beta v0.8.2 was built Jan 13 (before set-health) → doesn't have it.

0 commit comments

Comments
 (0)