Add clientside nodraw networking workaround

Made to prevent the CC exclusion mask from drawing beams when disabled, but designed with general use in mind

Author: Blixibon

sp/src/game/client/c_baseentity.cpp

@@ -3710,7 +3710,9 @@ void C_BaseEntity::ComputeFxBlend( void )
 //-----------------------------------------------------------------------------
 int C_BaseEntity::GetFxBlend( void )
 {
+#ifndef MAPBASE // Spams the console when drawing beams in stencils, which don't need to update the FX blend
 	Assert( m_nFXComputeFrame == gpGlobals->framecount );
+#endif
 	return m_nRenderFXBlend;
 }
 

sp/src/game/client/clientmode_shared.cpp

@@ -282,6 +282,22 @@ static void __MsgFunc_VGUIMenu( bf_read &msg )
 	gViewPortInterface->ShowPanel( viewport, bShow );
 }
 
+#ifdef MAPBASE
+static void __MsgFunc_NodrawToggle( bf_read &msg )
+{
+	C_BaseEntity *pEntity = C_BaseEntity::Instance( msg.ReadShort() );
+	bool bEnable = msg.ReadOneBit();
+
+	if ( pEntity )
+	{
+		if ( bEnable )
+			pEntity->AddEffects( EF_NODRAW );
+		else
+			pEntity->RemoveEffects( EF_NODRAW );
+	}
+}
+ #endif
+
 //-----------------------------------------------------------------------------
 // Purpose: 
 //-----------------------------------------------------------------------------
@@ -387,6 +403,9 @@ void ClientModeShared::Init()
 
 	HOOK_MESSAGE( VGUIMenu );
 	HOOK_MESSAGE( Rumble );
+#ifdef MAPBASE
+	HOOK_MESSAGE( NodrawToggle );
+#endif
 }
 
 

sp/src/game/server/baseentity.cpp

@@ -4404,6 +4404,30 @@ void CBaseEntity::SetTransmit( CCheckTransmitInfo *pInfo, bool bAlways )
 }
 
 
+#ifdef MAPBASE
+//-----------------------------------------------------------------------------
+// Purpose: If true, this entity will notify clients when EF_NODRAW is set.
+// 			This is mainly a band-aid for when the client paradoxically wants
+//	 		to know this.
+//-----------------------------------------------------------------------------
+void CBaseEntity::OnNodrawToggled()
+{
+	if ( ShouldNetworkNodraw() )
+	{
+		// MP TODO: Optimize who receives this message?
+		CRecipientFilter filter;
+		filter.AddAllPlayers();
+		filter.MakeReliable();
+
+		UserMessageBegin( filter, "NodrawToggle" );
+			WRITE_ENTITY( entindex() );
+			WRITE_BOOL( IsEffectActive( EF_NODRAW ) );
+		MessageEnd();
+	}
+}
+#endif
+
+
 //-----------------------------------------------------------------------------
 // Returns which skybox the entity is in
 //-----------------------------------------------------------------------------

sp/src/game/server/baseentity.h

@@ -559,6 +559,13 @@ class CBaseEntity : public IServerEntity
 	void					SetSimulatedEveryTick( bool sim );
 	void					SetAnimatedEveryTick( bool anim );
 
+#ifdef MAPBASE
+	// If true, this entity will notify clients when EF_NODRAW is set.
+	// This is mainly a band-aid for when the client paradoxically wants to know this.
+	virtual bool			ShouldNetworkNodraw() { return false; }
+	void					OnNodrawToggled();
+#endif
+
 public:
 
 	virtual const char	*GetTracerType( void );

sp/src/game/shared/baseentity_shared.cpp

@@ -224,6 +224,12 @@ void CBaseEntity::SetEffects( int nEffects )
 #endif // HL2_EPISODIC
 #endif // !CLIENT_DLL
 
+#if defined(MAPBASE) && !defined(CLIENT_DLL)
+		// Nodraw was added or removed
+		if ( (m_fEffects ^ nEffects) & EF_NODRAW )
+			OnNodrawToggled();
+#endif
+
 		m_fEffects = nEffects;
 
 #ifndef CLIENT_DLL
@@ -255,6 +261,9 @@ void CBaseEntity::AddEffects( int nEffects )
 	{
 #ifndef CLIENT_DLL
 		DispatchUpdateTransmitState();
+#ifdef MAPBASE
+		OnNodrawToggled();
+#endif
 #else
 		UpdateVisibility();
 #endif

sp/src/game/shared/baseentity_shared.h

@@ -216,6 +216,9 @@ inline void CBaseEntity::RemoveEffects( int nEffects )
 #ifndef CLIENT_DLL
 		NetworkProp()->MarkPVSInformationDirty();
 		DispatchUpdateTransmitState();
+#ifdef MAPBASE
+		OnNodrawToggled();
+#endif
 #else
 		UpdateVisibility();
 #endif

sp/src/game/shared/beam_shared.cpp

@@ -278,6 +278,10 @@ BEGIN_DATADESC( CBeam )
 
 	DEFINE_KEYFIELD( m_nDissolveType, FIELD_INTEGER, "dissolvetype" ),
 
+#ifdef MAPBASE
+	DEFINE_FIELD( m_bNetworkNodraw, FIELD_BOOLEAN ),
+#endif
+
 #ifdef PORTAL
 	DEFINE_FIELD( m_bDrawInMainRender, FIELD_BOOLEAN ),
 	DEFINE_FIELD( m_bDrawInPortalRender, FIELD_BOOLEAN ),
@@ -918,6 +922,16 @@ int CBeam::ShouldTransmit( const CCheckTransmitInfo *pInfo )
 	return BaseClass::ShouldTransmit( pInfo );
 }
 
+#ifdef MAPBASE
+bool CBeam::ShouldNetworkNodraw()
+{
+	if ( m_bNetworkNodraw )
+		return true;
+
+	return BaseClass::ShouldNetworkNodraw();
+}
+#endif
+
 #endif
 
 //-----------------------------------------------------------------------------

sp/src/game/shared/beam_shared.h

@@ -64,6 +64,10 @@ class CBeam : public CBaseEntity
 	void	SetTransmit( CCheckTransmitInfo *pInfo, bool bAlways );
 	int		UpdateTransmitState( void );
 	int		ShouldTransmit( const CCheckTransmitInfo *pInfo );
+#ifdef MAPBASE
+	bool	ShouldNetworkNodraw();
+	void	SetNetworkNodraw( bool bToggle ) { m_bNetworkNodraw = bToggle; }
+#endif
 #endif
 
 	virtual int DrawDebugTextOverlays(void);
@@ -235,6 +239,10 @@ class CBeam : public CBaseEntity
 
 #if !defined( CLIENT_DLL )
 	int			m_nDissolveType;
+
+#ifdef MAPBASE
+	bool		m_bNetworkNodraw;
+#endif
 #endif
 
 public:

sp/src/game/shared/mapbase/mapbase_usermessages.cpp

@@ -22,6 +22,8 @@ void HookMapbaseUserMessages( void )
 	//HOOK_MESSAGE( ScriptMsg ); // Hooked in CNetMsgScriptHelper
 
 	//HOOK_MESSAGE( ShowMenuComplex ); // Hooked in CHudMenu
+	
+	//HOOK_MESSAGE( NodrawToggle ); // Hooked in ClientModeShared
 }
 #endif
 
@@ -31,6 +33,8 @@ void RegisterMapbaseUserMessages( void )
 	usermessages->Register( "ScriptMsg", -1 ); // CNetMsgScriptHelper
 
 	usermessages->Register( "ShowMenuComplex", -1 ); // CHudMenu
+	
+	usermessages->Register( "NodrawToggle", 3 ); // ClientModeShared
 
 #ifdef CLIENT_DLL
 	// TODO: Better placement?