Skip to content

Commit eaf5cff

Browse files
committed
reset label font
1 parent 3316269 commit eaf5cff

6 files changed

Lines changed: 13 additions & 8 deletions

File tree

app/javascript/controllers/map_controller.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,15 @@ import { initializeEditMode } from 'maplibre/edit'
66
import { initializeSocket, mapChannel } from 'channels/map_channel'
77
import { addUndoState, clearUndoHistory } from 'maplibre/undo'
88
import { resetInitializationState } from 'maplibre/layers/layers'
9-
import { clearImageState } from 'maplibre/styles/styles'
9+
import { clearImageState, resetLabelFont } from 'maplibre/styles/styles'
1010

1111
export default class extends Controller {
1212
async connect () {
1313
// Clear module-level state from previous map
1414
resetInitializationState()
1515
clearImageState()
1616
clearUndoHistory()
17+
resetLabelFont()
1718

1819
functions.e('#map-header nav', e => { e.style.display = 'none' })
1920
await initializeMap('maplibre-map')
@@ -45,6 +46,7 @@ export default class extends Controller {
4546
resetInitializationState()
4647
clearImageState()
4748
clearUndoHistory()
49+
resetLabelFont()
4850
}
4951

5052
// paste feature from clipboard

app/javascript/maplibre/layers/basemap.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ export class BasemapLayer extends Layer {
4545
const features = map.queryRenderedFeatures(e.point, { layers: queryLayerIds})
4646

4747
if (features.length) {
48+
console.log('Selected features: ', features)
4849
const feature = features[0]
4950

5051
const geojsonFeature = {

app/javascript/maplibre/styles/styles.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export const viewStyleNames = [
3131
'polygon-layer-extrusion'
3232
]
3333

34-
export function setStyleDefaultFont (font) { labelFont = [font] }
34+
export function setStyleDefaultFont(font) { labelFont = [font] }
3535

3636
export function initializeViewStyles (sourceName, heatmap=false) {
3737
// console.log('Initializing view styles for source ' + sourceName)
@@ -127,6 +127,9 @@ export function clearImageState() {
127127
Object.keys(imageState).forEach(key => delete imageState[key])
128128
}
129129

130+
// Reset labelFont to default when clearing state
131+
export function resetLabelFont() { labelFont = [defaultFont] }
132+
130133
export async function loadImage (e) {
131134
// Skip if already loading, loaded, or failed
132135
if (imageState[e.id]) {
@@ -400,9 +403,7 @@ function textLayerStyles(mode) {
400403
'format',
401404
['coalesce', ['get', 'label'], ['get', 'room']],
402405
{
403-
'text-font': [
404-
'case',
405-
['has', 'label-font'],
406+
'text-font': ['coalesce',
406407
['get', 'label-font'],
407408
['literal', labelFont]
408409
]

app/javascript/maplibre/undo.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export function clearUndoHistory() {
2020
const redoBtn = document.querySelector('button.maplibregl-ctrl-redo')
2121
if (undoBtn) undoBtn.classList.add('hidden')
2222
if (redoBtn) redoBtn.classList.add('hidden')
23-
} catch (_e) {
23+
} catch {
2424
// Buttons may not exist yet
2525
}
2626
}

app/models/layer.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ class Layer
66
belongs_to :map, optional: true, touch: true
77
has_many :features, dependent: :destroy
88

9+
default_scope { reorder(created_at: :asc) }
910
scope :geojson, -> { where(type: "geojson") }
1011
scope :overpass, -> { where(type: "overpass") }
1112

app/models/map.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ class Map
88
belongs_to :user, optional: true, counter_cache: true
99

1010
# implicit_order_column is not supported by mongoid
11-
default_scope { sorted(:created_at, :desc) }
11+
default_scope { sorted(:created_at, :asc) }
1212
scope :listed, -> { where(view_permission: "listed") }
1313
scope :ulogger, -> { where(:_id.lt => BSON::ObjectId("000000000000002147483647")) }
1414
scope :demo, -> { where(demo: true) }
@@ -19,7 +19,7 @@ class Map
1919
}
2020
scope :sorted, ->(col, dir) {
2121
col = "created_at" unless col.present?
22-
dir = %w[asc desc].include?(dir) ? dir : "asc"
22+
dir = %w[asc desc].include?(dir) ? dir.to_s : "asc"
2323
reorder(col.to_sym => dir.to_sym)
2424
}
2525

0 commit comments

Comments
 (0)