Extension default config working

Author: markelca

lua/clapi/finder.lua

@@ -1,4 +1,4 @@
-local conf = require("telescope.config").values
+local telescope_config = require("telescope.config").values
 local finders = require("telescope.finders")
 local pickers = require("telescope.pickers")
 local make_entry = require("clapi.make_entry")
@@ -20,13 +20,6 @@ M.builtin = function(opts)
 	opts.bufnr = opts.bufnr or 0
 	opts.path_display = { "hidden" }
 
-	-- Get extension configuration
-	local telescope_config = require("telescope.config").values
-	local ext_config = telescope_config.extensions and telescope_config.extensions.clapi or {}
-
-	-- Set show_inherited default value (true if not specified)
-	opts.show_inherited = vim.F.if_nil(opts.show_inherited, ext_config.show_inherited, true)
-
 	async.run(function()
 		local results = parser.parse_file(opts)
 		if not results then
@@ -41,10 +34,10 @@ M.builtin = function(opts)
 					results = results,
 					entry_maker = opts.entry_maker or make_entry.gen_from_lsp_symbols(opts),
 				}),
-				previewer = conf.qflist_previewer(opts),
-				sorter = conf.prefilter_sorter({
+				previewer = telescope_config.qflist_previewer(opts),
+				sorter = telescope_config.prefilter_sorter({
 					tag = "symbol_type",
-					sorter = conf.generic_sorter(opts),
+					sorter = telescope_config.generic_sorter(opts),
 				}),
 				push_cursor_on_edit = true,
 				push_tagstack_on_edit = true,

lua/clapi/parser/init.lua

@@ -46,7 +46,14 @@ end
 local get_parent_file = async.wrap(function(opts, callback)
 	opts = opts or {}
 	opts.bufnr = opts.bufnr or 0
-	opts.show_inherited = vim.F.if_nil(opts.show_inherited, true)
+	-- Use explicit check for boolean values since vim.F.if_nil doesn't handle false properly
+	if opts.show_inherited ~= nil then
+		-- Keep the provided value (could be true or false)
+		opts.show_inherited = opts.show_inherited
+	else
+		-- Default to true if not specified
+		opts.show_inherited = true
+	end
 
 	local filetype = tsparsers.get_buf_lang(opts.bufnr)
 	local parser = vim.treesitter.get_parser(opts.bufnr, filetype)
@@ -114,7 +121,7 @@ local get_parent_file = async.wrap(function(opts, callback)
 				local defs = M.parse_file({
 					filename = filepath,
 					class_name = class_name,
-					show_inherited = opts.show_inherited
+					show_inherited = opts.show_inherited,
 				})
 				for _, value in pairs(defs) do
 					if value["visibility"] ~= "private" then
@@ -139,7 +146,6 @@ end, 2)
 M.parse_file = async.wrap(function(opts, callback)
 	opts = opts or {}
 	opts.class_name = opts.class_name and string.format("%s::", opts.class_name) or ""
-	opts.show_inherited = vim.F.if_nil(opts.show_inherited, true)
 
 	if opts.filename and opts.bufnr then
 		utils.notify("parse_file", {
@@ -270,9 +276,9 @@ M.parse_file = async.wrap(function(opts, callback)
 	-- Only include inherited members if show_inherited is true
 	if opts.show_inherited then
 		async.run(function()
-			local parent_defs = get_parent_file({ 
+			local parent_defs = get_parent_file({
 				bufnr = opts.bufnr,
-				show_inherited = opts.show_inherited
+				show_inherited = opts.show_inherited,
 			})
 			if not parent_defs then
 				-- error already printed somewhere
@@ -290,4 +296,5 @@ M.parse_file = async.wrap(function(opts, callback)
 	end
 end, 2)
 
-return M
+return M
+

lua/telescope/_extensions/clapi.lua

@@ -2,8 +2,19 @@
 -- local x = require("clapi").builtin
 local telescope = require("telescope")
 
+local default_config = {
+	show_inherited = true,
+}
+
 return telescope.register_extension({
+	setup = function(ext_config)
+		default_config = vim.tbl_deep_extend("force", default_config, ext_config or {})
+	end,
 	exports = {
-		clapi = require("clapi").builtin, -- More complex builtin
+		clapi = function()
+			-- We copy the config to avoid polluting the extension default config between executions
+			local config = vim.deepcopy(default_config)
+			return require("clapi").builtin(config)
+		end,
 	},
 })