Fixed edge case for inifine recursion

Author: markelca

lua/clapi/parser/init.lua

@@ -4,6 +4,15 @@ local tsparsers = require("nvim-treesitter.parsers")
 local async = require("plenary.async")
 local lsp = require("clapi.lsp")
 
+--- Keeps track of the analyzed files to avoid infinite recursion
+local files_analyzed = {}
+
+--- We clear the table to reset the analyzed files.
+--- This is important because the value persist between builtint executions
+local function clear_files_analyzed()
+	files_analyzed = {}
+end
+
 ---@class ParserModule
 local M = {}
 
@@ -110,6 +119,14 @@ local get_parent_file = async.wrap(function(opts, callback)
 
 				local filepath =
 					lsp.get_file_from_position({ bufnr = opts.bufnr, position = { character = char, line = line } })
+
+				if files_analyzed[filepath] then
+					callback(nil)
+					return
+				end
+
+				files_analyzed[filepath] = true
+
 				if not filepath or filepath == "" then
 					-- error already printed in get_file_from_position
 					callback(nil)
@@ -312,9 +329,11 @@ M.parse_file = async.wrap(function(opts, callback)
 				end
 			end
 
+			clear_files_analyzed()
 			callback(result)
 		end)
 	else
+		clear_files_analyzed()
 		callback(result)
 	end
 end, 2)

tests/clapi/functional/parser_php_recursion_spec.lua

@@ -0,0 +1,45 @@
+local parser = require("clapi.parser.init")
+local t = require("plenary.async.tests")
+
+t.describe("parser.parse_file with recursive inheritance", function()
+	t.it("should handle recursive inheritance without infinite loops", function()
+		local src_root_dir = vim.fn.getcwd() .. "/tests/clapi/functional/resources/code/php/example/src"
+		local filename = src_root_dir .. "/Course/Recursive.php"
+		vim.cmd("edit " .. filename)
+		local bufnr = vim.api.nvim_get_current_buf()
+		local client_id = vim.lsp.start({
+			name = "phpactor",
+			cmd = { "phpactor", "language-server", "-vvv" },
+			root_dir = src_root_dir,
+			capabilities = vim.lsp.protocol.make_client_capabilities(),
+		})
+		vim.lsp.buf_attach_client(bufnr, client_id)
+		vim.wait(3000)
+
+		local result = parser.parse_file({
+			bufnr = bufnr,
+			show_inherited = true,
+		})
+
+		-- Test that we get results without hanging due to recursion
+		assert.is_table(result)
+		
+		-- Verify the expected methods are found
+		local found_get_subscribed_services = false
+		local found_get_view_handler = false
+		
+		for _, item in ipairs(result) do
+			if item.text == "[Function] getSubscribedServices" or 
+			   item.text == "[Function] BaseAbstractFOSRestController::getSubscribedServices" then
+				found_get_subscribed_services = true
+			end
+			if item.text == "[Function] getViewHandler" or 
+			   item.text == "[Function] AbstractFOSRestController::getViewHandler" then
+				found_get_view_handler = true
+			end
+		end
+		
+		assert.is_true(found_get_subscribed_services, "Should find getSubscribedServices method")
+		assert.is_true(found_get_view_handler, "Should find getViewHandler method")
+	end)
+end)