function with a name that another function also has is not inlined

[flocsy]

When I have a function that has the name of another function (in another class), then the inlining doesn't work:

class MyClass {
  (:inline)
  hidden function notifyNewSensor(antId as Number, msg as Message) as Void {
    //...
    Sensor.notifyNewSensor(sensorInfo, false);
  }

  function foo() as Void {
    notifyNewSensor(123, message);
  }
}

And I get this:
The inline function notifyNewSensor was not removed from the program

[flocsy]

Note that it looks like it only happens if my function has a name that is like a function somewhere in the SDK. It doesn't seem to happen if there's a function with the same name in another class of mine.

[markw65]

The code that removes unused functions pre-dates most of the analysis I do, so was very simplistic about removing unused code. Essentially, it only removes things whose names are not used elsewhere.

This also means that cycles are never removed - if A calls B, and B calls A, then neither will be removed, even if there are no calls to A or B anywhere in the program.

The correct way to do this is to start from the Application class and recursively mark everything that it references, and then throw out everything else.

I think I'm pretty much at the point that I could do that - but eg there can be references from resources to Classes that need to be accounted for, that could easily be missed (Garmin tends to document by example, rather than by exhaustively listing the syntax/semantics, so it's hard to be sure I'm analyzing every possible reference).

Anyway, that should explain why the inline functions aren't removed; I'm surprised they aren't inlined - that shouldn't be affected, unless the optimizer can't determine which function is being called (eg if you're overriding a method from a base class, or calling a function through a local whose type can't be fully pinned down). Can you give me an example where inlining doesn't take place due to a same named function elsewhere?

[flocsy]

You're right, it IS inlined, it is just not removed, which is even worse in my opinion, since we use the optimizer to optimize for size. When it decides it can't remove the method with (:inline) annotation, then IMHO it would be better not to inline (at least for big functions)

fr955: Example.mc:3:5: The inline function notifyNewSensor was not removed from the program