fix(config): add default server if none is specified

fix(config): fix convert server from Swagger to OpenAPI if no basePath is specified

Author: marle3003

providers/openapi/config.go

@@ -114,6 +114,10 @@ func (c *Config) Parse(config *dynamic.Config, reader dynamic.Reader) error {
 		return nil
 	}
 
+	if len(c.Servers) == 0 {
+		c.Servers = append(c.Servers, &Server{Url: "/"})
+	}
+
 	config.Scope.OpenIfNeeded(config.Info.Path())
 
 	return c.Paths.parse(config, reader)

providers/openapi/config_test.go

@@ -146,6 +146,45 @@ paths:
 	}
 }
 
+func TestConfig_Parse(t *testing.T) {
+	testcases := []struct {
+		name   string
+		config *openapi.Config
+		test   func(t *testing.T, config *openapi.Config, err error)
+	}{
+		{
+			name:   "empty server",
+			config: &openapi.Config{},
+			test: func(t *testing.T, config *openapi.Config, err error) {
+				require.NoError(t, err)
+				require.Len(t, config.Servers, 1)
+				require.Equal(t, "/", config.Servers[0].Url)
+			},
+		},
+		{
+			name:   "one server",
+			config: openapitest.NewConfig("3.1.0", openapitest.WithServer("/foo", "")),
+			test: func(t *testing.T, config *openapi.Config, err error) {
+				require.NoError(t, err)
+				require.Len(t, config.Servers, 1)
+				require.Equal(t, "/foo", config.Servers[0].Url)
+			},
+		},
+	}
+
+	for _, tc := range testcases {
+		tc := tc
+		t.Run(tc.name, func(t *testing.T) {
+			t.Parallel()
+			err := tc.config.Parse(&dynamic.Config{
+				Data: tc.config,
+				Info: dynamictest.NewConfigInfo(),
+			}, &dynamictest.Reader{})
+			tc.test(t, tc.config, err)
+		})
+	}
+}
+
 func TestResponses(t *testing.T) {
 	testdata := []struct {
 		name    string
@@ -380,7 +419,7 @@ func TestPetStore_Response(t *testing.T) {
 	require.Nil(t, m)
 }
 
-func TestPetStore_Paramters(t *testing.T) {
+func TestPetStore_Parameters(t *testing.T) {
 	config := &openapi.Config{}
 	err := yaml.Unmarshal([]byte(petstore), &config)
 	require.NoError(t, err)

providers/swagger/convert.go

@@ -30,7 +30,11 @@ func (c *converter) Convert() (*openapi.Config, error) {
 
 	if len(c.config.Schemes) == 0 {
 		if len(c.config.Host) == 0 {
-			result.Servers = append(result.Servers, &openapi.Server{Url: c.config.BasePath})
+			if c.config.BasePath == "" {
+				result.Servers = append(result.Servers, &openapi.Server{Url: "/"})
+			} else {
+				result.Servers = append(result.Servers, &openapi.Server{Url: c.config.BasePath})
+			}
 		} else {
 			result.Servers = append(result.Servers, &openapi.Server{Url: fmt.Sprintf("http://%v%v", c.config.Host, c.config.BasePath)})
 		}

providers/swagger/convert_test.go

@@ -109,6 +109,14 @@ func TestConvert(t *testing.T) {
 				require.Equal(t, "https://foo/bar", config.Servers[0].Url)
 			},
 		},
+		{
+			name:   "scheme, host and basePath is empty",
+			config: `{"swagger": "2.0"}`,
+			test: func(t *testing.T, config *openapi.Config) {
+				require.Len(t, config.Servers, 1)
+				require.Equal(t, "/", config.Servers[0].Url)
+			},
+		},
 		{
 			name:   "path ref",
 			config: `{"swagger": "2.0","paths":{"/foo":{"$ref":"./foo.json"}}}`,