🐛 fix: Use DisposeAsyncCore method of base class (#606)

* 🐛 fix: Use DisposeAsyncCore method of base class

* 🐛 fix(Slider): do nothing if el was removed

Author: capdiem

src/Component/BlazorComponent.Web/src/components/slider/index.ts

@@ -75,9 +75,11 @@ export function registerSliderEvents(
 }
 
 export function unregisterSliderEvents(el: HTMLElement, id: number) {
-  const onSliderMouseDown = sliderHandlesById[id];
-  el.removeEventListener("mousedown", onSliderMouseDown);
-  el.removeEventListener("touchstart", onSliderMouseDown);
+  if (el) {
+    const onSliderMouseDown = sliderHandlesById[id];
+    el.removeEventListener("mousedown", onSliderMouseDown);
+    el.removeEventListener("touchstart", onSliderMouseDown);
 
-  delete sliderHandlesById[id];
+    delete sliderHandlesById[id];
+  }
 }

src/Component/BlazorComponent/Components/OtpInput/BOtpInput.razor.cs

@@ -2,7 +2,7 @@
 
 namespace BlazorComponent
 {
-    public partial class BOtpInput : BDomComponentBase, IOtpInput, IAsyncDisposable
+    public partial class BOtpInput : BDomComponentBase, IOtpInput
     {
         [CascadingParameter(Name = "IsDark")]
         public bool CascadingIsDark { get; set; }
@@ -257,17 +257,10 @@ public async Task OnPasteAsync(BOtpInputEventArgs<PasteWithDataEventArgs> events
             }
         }
 
-        async ValueTask IAsyncDisposable.DisposeAsync()
+        protected override async ValueTask DisposeAsyncCore()
         {
-            try
-            {
-                _handle.Dispose();
-                await JsInvokeAsync(JsInteropConstants.UnregisterOTPInputOnInputEvent, InputRefs);
-            }
-            catch (Exception)
-            {
-                // ignored
-            }
+            _handle.Dispose();
+            await JsInvokeAsync(JsInteropConstants.UnregisterOTPInputOnInputEvent, InputRefs);
         }
     }
 }

src/Component/BlazorComponent/Components/SlideGroup/BSlideGroup.razor.cs

@@ -1,6 +1,6 @@
 namespace BlazorComponent
 {
-    public partial class BSlideGroup : BItemGroup, ISlideGroup, IAsyncDisposable
+    public partial class BSlideGroup : BItemGroup, ISlideGroup
     {
         public BSlideGroup() : base(GroupType.SlideGroup)
         {
@@ -305,16 +305,9 @@ protected async Task OnResize()
             await SetWidths();
         }
 
-        async ValueTask IAsyncDisposable.DisposeAsync()
+        protected override async ValueTask DisposeAsyncCore()
         {
-            try
-            {
-                await ResizeJSModule.UnobserveAsync(Ref);
-            }
-            catch (Exception)
-            {
-                // ignored
-            }
+            await ResizeJSModule.UnobserveAsync(Ref);
         }
     }
 }

src/Component/BlazorComponent/Components/Tabs/BTabs.razor.cs

@@ -1,6 +1,6 @@
 namespace BlazorComponent
 {
-    public partial class BTabs : BDomComponentBase, ITabs, IAncestorRoutable, IAsyncDisposable
+    public partial class BTabs : BDomComponentBase, ITabs, IAncestorRoutable
     {
         [Inject]
         protected IResizeJSModule ResizeJSModule { get; set; } = null!;
@@ -168,16 +168,9 @@ private async Task OnResize()
             await CallSlider();
         }
 
-        async ValueTask IAsyncDisposable.DisposeAsync()
+        protected override async ValueTask DisposeAsyncCore()
         {
-            try
-            {
-                await ResizeJSModule.UnobserveAsync(Ref);
-            }
-            catch (Exception)
-            {
-                // ignored
-            }
+            await ResizeJSModule.UnobserveAsync(Ref);
         }
     }
 }