Skip to content

Commit 609ecbf

Browse files
author
Mateusz
committed
fix(acp): remove duplicate exe init and rename stale-kill config test
- Drop redundant cur_exe assignment in stale_kill_still_same_os_process. - Rename test to match behavior (env applies when CLI not passed). Made-with: Cursor
1 parent b7ec066 commit 609ecbf

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

src/connectors/acp_core/acp_subprocess_identity.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ def stale_kill_still_same_os_process(
114114
return False
115115

116116
if identity.exe_key:
117-
cur_exe = ""
118117
cur_exe = ""
119118
with contextlib.suppress(_psutil.AccessDenied, _psutil.Error):
120119
cur_exe = _normalize_exe_key(current.exe())

tests/unit/core/config/test_stale_acp_agent_kills_config.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,8 @@ def test_load_config_merges_disable_stale_acp_agent_kills_from_env() -> None:
7777
assert cfg.disable_stale_acp_agent_kills is True
7878

7979

80-
def test_cli_overrides_env_false_stale_kills_enabled_via_cli() -> None:
81-
"""Env requests disable; CLI does not pass --disable -> env wins."""
80+
def test_env_disables_stale_kills_when_cli_not_passed() -> None:
81+
"""Env requests disable; CLI not used -> env applies."""
8282
merged = {"DISABLE_STALE_ACP_AGENT_KILLS": "true"}
8383
with patch.dict("os.environ", merged, clear=True):
8484
args = parse_cli_args([])

0 commit comments

Comments
 (0)