Skip to content

Commit a77212c

Browse files
author
Mateusz
committed
test(cli): add cat_file_edits_steering_enabled to session applicator fixture
Keeps empty_args Namespace aligned with new CLI dest for cat file edits steering (Windows CRLF normalization may widen the diff). Made-with: Cursor
1 parent cd34fbc commit a77212c

1 file changed

Lines changed: 93 additions & 92 deletions

File tree

tests/unit/core/cli_support/applicators/test_session_applicator.py

Lines changed: 93 additions & 92 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,15 @@ def applicator(self):
3434
@pytest.fixture
3535
def empty_args(self) -> CliArgs:
3636
"""Create empty CLI arguments namespace."""
37-
return argparse.Namespace(
38-
disable_interactive_mode=None,
39-
force_set_project=None,
40-
project_dir_resolution_model=None,
41-
project_dir_resolution_mode=None,
42-
project_dir_resolution_filesystem_mode=None,
43-
disable_default_openrouter_project_dir_resolution_fallback=None,
44-
disable_interactive_commands=None,
45-
quality_verifier_model=None,
37+
return argparse.Namespace(
38+
disable_interactive_mode=None,
39+
force_set_project=None,
40+
project_dir_resolution_model=None,
41+
project_dir_resolution_mode=None,
42+
project_dir_resolution_filesystem_mode=None,
43+
disable_default_openrouter_project_dir_resolution_fallback=None,
44+
disable_interactive_commands=None,
45+
quality_verifier_model=None,
4646
quality_verifier_frequency=None,
4747
quality_verifier_ttft_timeout_seconds=None,
4848
quality_verifier_tool_followup_weight=None,
@@ -55,13 +55,14 @@ def empty_args(self) -> CliArgs:
5555
planning_phase_reasoning_effort=None,
5656
planning_phase_thinking_budget=None,
5757
pytest_full_suite_steering_enabled=None,
58+
cat_file_edits_steering_enabled=None,
5859
pytest_context_saving_enabled=None,
5960
test_execution_reminder_enabled=None,
6061
fix_think_tags_enabled=None,
61-
disable_dangerous_git_commands_protection=None,
62-
disable_double_ampersand_fixes_for_windows=None,
63-
disable_auto_continue_removal=None,
64-
droid_path_fix_enabled=None,
62+
disable_dangerous_git_commands_protection=None,
63+
disable_double_ampersand_fixes_for_windows=None,
64+
disable_auto_continue_removal=None,
65+
droid_path_fix_enabled=None,
6566
tool_access_allowed_tools=None,
6667
tool_access_blocked_tools=None,
6768
tool_access_default_policy=None,
@@ -111,7 +112,7 @@ def test_apply_force_set_project(
111112
assert overrides["session"].get("force_set_project") is True
112113
assert os.environ.get("FORCE_SET_PROJECT") == "true"
113114

114-
def test_apply_planning_phase_enabled(
115+
def test_apply_planning_phase_enabled(
115116
self,
116117
applicator,
117118
empty_args: CliArgs,
@@ -123,62 +124,62 @@ def test_apply_planning_phase_enabled(
123124
applicator.apply(empty_args, overrides, resolution)
124125

125126
assert "session" in overrides
126-
assert "planning_phase" in overrides["session"]
127-
assert overrides["session"]["planning_phase"].get("enabled") is True
128-
129-
def test_apply_project_dir_resolution_filesystem_mode(
130-
self,
131-
applicator,
132-
empty_args: CliArgs,
133-
overrides: CliOverrides,
134-
resolution: ParameterResolution,
135-
) -> None:
136-
"""Test that project_dir_resolution_filesystem_mode is applied correctly."""
137-
empty_args.project_dir_resolution_filesystem_mode = "disabled"
138-
applicator.apply(empty_args, overrides, resolution)
139-
140-
assert "session" in overrides
141-
assert (
142-
overrides["session"].get("project_dir_resolution_filesystem_mode")
143-
== "disabled"
144-
)
145-
cli_records = resolution.latest_by_source(ParameterSource.CLI)
146-
assert "session.project_dir_resolution_filesystem_mode" in cli_records
147-
assert (
148-
cli_records["session.project_dir_resolution_filesystem_mode"].origin
149-
== "--project-dir-resolution-filesystem-mode"
150-
)
151-
152-
def test_apply_disable_default_openrouter_project_dir_resolution_fallback(
153-
self,
154-
applicator,
155-
empty_args: CliArgs,
156-
overrides: CliOverrides,
157-
resolution: ParameterResolution,
158-
) -> None:
159-
empty_args.disable_default_openrouter_project_dir_resolution_fallback = True
160-
applicator.apply(empty_args, overrides, resolution)
161-
162-
assert "session" in overrides
163-
assert (
164-
overrides["session"].get(
165-
"disable_default_openrouter_project_dir_resolution_fallback"
166-
)
167-
is True
168-
)
169-
cli_records = resolution.latest_by_source(ParameterSource.CLI)
170-
assert (
171-
"session.disable_default_openrouter_project_dir_resolution_fallback"
172-
in cli_records
173-
)
174-
assert (
175-
cli_records[
176-
"session.disable_default_openrouter_project_dir_resolution_fallback"
177-
].origin
178-
== "--disable-default-openrouter-project-dir-resolution-fallback"
179-
)
180-
181-
def test_apply_quality_verifier_ttft_timeout_seconds(
127+
assert "planning_phase" in overrides["session"]
128+
assert overrides["session"]["planning_phase"].get("enabled") is True
129+
130+
def test_apply_project_dir_resolution_filesystem_mode(
131+
self,
132+
applicator,
133+
empty_args: CliArgs,
134+
overrides: CliOverrides,
135+
resolution: ParameterResolution,
136+
) -> None:
137+
"""Test that project_dir_resolution_filesystem_mode is applied correctly."""
138+
empty_args.project_dir_resolution_filesystem_mode = "disabled"
139+
applicator.apply(empty_args, overrides, resolution)
140+
141+
assert "session" in overrides
142+
assert (
143+
overrides["session"].get("project_dir_resolution_filesystem_mode")
144+
== "disabled"
145+
)
146+
cli_records = resolution.latest_by_source(ParameterSource.CLI)
147+
assert "session.project_dir_resolution_filesystem_mode" in cli_records
148+
assert (
149+
cli_records["session.project_dir_resolution_filesystem_mode"].origin
150+
== "--project-dir-resolution-filesystem-mode"
151+
)
152+
153+
def test_apply_disable_default_openrouter_project_dir_resolution_fallback(
154+
self,
155+
applicator,
156+
empty_args: CliArgs,
157+
overrides: CliOverrides,
158+
resolution: ParameterResolution,
159+
) -> None:
160+
empty_args.disable_default_openrouter_project_dir_resolution_fallback = True
161+
applicator.apply(empty_args, overrides, resolution)
162+
163+
assert "session" in overrides
164+
assert (
165+
overrides["session"].get(
166+
"disable_default_openrouter_project_dir_resolution_fallback"
167+
)
168+
is True
169+
)
170+
cli_records = resolution.latest_by_source(ParameterSource.CLI)
171+
assert (
172+
"session.disable_default_openrouter_project_dir_resolution_fallback"
173+
in cli_records
174+
)
175+
assert (
176+
cli_records[
177+
"session.disable_default_openrouter_project_dir_resolution_fallback"
178+
].origin
179+
== "--disable-default-openrouter-project-dir-resolution-fallback"
180+
)
181+
182+
def test_apply_quality_verifier_ttft_timeout_seconds(
182183
self,
183184
applicator,
184185
empty_args: CliArgs,
@@ -195,28 +196,28 @@ def test_apply_quality_verifier_ttft_timeout_seconds(
195196
overrides["session"].get("quality_verifier_ttft_timeout_seconds")
196197
== 11.5
197198
)
198-
assert os.environ.get("QUALITY_VERIFIER_TTFT_TIMEOUT_SECONDS") == "11.5"
199-
200-
def test_apply_disable_auto_continue_removal(
201-
self,
202-
applicator,
203-
empty_args: CliArgs,
204-
overrides: CliOverrides,
205-
resolution: ParameterResolution,
206-
) -> None:
207-
"""Test disable flag maps to session.auto_continue_removal_enabled=False."""
208-
empty_args.disable_auto_continue_removal = True
209-
210-
applicator.apply(empty_args, overrides, resolution)
211-
212-
assert "session" in overrides
213-
assert overrides["session"].get("auto_continue_removal_enabled") is False
214-
cli_records = resolution.latest_by_source(ParameterSource.CLI)
215-
assert "session.auto_continue_removal_enabled" in cli_records
216-
assert (
217-
cli_records["session.auto_continue_removal_enabled"].origin
218-
== "--disable-auto-continue-removal"
219-
)
199+
assert os.environ.get("QUALITY_VERIFIER_TTFT_TIMEOUT_SECONDS") == "11.5"
200+
201+
def test_apply_disable_auto_continue_removal(
202+
self,
203+
applicator,
204+
empty_args: CliArgs,
205+
overrides: CliOverrides,
206+
resolution: ParameterResolution,
207+
) -> None:
208+
"""Test disable flag maps to session.auto_continue_removal_enabled=False."""
209+
empty_args.disable_auto_continue_removal = True
210+
211+
applicator.apply(empty_args, overrides, resolution)
212+
213+
assert "session" in overrides
214+
assert overrides["session"].get("auto_continue_removal_enabled") is False
215+
cli_records = resolution.latest_by_source(ParameterSource.CLI)
216+
assert "session.auto_continue_removal_enabled" in cli_records
217+
assert (
218+
cli_records["session.auto_continue_removal_enabled"].origin
219+
== "--disable-auto-continue-removal"
220+
)
220221

221222
def test_apply_tool_access_overrides(
222223
self,

0 commit comments

Comments
 (0)