cargo clippy

Author: alexkazik

examples/get_all_href/main.rs

@@ -5,7 +5,7 @@ use html_parser::{Dom, Node, Result};
 fn main() -> Result<()> {
     let html = include_str!("./index.html");
     let dom = Dom::parse(html)?;
-    let iter = dom.children.get(0).unwrap().into_iter();
+    let iter = dom.children.first().unwrap().into_iter();
 
     let hrefs = iter.filter_map(|item| match item {
         Node::Element(element) if element.name == "a" => element.attributes["href"].clone(),

src/dom/mod.rs

@@ -177,14 +177,13 @@ impl Dom {
                 if dom
                     .children
                     .iter()
-                    .filter(|x| match x {
-                        Node::Element(el) if el.name.to_lowercase() == "html" => true,
-                        _ => false,
-                    })
+                    .filter(|x| matches!(x, Node::Element(el) if el.name.to_lowercase() == "html"))
                     .count()
                     > 1
                 {
-                    return Err(Error::Parsing(format!("Document with multiple HTML tags",)));
+                    return Err(Error::Parsing(
+                        "Document with multiple HTML tags".to_string(),
+                    ));
                 }
             }
 
@@ -318,7 +317,7 @@ impl Dom {
                 }
             }
         }
-        if element.name != "" {
+        if !element.name.is_empty() {
             Ok(Some(Node::Element(element)))
         } else {
             Ok(None)
@@ -336,11 +335,7 @@ impl Dom {
                     attribute.1 = Some(pair.as_str().trim().to_string());
                 }
                 Rule::attr_quoted => {
-                    let inner_pair = pair
-                        .into_inner()
-                        .into_iter()
-                        .next()
-                        .expect("attribute value");
+                    let inner_pair = pair.into_inner().next().expect("attribute value");
 
                     match inner_pair.as_rule() {
                         Rule::attr_value => attribute.1 = Some(inner_pair.as_str().to_string()),

src/dom/node.rs

@@ -56,19 +56,19 @@ impl<'a> Iterator for NodeIntoIterator<'a> {
     fn next(&mut self) -> Option<Self::Item> {
         // Get first child
         let child = match self.node {
-            Node::Element(e) => e.children.get(0),
+            Node::Element(e) => e.children.first(),
             _ => None,
         };
 
-        let result = match child {
+        match child {
             // If element has child, return child
             Some(child) => {
                 self.index.push((0, self.node));
                 self.node = child;
                 Some(child)
             }
             // If element doesn't have a child, but is a child of another node
-            None if self.index.len() > 0 => {
+            None if !self.index.is_empty() => {
                 let mut has_finished = false;
                 let mut next_node = None;
 
@@ -101,9 +101,7 @@ impl<'a> Iterator for NodeIntoIterator<'a> {
                 next_node
             }
             _ => None,
-        };
-
-        result
+        }
     }
 }
 

tests/node_iter.rs

@@ -17,8 +17,8 @@ fn it_can_iter_1() -> Result<()> {
             </body>
         </html>
     "};
-    let dom = Dom::parse(&html)?;
-    let root = dom.children.get(0).unwrap().into_iter();
+    let dom = Dom::parse(html)?;
+    let root = dom.children.first().unwrap().into_iter();
     let num_li = root.into_iter().fold(0, |mut acc, curr| match curr {
         Node::Element(e) => {
             if e.name == "li" {

tests/svg.rs

@@ -41,5 +41,5 @@ fn it_can_parse_complex_svg() {
         </svg>
     "#
     );
-    assert!(Dom::parse(&svg).is_ok());
+    assert!(Dom::parse(svg).is_ok());
 }