Merge pull request #90 from matomo-org/improvetests

Improve test stability

Author: snake14

tests/System/TasksTest.php

@@ -87,10 +87,8 @@ public function getApiForTesting()
                     'idSite'     => 1,
                     'date'       => 'today',
                     'periods'    => ['year'],
-                    'testSuffix' => ($api === 'API.get' && version_compare(Version::VERSION, '4.14.2', '<')) ? 'old' : '',
-
                     'otherRequestParameters' => [
-                        'hideColumns' => 'sum_bandwidth,nb_hits_with_bandwidth,min_bandwidth,max_bandwidth,avg_bandwidth,nb_total_overall_bandwidth,nb_total_pageview_bandwidth,nb_total_download_bandwidth',
+                        'hideColumns' => 'sum_visit_length,entry_sum_visit_length,avg_time_on_site_new,sum_bandwidth,nb_hits_with_bandwidth,min_bandwidth,max_bandwidth,avg_bandwidth,nb_total_overall_bandwidth,nb_total_pageview_bandwidth,nb_total_download_bandwidth',
                     ],
 
                     // when calling CustomVariables.getUsagesOfSlots, new archives are created until 'today',

tests/System/expected/test___API.get_year.xml

@@ -4,13 +4,11 @@
 	<nb_actions>39</nb_actions>
 	<max_actions>39</max_actions>
 	<bounce_count>0</bounce_count>
-	<sum_visit_length>1</sum_visit_length>
 	<nb_visits_new>1</nb_visits_new>
 	<nb_actions_new>39</nb_actions_new>
 	<max_actions_new>39</max_actions_new>
 	<bounce_rate_new>0%</bounce_rate_new>
 	<nb_actions_per_visit_new>39</nb_actions_per_visit_new>
-	<avg_time_on_site_new>1</avg_time_on_site_new>
 	<nb_visits_returning>0</nb_visits_returning>
 	<nb_actions_returning>0</nb_actions_returning>
 	<max_actions_returning>0</max_actions_returning>

tests/System/expected/test___Actions.getPageTitles_year.xml

@@ -7,7 +7,6 @@
 		<sum_time_spent>0</sum_time_spent>
 		<entry_nb_visits>1</entry_nb_visits>
 		<entry_nb_actions>39</entry_nb_actions>
-		<entry_sum_visit_length>1</entry_sum_visit_length>
 		<entry_bounce_count>0</entry_bounce_count>
 		<exit_nb_visits>1</exit_nb_visits>
 		<sum_daily_nb_uniq_visitors>1</sum_daily_nb_uniq_visitors>

tests/System/expected/test___Actions.getPageUrls_year.xml

@@ -7,7 +7,6 @@
 		<sum_time_spent>0</sum_time_spent>
 		<entry_nb_visits>1</entry_nb_visits>
 		<entry_nb_actions>39</entry_nb_actions>
-		<entry_sum_visit_length>1</entry_sum_visit_length>
 		<entry_bounce_count>0</entry_bounce_count>
 		<exit_nb_visits>1</exit_nb_visits>
 		<sum_daily_nb_uniq_visitors>1</sum_daily_nb_uniq_visitors>

tests/System/expected/test___CustomVariables.getCustomVariables_year.xml

@@ -5,7 +5,6 @@
 		<nb_visits>1</nb_visits>
 		<nb_actions>39</nb_actions>
 		<max_actions>39</max_actions>
-		<sum_visit_length>1</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
 		<sum_daily_nb_uniq_visitors>1</sum_daily_nb_uniq_visitors>
@@ -23,7 +22,6 @@
 				<nb_visits>1</nb_visits>
 				<nb_actions>39</nb_actions>
 				<max_actions>39</max_actions>
-				<sum_visit_length>1</sum_visit_length>
 				<bounce_count>0</bounce_count>
 				<nb_visits_converted>0</nb_visits_converted>
 				<sum_daily_nb_uniq_visitors>1</sum_daily_nb_uniq_visitors>
@@ -36,7 +34,6 @@
 		<nb_visits>1</nb_visits>
 		<nb_actions>39</nb_actions>
 		<max_actions>39</max_actions>
-		<sum_visit_length>1</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
 		<sum_daily_nb_uniq_visitors>1</sum_daily_nb_uniq_visitors>
@@ -54,7 +51,6 @@
 				<nb_visits>1</nb_visits>
 				<nb_actions>39</nb_actions>
 				<max_actions>39</max_actions>
-				<sum_visit_length>1</sum_visit_length>
 				<bounce_count>0</bounce_count>
 				<nb_visits_converted>0</nb_visits_converted>
 				<sum_daily_nb_uniq_visitors>1</sum_daily_nb_uniq_visitors>
@@ -67,7 +63,6 @@
 		<nb_visits>1</nb_visits>
 		<nb_actions>39</nb_actions>
 		<max_actions>39</max_actions>
-		<sum_visit_length>1</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
 		<sum_daily_nb_uniq_visitors>1</sum_daily_nb_uniq_visitors>
@@ -85,7 +80,6 @@
 				<nb_visits>1</nb_visits>
 				<nb_actions>39</nb_actions>
 				<max_actions>39</max_actions>
-				<sum_visit_length>1</sum_visit_length>
 				<bounce_count>0</bounce_count>
 				<nb_visits_converted>0</nb_visits_converted>
 				<sum_daily_nb_uniq_visitors>1</sum_daily_nb_uniq_visitors>
@@ -98,7 +92,6 @@
 		<nb_visits>1</nb_visits>
 		<nb_actions>39</nb_actions>
 		<max_actions>39</max_actions>
-		<sum_visit_length>1</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
 		<sum_daily_nb_uniq_visitors>1</sum_daily_nb_uniq_visitors>
@@ -116,7 +109,6 @@
 				<nb_visits>1</nb_visits>
 				<nb_actions>39</nb_actions>
 				<max_actions>39</max_actions>
-				<sum_visit_length>1</sum_visit_length>
 				<bounce_count>0</bounce_count>
 				<nb_visits_converted>0</nb_visits_converted>
 				<sum_daily_nb_uniq_visitors>1</sum_daily_nb_uniq_visitors>
@@ -129,7 +121,6 @@
 		<nb_visits>1</nb_visits>
 		<nb_actions>39</nb_actions>
 		<max_actions>39</max_actions>
-		<sum_visit_length>1</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
 		<sum_daily_nb_uniq_visitors>1</sum_daily_nb_uniq_visitors>
@@ -147,7 +138,6 @@
 				<nb_visits>1</nb_visits>
 				<nb_actions>39</nb_actions>
 				<max_actions>39</max_actions>
-				<sum_visit_length>1</sum_visit_length>
 				<bounce_count>0</bounce_count>
 				<nb_visits_converted>0</nb_visits_converted>
 				<sum_daily_nb_uniq_visitors>1</sum_daily_nb_uniq_visitors>

tests/System/expected/test___Referrers.getReferrerType_year.xml

@@ -5,7 +5,6 @@
 		<nb_visits>1</nb_visits>
 		<nb_actions>39</nb_actions>
 		<max_actions>39</max_actions>
-		<sum_visit_length>1</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
 		<sum_daily_nb_uniq_visitors>1</sum_daily_nb_uniq_visitors>