FEAT : Better handling of RTL support

Author: matpag

library/src/main/AndroidManifest.xml

@@ -1 +1 @@
-<manifest package="com.matpag.ui.clickdrawable"/>
+<manifest package="com.matpag.clickdrawabletextview"/>

library/src/main/java/com/matpag/clickdrawabletextview/ClickDrawableAutoCompleteTextView.java

@@ -88,10 +88,6 @@ public void removeAllCsDrawables() {
         mCsDrawableViewManager.removeAllCsDrawables();
     }
 
-    @Override
-    public void enableRTL(boolean enable) {
-        mCsDrawableViewManager.enableRTL(enable);
-    }
 
     @Override
     public void disableFocusOnText(boolean preventReFocus, boolean closeKeyboard) {

library/src/main/java/com/matpag/clickdrawabletextview/ClickDrawableEditText.java

@@ -97,8 +97,4 @@ public void enableFocusOnText(boolean openKeyboard) {
         mCsDrawableViewManager.enableFocusOnText(openKeyboard);
     }
 
-    @Override
-    public void enableRTL(boolean enable) {
-        mCsDrawableViewManager.enableRTL(enable);
-    }
 }

library/src/main/java/com/matpag/clickdrawabletextview/ClickDrawableTextView.java

@@ -97,8 +97,4 @@ public void removeAllCsDrawables() {
         mCsDrawableViewManager.removeAllCsDrawables();
     }
 
-    @Override
-    public void enableRTL(boolean enable) {
-        mCsDrawableViewManager.enableRTL(enable);
-    }
 }

library/src/main/java/com/matpag/clickdrawabletextview/CsDrawableSettings.java

@@ -0,0 +1,58 @@
+package com.matpag.clickdrawabletextview;
+
+import android.content.Context;
+import android.content.pm.ApplicationInfo;
+import android.content.pm.PackageManager;
+
+/**
+ * Global configuration to handle correctly some user specific choices
+ *
+ * Created by Mattia Pagini on 17/05/2017.
+ */
+public class CsDrawableSettings {
+
+    private boolean rtlSupportEnabled;
+
+    private static CsDrawableSettings mSettings;
+
+    private CsDrawableSettings(boolean rtlSupportEnabled){
+        this.rtlSupportEnabled = rtlSupportEnabled;
+    }
+
+    /**
+     * Init method to call before every custom view initialization, this should preferably be
+     * called in the custom {@link android.app.Application} app class. But you can use is in the
+     * activity too before calling {@link android.app.Activity#setContentView(int)} or calling
+     * this per Activity if you need to support RTL in some activities and not in others
+     * @param context the app context
+     * @param packageName the packageName of the app, <code>BuildConfig.APPLICATION_ID</code> should
+     *                    be the proper choice in the most cases
+     */
+    public static void init(Context context, String packageName){
+        PackageManager pManager = context.getApplicationContext().getPackageManager();
+        try {
+            ApplicationInfo appInfo = pManager.getApplicationInfo(packageName, 0);
+            //read the Application android:supportsRtl xml properties (if present), default false
+            boolean rtlSupport = (appInfo.flags & ApplicationInfo.FLAG_SUPPORTS_RTL) != 0;
+            mSettings = new CsDrawableSettings(rtlSupport);
+        } catch (PackageManager.NameNotFoundException nfe){
+            throw new IllegalArgumentException("Unable to get info for the provided packageName, " +
+                    "are you sure is it correct? BuildConfig.APPLICATION_ID should be fine " +
+                    "for the most cases");
+        }
+    }
+
+    /**
+     * Expose the RTL support flag
+     * @return true if the developer added <code>android:supportsRtl="true"</code> to the
+     * application manifest, false otherwise
+     */
+    static boolean isRtlSupportEnabled(){
+        if (mSettings == null){
+            throw new NullPointerException("You need to call CsDrawableSettings.init() in your " +
+                    "custom Application class or Activity before using the library");
+        }
+        return mSettings.rtlSupportEnabled;
+    }
+
+}

library/src/main/java/com/matpag/clickdrawabletextview/CsDrawableViewManager.java

@@ -13,7 +13,6 @@
 import android.view.inputmethod.InputMethodManager;
 import android.widget.TextView;
 
-import com.matpag.ui.clickdrawable.R;
 import com.matpag.clickdrawabletextview.interfaces.ClickableDrawable;
 import com.matpag.clickdrawabletextview.interfaces.OnDrawableClickListener;
 
@@ -44,9 +43,6 @@ final class CsDrawableViewManager implements ClickableDrawable {
     //default true
     private boolean enableTouchOnText = true;
 
-    //default true
-    private boolean enableRTL = true;
-
     private Configuration mConfig;
 
     /**
@@ -152,9 +148,6 @@ void init(Context context, AttributeSet attrs) {
                 mBottomDrawable.setVisibility(visibility);
             }
 
-            enableRTL = a.getBoolean(R.styleable.CsDrawableViewManager_csEnableRTL,
-                    true);
-
             a.recycle();
         }
 
@@ -164,8 +157,8 @@ void init(Context context, AttributeSet attrs) {
     }
 
     /**
-     * Check if the current Locale is in RTL mode and if the user has enabled the view to use it
-     * with {@link #enableRTL(boolean)}
+     * Check if the current Locale is in RTL mode and if the user has enabled the view to support
+     * it in the <code>AndroidManifest.xml</code> of his app
      *
      * NOTE: We should use <code>ViewCompat.getLayoutDirection(view) ==
      * ViewCompat.LAYOUT_DIRECTION_RTL</code> but when you use developer option : Force RTL Layout
@@ -177,7 +170,8 @@ void init(Context context, AttributeSet attrs) {
      * @return true if in RTL, false otherwise
      */
     private boolean isLayoutRTL(){
-        return mConfig.getLayoutDirection() == View.LAYOUT_DIRECTION_RTL && enableRTL;
+        return CsDrawableSettings.isRtlSupportEnabled() &&
+                mConfig.getLayoutDirection() == View.LAYOUT_DIRECTION_RTL;
     }
 
     /**
@@ -206,8 +200,7 @@ private void addCompoundDrawables(){
 
     /**
      * Add the compound drawables to the view, if the Locale of the user is in
-     * RTL mode and {@link #enableRTL} is true the drawable will be added
-     * in the proper position
+     * RTL mode the drawables will be added in the proper position
      */
     private void addCompoundDrawablesRelative(){
         view.setCompoundDrawablesRelative(
@@ -369,12 +362,6 @@ public void showBottomCsDrawable(boolean visible) {
         }
     }
 
-    @Override
-    public void enableRTL(boolean enable) {
-        enableRTL = enable;
-        invalidateDrawables();
-    }
-
     @Override
     public void disableFocusOnText(boolean preventReFocus, boolean closeKeyboard) {
         //block refocus on others edittext

library/src/main/java/com/matpag/clickdrawabletextview/DrawablePosition.java

@@ -1,6 +1,7 @@
 package com.matpag.clickdrawabletextview;
 
 /**
+ * Enum position
  * Created by Mattia Pagini on 13/02/2017.
  */
 

library/src/main/java/com/matpag/clickdrawabletextview/interfaces/ClickableDrawable.java

@@ -25,8 +25,8 @@ public interface ClickableDrawable {
 
     /**
      * Add the start drawable to the view, default the LEFT drawable.
-     * If {@link #enableRTL(boolean)} with <code>true</code> is called, this could be the
-     * LEFT or RIGHT drawable based on the user locale
+     * this could be the LEFT or RIGHT drawable based on the user locale if the developer
+     * has added <code>android:supportsRtl="true"</code> in his <code>AndroidManifest.xml</code>
      * @param csDrawable the CsDrawable object (can be null)
      */
     void addStartCsDrawable(CsDrawable csDrawable);
@@ -39,8 +39,8 @@ public interface ClickableDrawable {
 
     /**
      * Add the end drawable to the view, default the RIGHT drawable.
-     * If {@link #enableRTL(boolean)} with <code>true</code> is called, this could be the
-     * LEFT or RIGHT drawable based on the user locale
+     * this could be the LEFT or RIGHT drawable based on the user locale if the developer
+     * has added <code>android:supportsRtl="true"</code> in his <code>AndroidManifest.xml</code>
      * @param csDrawable the CsDrawable object (can be null)
      */
     void addEndCsDrawable(CsDrawable csDrawable);
@@ -80,24 +80,6 @@ public interface ClickableDrawable {
      */
     void removeAllCsDrawables();
 
-    /**
-     * <p>
-     *     Enable the support for RTL languagues, obviously you should have setted the properties
-     *     <code>android:supportsRtl="true"</code> in the AndroidManifest.xml for the locales suporting
-     *     this convention.
-     * </p>
-     *
-     * <p>
-     *     Enabling this means that your {@link CsDrawable} objects in START and END position could
-     *     be inverted in some Locale
-     * </p>
-     *
-     * @param enable <code>true</code> to enable support to <code>RTL</code> locales,
-     *               <code>false</code> to block everything in <code>LTR</code>.
-     *               default: false
-     */
-    void enableRTL(boolean enable);
-
     /**
      * <p>
      *     Disable focus on the view, simulating a {@link android.view.View#setEnabled(boolean)}