Skip to content

Commit 703e770

Browse files
committed
don’t pass unneeded args to engine
1 parent 5b8d4c4 commit 703e770

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

redminelib/__init__.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,15 +33,14 @@ def __init__(self, url, **kwargs):
3333
:param raise_attr_exception: (optional). Control over resource attribute access exception raising.
3434
:type raise_attr_exception: bool or tuple
3535
:param cls engine: (optional). Engine that will be used to make requests to Redmine.
36-
:param bool return_raw_response (optional). Whether engine should return raw or json encoded responses.
3736
"""
3837
self.url = url.rstrip('/')
39-
self.ver = kwargs.get('version', None)
40-
self.date_format = kwargs.get('date_format', '%Y-%m-%d')
41-
self.datetime_format = kwargs.get('datetime_format', '%Y-%m-%dT%H:%M:%SZ')
42-
self.raise_attr_exception = kwargs.get('raise_attr_exception', True)
38+
self.ver = kwargs.pop('version', None)
39+
self.date_format = kwargs.pop('date_format', '%Y-%m-%d')
40+
self.datetime_format = kwargs.pop('datetime_format', '%Y-%m-%dT%H:%M:%SZ')
41+
self.raise_attr_exception = kwargs.pop('raise_attr_exception', True)
4342

44-
engine = kwargs.get('engine', engines.DefaultEngine)
43+
engine = kwargs.pop('engine', engines.DefaultEngine)
4544

4645
if not inspect.isclass(engine) or not issubclass(engine, engines.BaseEngine):
4746
raise exceptions.EngineClassError

0 commit comments

Comments
 (0)