issue #227

Author: maxtepkeev

CHANGELOG.rst

@@ -22,6 +22,9 @@ Changelog
 
 **Bugfixes**:
 
+- User's ``send_information`` field wasn't sent correctly to Redmine so account information emails were
+  never sent (`Issue #227 <https://github.com/maxtepkeev/python-redmine/pull/227>`__) (thanks to
+  `wodny <https://github.com/wodny>`__)
 - Project resource ``default_version`` attribute was returned as a dict instead of being converted to
   Resource object
 - Resource object was leaking memory during initialization (`Issue #257 <https://github.com/maxtepkeev/python-redmine/

redminelib/managers/__init__.py

@@ -3,4 +3,4 @@
 """
 
 from .base import ResourceManager
-from .standard import WikiPageManager, FileManager, NewsManager
+from .standard import FileManager, WikiPageManager, UserManager, NewsManager

redminelib/managers/standard.py

@@ -6,6 +6,14 @@
 from .. import exceptions
 
 
+class FileManager(ResourceManager):
+    def _process_create_response(self, request, response):
+        if response is True:
+            response = {self.container: {'id': int(request[self.container]['token'].split('.')[0])}}
+
+        return super(FileManager, self)._process_create_response(request, response)
+
+
 class WikiPageManager(ResourceManager):
     def _process_create_response(self, request, response):
         if response is True:
@@ -14,12 +22,16 @@ def _process_create_response(self, request, response):
         return super(WikiPageManager, self)._process_create_response(request, response)
 
 
-class FileManager(ResourceManager):
-    def _process_create_response(self, request, response):
-        if response is True:
-            response = {self.container: {'id': int(request[self.container]['token'].split('.')[0])}}
+class UserManager(ResourceManager):
+    def _prepare_create_request(self, request):
+        request = super(UserManager, self)._prepare_create_request(request)
+        request['send_information'] = request[self.container].pop('send_information', False)
+        return request
 
-        return super(FileManager, self)._process_create_response(request, response)
+    def _prepare_update_request(self, request):
+        request = super(UserManager, self)._prepare_update_request(request)
+        request['send_information'] = request[self.resource_class.container_update].pop('send_information', False)
+        return request
 
 
 class NewsManager(ResourceManager):

redminelib/resources/standard.py

@@ -403,6 +403,7 @@ class User(BaseResource):
     query_create = '/users.json'
     query_update = '/users/{0}.json'
     query_delete = '/users/{0}.json'
+    manager_class = managers.UserManager
 
     _repr = [['id', 'firstname', 'lastname'], ['id', 'name']]
     _includes = ['memberships', 'groups']

tests/test_managers.py

@@ -12,7 +12,7 @@ class FooResource(resources.Project):
 
 class ResourceManagerTestCase(BaseRedmineTestCase):
     def test_has_custom_repr(self):
-        self.assertEqual(repr(self.redmine.user), '<redminelib.managers.ResourceManager object for User resource>')
+        self.assertEqual(repr(self.redmine.issue), '<redminelib.managers.ResourceManager object for Issue resource>')
 
     def test_supports_additional_resources(self):
         self.assertIsInstance(self.redmine.foo_resource, managers.ResourceManager)

tests/test_resources_standard.py

@@ -1041,6 +1041,13 @@ def test_user_create(self):
         self.assertEqual(user.firstname, 'John')
         self.assertEqual(user.lastname, 'Smith')
 
+    def test_user_create_with_send_information(self):
+        import json
+        self.response.status_code = 201
+        self.response.json.return_value = responses['user']['get']
+        self.redmine.user.create(firstname='John', lastname='Smith', send_information=True)
+        self.assertEqual(json.loads(self.patch_requests.call_args[1]['data'])['send_information'], True)
+
     def test_user_delete(self):
         self.response.json.return_value = responses['user']['get']
         user = self.redmine.user.get(1)
@@ -1055,6 +1062,12 @@ def test_user_update(self):
         user.firstname = 'Bar'
         self.assertIsInstance(user.save(), resources.User)
 
+    def test_user_update_with_send_information(self):
+        import json
+        self.response.json.return_value = responses['user']['get']
+        self.redmine.user.update(1, firstname='John', lastname='Smith', send_information=True)
+        self.assertEqual(json.loads(self.patch_requests.call_args[1]['data'])['send_information'], True)
+
     def test_user_custom_str(self):
         self.response.json.return_value = responses['user']['get']
         self.assertEqual(str(self.redmine.user.get(1)), 'John Smith')