Commit 74dd9eb
diana
fix: Address CodeRabbit review feedback on dynamic search rules
- index.py: Fix upsert_dynamic_search_rule path to use top-level route
/dynamic-search-rules/{uid} instead of index-scoped path
- .code-samples.meilisearch.yaml: Fix patch sample to use camelCase keys
(documentIds, matchCondition) and correct conditions array structure
with scope/operator/value fields per v1.41 API spec
- tests: Replace tautological assertion in test_list with meaningful
checks (isinstance dict, results/meta key, results is list)
- tests: Replace try/except with pytest.raises(MeilisearchApiError)
in test_delete verification; add MeilisearchApiError import1 parent 1b56432 commit 74dd9eb
3 files changed
Lines changed: 15 additions & 12 deletions
File tree
- meilisearch
- tests/index
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
631 | 631 | | |
632 | 632 | | |
633 | 633 | | |
634 | | - | |
635 | | - | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
636 | 641 | | |
637 | 642 | | |
638 | 643 | | |
639 | | - | |
640 | | - | |
| 644 | + | |
| 645 | + | |
641 | 646 | | |
642 | 647 | | |
643 | 648 | | |
644 | | - | |
645 | 649 | | |
646 | 650 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1384 | 1384 | | |
1385 | 1385 | | |
1386 | 1386 | | |
1387 | | - | |
| 1387 | + | |
1388 | 1388 | | |
1389 | 1389 | | |
1390 | 1390 | | |
| |||
Lines changed: 5 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
| |||
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
15 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
16 | 19 | | |
17 | 20 | | |
18 | 21 | | |
| |||
91 | 94 | | |
92 | 95 | | |
93 | 96 | | |
94 | | - | |
| 97 | + | |
95 | 98 | | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
0 commit comments