fix: refactored code

Author: jawad-khan

meilisearch/client.py

@@ -137,7 +137,7 @@ def delete_index(self, uid: str, *, metadata: Optional[str] = None) -> TaskInfo:
         """
 
         url = f"{self.config.paths.index}/{uid}"
-        if metadata:
+        if metadata is not None:
             url += f"?{parse.urlencode({'customMetadata': metadata})}"
         task = self.http.delete(url)
 

meilisearch/index.py

@@ -107,7 +107,7 @@ def delete(self, *, metadata: Optional[str] = None) -> TaskInfo:
         """
 
         url = f"{self.config.paths.index}/{self.uid}"
-        if metadata:
+        if metadata is not None:
             url += f"?{parse.urlencode({'customMetadata': metadata})}"
         task = self.http.delete(url)
 
@@ -164,7 +164,7 @@ def update(
             payload["uid"] = new_uid  # This enables renaming
 
         url = f"{self.config.paths.index}/{self.uid}"
-        if metadata:
+        if metadata is not None:
             url += f"?{parse.urlencode({'customMetadata': metadata})}"
         task = self.http.patch(url, payload)
 
@@ -229,7 +229,7 @@ def create(
             options = {}
         payload = {**options, "uid": uid}
         url = config.paths.index
-        if metadata:
+        if metadata is not None:
             url += f"?{parse.urlencode({'customMetadata': metadata})}"
         task = HttpRequests(config, custom_headers).post(url, payload)
 
@@ -694,6 +694,7 @@ def add_documents_ndjson(
         self,
         str_documents: bytes,
         primary_key: Optional[str] = None,
+        *,
         skip_creation: Optional[bool] = None,
         metadata: Optional[str] = None,
     ) -> TaskInfo:
@@ -1089,7 +1090,7 @@ def delete_document(
             An error containing details about why Meilisearch can't process your request. Meilisearch error codes are described here: https://www.meilisearch.com/docs/reference/errors/error_codes#meilisearch-errors
         """
         url = f"{self.config.paths.index}/{self.uid}/{self.config.paths.document}/{document_id}"
-        if metadata:
+        if metadata is not None:
             url += f"?{parse.urlencode({'customMetadata': metadata})}"
         response = self.http.delete(url)
         return TaskInfo(**response)
@@ -1133,15 +1134,15 @@ def delete_documents(
                 DeprecationWarning,
             )
             url = f"{self.config.paths.index}/{self.uid}/{self.config.paths.document}/delete-batch"
-            if metadata:
+            if metadata is not None:
                 url += f"?{parse.urlencode({'customMetadata': metadata})}"
             response = self.http.post(
                 url,
                 [str(i) for i in ids],
             )
         else:
             url = f"{self.config.paths.index}/{self.uid}/{self.config.paths.document}/delete"
-            if metadata:
+            if metadata is not None:
                 url += f"?{parse.urlencode({'customMetadata': metadata})}"
             response = self.http.post(
                 url,
@@ -1169,7 +1170,7 @@ def delete_all_documents(self, *, metadata: Optional[str] = None) -> TaskInfo:
             An error containing details about why Meilisearch can't process your request. Meilisearch error codes are described here: https://www.meilisearch.com/docs/reference/errors/error_codes#meilisearch-errors
         """
         url = f"{self.config.paths.index}/{self.uid}/{self.config.paths.document}"
-        if metadata:
+        if metadata is not None:
             url += f"?{parse.urlencode({'customMetadata': metadata})}"
         response = self.http.delete(url)
         return TaskInfo(**response)
@@ -1269,7 +1270,7 @@ def update_settings(
                     del v["documentTemplateMaxBytes"]
 
         url = f"{self.config.paths.index}/{self.uid}/{self.config.paths.setting}"
-        if metadata:
+        if metadata is not None:
             url += f"?{parse.urlencode({'customMetadata': metadata})}"
         task = self.http.patch(url, body)
 
@@ -1297,7 +1298,7 @@ def reset_settings(self, *, metadata: Optional[str] = None) -> TaskInfo:
             An error containing details about why Meilisearch can't process your request. Meilisearch error codes are described here: https://www.meilisearch.com/docs/reference/errors/error_codes#meilisearch-errors
         """
         url = f"{self.config.paths.index}/{self.uid}/{self.config.paths.setting}"
-        if metadata:
+        if metadata is not None:
             url += f"?{parse.urlencode({'customMetadata': metadata})}"
         task = self.http.delete(url)
 
@@ -2574,7 +2575,7 @@ def _build_url(
             parameters["csvDelimiter"] = csv_delimiter
         if skip_creation is True:
             parameters["skipCreation"] = "true"
-        if metadata:
+        if metadata is not None:
             parameters["customMetadata"] = metadata
         if not parameters:
             return f"{self.config.paths.index}/{self.uid}/{self.config.paths.document}"

meilisearch/task.py

@@ -148,7 +148,7 @@ def cancel_tasks(
         for param in parameters:
             if isinstance(parameters[param], (list, tuple)):
                 parameters[param] = ",".join(parameters[param])
-        if metadata:
+        if metadata is not None:
             parameters["customMetadata"] = metadata
         response = self.http.post(f"{self.config.paths.task}/cancel?{parse.urlencode(parameters)}")
         return TaskInfo(**response)
@@ -178,7 +178,7 @@ def delete_tasks(
         for param in parameters:
             if isinstance(parameters[param], (list, tuple)):
                 parameters[param] = ",".join(parameters[param])
-        if metadata:
+        if metadata is not None:
             parameters["customMetadata"] = metadata
         response = self.http.delete(f"{self.config.paths.task}?{parse.urlencode(parameters)}")
         return TaskInfo(**response)