Add tests for fields presence

Author: Strift

tests/settings/test_settings_embedders.py

@@ -52,23 +52,21 @@ def test_embedder_format_fields(empty_index):
     openai_embedder = {
         "openai": {
             "source": "openAi",
-            "api_key": "test-key",
+            "apiKey": "test-key",
             "model": "text-embedding-3-small",
             "dimensions": 1536,
-            "document_template": "{{title}}",
-            "document_template_max_bytes": 400,
+            "documentTemplateMaxBytes": 400,
             "distribution": {"mean": 0.5, "sigma": 0.1},
-            "binary_quantized": False,
+            "binaryQuantized": False,
         }
     }
     response = index.update_embedders(openai_embedder)
     index.wait_for_task(response.task_uid)
     embedders = index.get_embedders()
     assert embedders.embedders["openai"].source == "openAi"
-    assert embedders.embedders["openai"].api_key == "test-key"
     assert embedders.embedders["openai"].model == "text-embedding-3-small"
     assert embedders.embedders["openai"].dimensions == 1536
-    assert embedders.embedders["openai"].document_template == "{{title}}"
+    assert hasattr(embedders.embedders["openai"], "document_template")
     assert embedders.embedders["openai"].document_template_max_bytes == 400
     assert embedders.embedders["openai"].distribution.mean == 0.5
     assert embedders.embedders["openai"].distribution.sigma == 0.1
@@ -79,22 +77,19 @@ def test_embedder_format_fields(empty_index):
         "huggingface": {
             "source": "huggingFace",
             "model": "BAAI/bge-base-en-v1.5",
-            "dimensions": 768,
             "revision": "main",
-            "document_template": "{{title}}",
-            "document_template_max_bytes": 400,
+            "documentTemplateMaxBytes": 400,
             "distribution": {"mean": 0.5, "sigma": 0.1},
-            "binary_quantized": False,
+            "binaryQuantized": False,
         }
     }
     response = index.update_embedders(huggingface_embedder)
     index.wait_for_task(response.task_uid)
     embedders = index.get_embedders()
     assert embedders.embedders["huggingface"].source == "huggingFace"
     assert embedders.embedders["huggingface"].model == "BAAI/bge-base-en-v1.5"
-    assert embedders.embedders["huggingface"].dimensions == 768
     assert embedders.embedders["huggingface"].revision == "main"
-    assert embedders.embedders["huggingface"].document_template == "{{title}}"
+    assert hasattr(embedders.embedders["huggingface"], "document_template")
     assert embedders.embedders["huggingface"].document_template_max_bytes == 400
     assert embedders.embedders["huggingface"].distribution.mean == 0.5
     assert embedders.embedders["huggingface"].distribution.sigma == 0.1
@@ -105,24 +100,22 @@ def test_embedder_format_fields(empty_index):
         "ollama": {
             "source": "ollama",
             "url": "http://localhost:11434/api/embeddings",
-            "api_key": "test-key",
+            "apiKey": "test-key",
             "model": "llama2",
             "dimensions": 4096,
-            "document_template": "{{title}}",
-            "document_template_max_bytes": 400,
+            "documentTemplateMaxBytes": 400,
             "distribution": {"mean": 0.5, "sigma": 0.1},
-            "binary_quantized": False,
+            "binaryQuantized": False,
         }
     }
     response = index.update_embedders(ollama_embedder)
     index.wait_for_task(response.task_uid)
     embedders = index.get_embedders()
     assert embedders.embedders["ollama"].source == "ollama"
     assert embedders.embedders["ollama"].url == "http://localhost:11434/api/embeddings"
-    assert embedders.embedders["ollama"].api_key == "test-key"
     assert embedders.embedders["ollama"].model == "llama2"
     assert embedders.embedders["ollama"].dimensions == 4096
-    assert embedders.embedders["ollama"].document_template == "{{title}}"
+    assert hasattr(embedders.embedders["ollama"], "document_template")
     assert embedders.embedders["ollama"].document_template_max_bytes == 400
     assert embedders.embedders["ollama"].distribution.mean == 0.5
     assert embedders.embedders["ollama"].distribution.sigma == 0.1
@@ -133,28 +126,26 @@ def test_embedder_format_fields(empty_index):
         "rest": {
             "source": "rest",
             "url": "http://localhost:8000/embed",
-            "api_key": "test-key",
+            "apiKey": "test-key",
             "dimensions": 512,
-            "document_template": "{{title}}",
-            "document_template_max_bytes": 400,
-            "request": {"text": "{{title}}"},
-            "response": {"embedding": "vector"},
+            "documentTemplateMaxBytes": 400,
+            "request": {"model": "MODEL_NAME", "input": "{{text}}"},
+            "response": {"result": {"data": ["{{embedding}}"]}},
             "headers": {"Authorization": "Bearer test-key"},
             "distribution": {"mean": 0.5, "sigma": 0.1},
-            "binary_quantized": False,
+            "binaryQuantized": False,
         }
     }
     response = index.update_embedders(rest_embedder)
     index.wait_for_task(response.task_uid)
     embedders = index.get_embedders()
     assert embedders.embedders["rest"].source == "rest"
     assert embedders.embedders["rest"].url == "http://localhost:8000/embed"
-    assert embedders.embedders["rest"].api_key == "test-key"
     assert embedders.embedders["rest"].dimensions == 512
-    assert embedders.embedders["rest"].document_template == "{{title}}"
+    assert hasattr(embedders.embedders["rest"], "document_template")
     assert embedders.embedders["rest"].document_template_max_bytes == 400
-    assert embedders.embedders["rest"].request == {"text": "{{title}}"}
-    assert embedders.embedders["rest"].response == {"embedding": "vector"}
+    assert embedders.embedders["rest"].request == {"model": "MODEL_NAME", "input": "{{text}}"}
+    assert embedders.embedders["rest"].response == {"result": {"data": ["{{embedding}}"]}}
     assert embedders.embedders["rest"].headers == {"Authorization": "Bearer test-key"}
     assert embedders.embedders["rest"].distribution.mean == 0.5
     assert embedders.embedders["rest"].distribution.sigma == 0.1
@@ -166,7 +157,7 @@ def test_embedder_format_fields(empty_index):
             "source": "userProvided",
             "dimensions": 512,
             "distribution": {"mean": 0.5, "sigma": 0.1},
-            "binary_quantized": False,
+            "binaryQuantized": False,
         }
     }
     response = index.update_embedders(user_provided_embedder)