fix: make docker and diaglog tests cross-platform

- docker: skip chmod permission tests on Windows (os.Chmod unsupported)
- docker/diaglog: use USERPROFILE on Windows, HOME on Unix for home dir
  override in tests (os.UserHomeDir reads USERPROFILE on Windows)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: 2 people

cmd/mxcli/docker/build_test.go

@@ -6,6 +6,7 @@ import (
 	"archive/zip"
 	"os"
 	"path/filepath"
+	"runtime"
 	"strings"
 	"testing"
 
@@ -18,6 +19,9 @@ func newTestZipWriter(f *os.File) *zip.Writer {
 }
 
 func TestPatchStartPermissions_Applied(t *testing.T) {
+	if runtime.GOOS == "windows" {
+		t.Skip("chmod not supported on Windows")
+	}
 	dir := t.TempDir()
 	binDir := filepath.Join(dir, "bin")
 	os.MkdirAll(binDir, 0755)
@@ -35,6 +39,9 @@ func TestPatchStartPermissions_Applied(t *testing.T) {
 }
 
 func TestPatchStartPermissions_Skipped_AlreadyExecutable(t *testing.T) {
+	if runtime.GOOS == "windows" {
+		t.Skip("chmod not supported on Windows")
+	}
 	dir := t.TempDir()
 	binDir := filepath.Join(dir, "bin")
 	os.MkdirAll(binDir, 0755)

cmd/mxcli/docker/download_test.go

@@ -9,6 +9,15 @@ import (
 	"testing"
 )
 
+func setTestHomeDir(t *testing.T, dir string) {
+	t.Helper()
+	if runtime.GOOS == "windows" {
+		t.Setenv("USERPROFILE", dir)
+	} else {
+		t.Setenv("HOME", dir)
+	}
+}
+
 func TestMxBuildCDNURL_ARM64(t *testing.T) {
 	url := MxBuildCDNURL("11.6.3", "arm64")
 	expected := "https://cdn.mendix.com/runtime/arm64-mxbuild-11.6.3.tar.gz"
@@ -48,9 +57,7 @@ func TestCachedMxBuildPath_NotCached(t *testing.T) {
 func TestCachedMxBuildPath_Cached(t *testing.T) {
 	// Create a fake cached mxbuild
 	dir := t.TempDir()
-	origHome := os.Getenv("HOME")
-	t.Setenv("HOME", dir)
-	defer os.Setenv("HOME", origHome)
+	setTestHomeDir(t, dir)
 
 	version := "99.99.99"
 	modelerDir := filepath.Join(dir, ".mxcli", "mxbuild", version, "modeler")
@@ -67,9 +74,7 @@ func TestCachedMxBuildPath_Cached(t *testing.T) {
 
 func TestAnyCachedMxBuildPath_Empty(t *testing.T) {
 	dir := t.TempDir()
-	origHome := os.Getenv("HOME")
-	t.Setenv("HOME", dir)
-	defer os.Setenv("HOME", origHome)
+	setTestHomeDir(t, dir)
 
 	path := AnyCachedMxBuildPath()
 	if path != "" {
@@ -79,9 +84,7 @@ func TestAnyCachedMxBuildPath_Empty(t *testing.T) {
 
 func TestAnyCachedMxBuildPath_Found(t *testing.T) {
 	dir := t.TempDir()
-	origHome := os.Getenv("HOME")
-	t.Setenv("HOME", dir)
-	defer os.Setenv("HOME", origHome)
+	setTestHomeDir(t, dir)
 
 	modelerDir := filepath.Join(dir, ".mxcli", "mxbuild", "11.6.3", "modeler")
 	os.MkdirAll(modelerDir, 0755)
@@ -123,9 +126,7 @@ func TestCachedRuntimePath_NotCached(t *testing.T) {
 
 func TestCachedRuntimePath_Cached(t *testing.T) {
 	dir := t.TempDir()
-	origHome := os.Getenv("HOME")
-	t.Setenv("HOME", dir)
-	defer os.Setenv("HOME", origHome)
+	setTestHomeDir(t, dir)
 
 	version := "99.99.99"
 	launcherDir := filepath.Join(dir, ".mxcli", "runtime", version, "runtime", "launcher")
@@ -141,9 +142,7 @@ func TestCachedRuntimePath_Cached(t *testing.T) {
 
 func TestResolveMxBuild_FindsCachedVersion(t *testing.T) {
 	dir := t.TempDir()
-	origHome := os.Getenv("HOME")
-	t.Setenv("HOME", dir)
-	defer os.Setenv("HOME", origHome)
+	setTestHomeDir(t, dir)
 
 	// Set up a fake cached mxbuild
 	modelerDir := filepath.Join(dir, ".mxcli", "mxbuild", "11.6.3", "modeler")

mdl/diaglog/diaglog_test.go

@@ -5,6 +5,7 @@ package diaglog
 import (
 	"os"
 	"path/filepath"
+	"runtime"
 	"strings"
 	"testing"
 	"time"
@@ -22,12 +23,20 @@ func TestNilLoggerIsSafe(t *testing.T) {
 	l.Close()
 }
 
+func setHomeDir(t *testing.T, dir string) {
+	t.Helper()
+	// Windows uses USERPROFILE, Unix uses HOME. os.UserHomeDir() checks both.
+	if runtime.GOOS == "windows" {
+		t.Setenv("USERPROFILE", dir)
+	} else {
+		t.Setenv("HOME", dir)
+	}
+}
+
 func TestInitAndClose(t *testing.T) {
 	// Use a temp dir for logs
 	tmpDir := t.TempDir()
-	origHome := os.Getenv("HOME")
-	t.Setenv("HOME", tmpDir)
-	defer os.Setenv("HOME", origHome)
+	setHomeDir(t, tmpDir)
 
 	l := Init("test-version", "test")
 	if l == nil {
@@ -53,7 +62,7 @@ func TestInitAndClose(t *testing.T) {
 
 func TestCommandLogging(t *testing.T) {
 	tmpDir := t.TempDir()
-	t.Setenv("HOME", tmpDir)
+	setHomeDir(t, tmpDir)
 
 	l := Init("test", "batch")
 	if l == nil {
@@ -89,7 +98,7 @@ func TestCommandLogging(t *testing.T) {
 
 func TestDisabledViaEnv(t *testing.T) {
 	tmpDir := t.TempDir()
-	t.Setenv("HOME", tmpDir)
+	setHomeDir(t, tmpDir)
 	t.Setenv("MXCLI_LOG", "0")
 
 	l := Init("test", "batch")