Skip to content

src/constants.js do not match protocol documentation #24

@gat3way

Description

@gat3way

Hello,
I am using the mesh-client from Colorado Mesh which has meshcore.js as a dependency. I have issues with channel messages that do not get displayed in the chats while the GRP_TXT packets are actually received by the client. I found out in the logs entries like this:

[log] unhandled frame: code=17 17,225,0,0,3,4,0,169,180,248,105,76,90,49,69,79,77,32,240,159,143,180,226,128,141,226,152,160,239,184,143,58,32,65,102,116,101,114,110,111,111,110,32,105,115,32,50,48

Further debugging the issue, I found out meshcore.js is a dependency to mesh-client and I had a look at the code.

The check for response type is at src/connection/connection.js and response type 17 (0x11) is unrecognized. Furthermore, I looked at src/constants.js and indeed it is not here. We have that one:

ChannelDataRecv: 27,

I believe that was a typo (17 vs 27). In the companion documentation at https://docs.meshcore.io/companion_protocol/#packet-structure it is stated like that:

PACKET_CHANNEL_MSG_RECV_V3 (0x11) - Version 3 with SNR

So either the documentation or the meshcore.js library is wrong. I think you meant to put 17 in the ResponseCodes enum, not 27.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions