Merge pull request #56 from kcroxford-mb/ON-333-python-recording-delete

voice_recording_delete added

Author: marcel corso gonzalez

messagebird/client.py

@@ -162,7 +162,7 @@ def call_create(self, source, destination, callFlow, webhook):
 
         params = locals()
         del (params['self'])
-        return Call().load(self.request('calls', 'POST', params, VOICE_TYPE))
+        return Call().load(self.request('calls/', 'POST', params, VOICE_TYPE))
 
     def call_delete(self, id):
         """Delete an existing call object."""
@@ -449,6 +449,10 @@ def voice_recording_view(self, call_id, leg_id, recording_id):
             recording_response['data'][0]['_links'] = recording_links
         return VoiceRecording().load(recording_response['data'][0])
 
+    def voice_recording_delete(self, call_id, leg_id, recording_id):
+        uri = self.generate_voice_calls_url(call_id=call_id, leg_id=leg_id) + '/' + str(recording_id)
+        recording_response = self.request(uri, 'DELETE', None, VOICE_TYPE)
+
     def voice_recording_download(self, call_id, leg_id, recording_id):
         uri = self.generate_voice_calls_url(call_id=call_id, leg_id=leg_id) + '/' + str(recording_id)
         recording_response = self.request(uri, 'GET')

tests/test_call.py

@@ -149,7 +149,7 @@ def test_call_create(self):
 
         call_creation_response = Client('', http_client).call_create(**params)
 
-        http_client.request.assert_called_once_with('calls', 'POST', params)
+        http_client.request.assert_called_once_with('calls/', 'POST', params)
 
         # check all api response data is outputted
         expected_data = self.create_expected_call_data_based_on_api_response(api_response)

tests/test_voice_recording.py

@@ -66,6 +66,15 @@ def test_voice_recording_list(self):
             self.assertEqual(2, len(item._links))
         self.assertIsInstance(str(voice_recordings), str)
 
+    def test_voice_recording_delete(self):
+        http_client = Mock()
+        http_client.request.return_value = ''
+        call_id = '12348765-4321-0987-6543-210987654321'
+        leg_id = '87654321-0987-6543-2109-876543210987'
+        recording_id = '12345678-9012-3456-7890-123456789012'
+        Client('', http_client).voice_recording_delete(call_id, leg_id, recording_id)
+        http_client.request.assert_called_once_with('https://voice.messagebird.com/calls/%s/legs/%s/recordings/%s' % (call_id, leg_id, recording_id), 'DELETE', None)
+
     def test_voice_recording_download(self):
         http_client = Mock()
         http_client.request.return_value = '{"data":null,"errors":[{"message":"No recording found for ID `00000000-0000-0000-0000-000000000000`.","code":13}],"pagination":{"totalCount":0,"pageCount":0,"currentPage":0,"perPage":0}}'