Skip to content

Commit 0d8d190

Browse files
committed
Name all exception handler parameters for documentation
1 parent cba8c55 commit 0d8d190

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

src/compojure/api/exception.clj

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
1717
Error response only contains class of the Exception so that it won't accidentally
1818
expose secret details."
19-
[^Exception e _ _]
19+
[^Exception e data req]
2020
(logging/log! :error e (.getMessage e))
2121
(internal-server-error {:type "unknown-exception"
2222
:class (.getName (.getClass e))}))
@@ -34,22 +34,22 @@
3434

3535
(defn response-validation-handler
3636
"Creates error response based on Schema error."
37-
[_ data _]
37+
[e data req]
3838
(internal-server-error {:errors (stringify-error (su/error-val data))}))
3939

4040
(defn request-validation-handler
4141
"Creates error response based on Schema error."
42-
[_ data _]
42+
[e data req]
4343
(bad-request {:errors (stringify-error (su/error-val data))}))
4444

4545
(defn schema-error-handler
4646
"Creates error response based on Schema error."
47-
[_ data _]
47+
[e data req]
4848
; FIXME: Why error is not wrapped to ErrorContainer here?
4949
(bad-request {:errors (stringify-error (:error data))}))
5050

5151
(defn request-parsing-handler
52-
[^Exception ex _ _]
52+
[^Exception ex data req]
5353
(let [cause (.getCause ex)]
5454
(bad-request {:type (cond
5555
(instance? JsonParseException cause) "json-parse-exception"

src/compojure/api/middleware.clj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@
3838

3939
(def rethrow-exceptions? ::rethrow-exceptions?)
4040

41-
(defn- call-error-handler [error-handler error error-type request]
41+
(defn- call-error-handler [error-handler error data request]
4242
(try
43-
(error-handler error error-type request)
43+
(error-handler error data request)
4444
(catch clojure.lang.ArityException e
4545
(println "WARNING: Error-handler arity has been changed.")
4646
(error-handler error))))

0 commit comments

Comments
 (0)