Memoize coercers for better performance

Author: ikitommi

src/compojure/api/meta.clj

@@ -7,11 +7,12 @@
             [plumbing.core :refer :all]
             [plumbing.fnk.impl :as fnk-impl]
             [ring.swagger.common :refer :all]
-            [ring.swagger.schema :as schema]
             [ring.swagger.json-schema :as js]
             [ring.util.http-response :refer [internal-server-error]]
             [slingshot.slingshot :refer [throw+]]
             [schema.core :as s]
+            [schema.coerce :as sc]
+            [schema.utils :as su]
             [schema-tools.core :as st]))
 
 ;;
@@ -23,7 +24,7 @@
   '+compojure-api-request+)
 
 (def +compojure-api-meta+
-  "lexically bound meta-data for handlers. EXPERIMENTAL."
+  "lexically bound meta-data for handlers."
   '+compojure-api-meta+)
 
 (defmacro meta-container [meta & form]
@@ -46,6 +47,8 @@
 ;; Schema
 ;;
 
+(def memoized-coercer (memoize sc/coercer))
+
 (defn strict [schema]
   (dissoc schema 'schema.core/Keyword))
 
@@ -59,8 +62,9 @@
     (if-let [{:keys [status] :as response} (handler request)]
       (if-let [schema (:schema (responses status))]
         (if-let [matcher (:response (mw/get-coercion-matcher-provider request))]
-          (let [body (schema/coerce schema (:body response) matcher)]
-            (if (schema/error? body)
+          (let [coerce (memoized-coercer (value-of schema) matcher)
+                body (coerce (:body response))]
+            (if (su/error? body)
               (throw+ (assoc body :type ::ex/response-validation))
               (assoc response
                 ::serializable? true
@@ -75,8 +79,9 @@
   (assert (not (#{:query :json} type)) (str type " is DEPRECATED since 0.22.0. Use :body or :string instead."))
   `(let [value# (keywordize-keys (~key ~+compojure-api-request+))]
      (if-let [matcher# (~type (mw/get-coercion-matcher-provider ~+compojure-api-request+))]
-       (let [result# (schema/coerce ~schema value# matcher#)]
-         (if (schema/error? result#)
+       (let [coerce# (memoized-coercer ~schema matcher#)
+             result# (coerce# value#)]
+         (if (su/error? result#)
            (throw+ (assoc result# :type ::ex/request-validation))
            result#))
        value#)))

test/compojure/api/perf_test.clj

@@ -2,10 +2,14 @@
   (:require [compojure.api.sweet :refer :all]
             [compojure.api.test-utils :refer :all]
             [criterium.core :as cc]
-            [midje.sweet :refer :all]
             [ring.util.http-response :refer :all]
             [schema.core :as s]))
 
+;;
+;; start repl with `lein perf repl`. note, all numbers are from Tommi's
+;; laptop.
+;;
+
 (defn title [s]
   (println
     (str "\n\u001B[35m"
@@ -35,7 +39,7 @@
     (assert (= {:result 30} (second (call))))
     (cc/quick-bench (call)))
 
-  ; 32µs
+  ; 32µs => 30µs (-6%)
 
   (let [app (api
               (POST* "/plus" []
@@ -50,7 +54,7 @@
     (assert (= {:result 30} (second (call))))
     (cc/quick-bench (call)))
 
-  ;; 104µs
+  ;; 104µs => 73µs (-30%)
 
   (let [app (api
               (context* "/a" []
@@ -68,7 +72,7 @@
     (assert (= {:result 30} (second (call))))
     (cc/quick-bench (call)))
 
-  ;; 113µs
+  ;; 113µs => 80µs (-30%)
 
   (let [app (api
               (POST* "/echo" []
@@ -93,9 +97,9 @@
     (s/check Order (second (call)))
     (cc/quick-bench (call)))
 
-  ;; 343µs
+  ;; 343µs => 175µs (-49%)
 
   )
 
-
-(c-api-bench)
+(comment
+  (c-api-bench))