Skip to content

Commit 118065e

Browse files
committed
Fix build
Signed-off-by: Raul Metsma <raul@metsma.ee>
1 parent 959e719 commit 118065e

10 files changed

Lines changed: 17 additions & 24 deletions

File tree

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ jobs:
189189
- name: Build
190190
run: |
191191
cmake "-GNinja" -B build -S . -DCMAKE_BUILD_TYPE=RelWithDebInfo `
192-
-DCMAKE_TOOLCHAIN_FILE=${{ env.VCPKG_ROOT }}/scripts/buildsystems/vcpkg.cmake `
192+
-DCMAKE_TOOLCHAIN_FILE=${{ env.RUNVCPKG_VCPKG_ROOT }}/scripts/buildsystems/vcpkg.cmake `
193193
-DVCPKG_MANIFEST_DIR=${{ github.workspace }}/client/libcdoc
194194
cmake --build build --target msi
195195
cmake --build build --target msishellext

.gitmodules

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@
33
url = ../qt-common
44
[submodule "client/libcdoc"]
55
path = client/libcdoc
6-
url = git@github.com:open-eid/libcdoc.git
6+
url = ../libcdoc

client/CMakeLists.txt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ add_executable(${PROJECT_NAME} WIN32 MACOSX_BUNDLE
4141
main.cpp
4242
Application.cpp
4343
Application.h
44+
CDocSupport.cpp
45+
CDocSupport.h
4446
CheckConnection.cpp
4547
CheckConnection.h
4648
CryptoDoc.cpp
@@ -84,8 +86,6 @@ add_executable(${PROJECT_NAME} WIN32 MACOSX_BUNDLE
8486
TokenData.cpp
8587
TokenData.h
8688
Utils.h
87-
dialogs/PasswordDialog.h dialogs/PasswordDialog.cpp dialogs/PasswordDialog.ui
88-
CDocSupport.cpp CDocSupport.h
8989
)
9090
qt_add_translations(${PROJECT_NAME} TS_FILES
9191
translations/en.ts
@@ -129,7 +129,6 @@ set_target_properties(${PROJECT_NAME} PROPERTIES
129129
MACOSX_BUNDLE_ICON_FILE Icon.icns
130130
MACOSX_BUNDLE_GUI_IDENTIFIER "ee.ria.${PROJECT_NAME}"
131131
)
132-
target_include_directories(${PROJECT_NAME} PRIVATE ${CMAKE_SOURCE_DIR})
133132

134133
target_compile_definitions(${PROJECT_NAME} PRIVATE
135134
CDOC2_GET_URL="${CDOC2_GET_URL}"

client/CheckConnection.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ QNetworkAccessManager* CheckConnection::setupNAM(QNetworkRequest &req, const QBy
8686
qDebug() << "SSL Error:" << error.error() << error.certificate().subjectInfo(QSslCertificate::CommonName);
8787
}
8888
}
89-
reply->ignoreSslErrors(errors);
89+
reply->ignoreSslErrors(ignore);
9090
});
9191
return nam;
9292
}

client/dialogs/AddRecipients.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -160,9 +160,6 @@ void AddRecipients::addRecipient(const QSslCertificate& cert, bool select)
160160
AddressItem *leftItem = itemListValue(ui->leftPane, key);
161161
if(!leftItem)
162162
{
163-
QByteArray qder = cert.toDer();
164-
std::vector<uint8_t> sder = std::vector<uint8_t>(qder.cbegin(), qder.cend());
165-
166163
leftItem = new AddressItem(key, AddressItem::Add, ui->leftPane);
167164
ui->leftPane->addWidget(leftItem);
168165

client/widgets/AddressItem.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,15 @@
1717
*
1818
*/
1919

20-
#include <QDebug>
21-
#include <qsslcertificate.h>
22-
#include <qsslkey.h>
23-
2420
#include "AddressItem.h"
2521
#include "ui_AddressItem.h"
2622

2723
#include "CryptoDoc.h"
2824
#include "SslCertificate.h"
2925
#include "dialogs/KeyDialog.h"
3026

27+
#include <QSslKey>
28+
3129
using namespace ria::qdigidoc4;
3230

3331
class AddressItem::Private: public Ui::AddressItem

client/widgets/AddressItem.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,12 @@
1919

2020
#pragma once
2121

22-
#include <memory>
23-
2422
#include "widgets/Item.h"
25-
#include "cdoc/Lock.h"
2623

2724
struct CDKey;
2825

26+
namespace libcdoc { struct Lock; }
27+
2928
class AddressItem final : public Item
3029
{
3130
Q_OBJECT

client/widgets/AddressItem.ui

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ icon: url(:/images/icon_remove_clicked.svg);
154154
</spacer>
155155
</item>
156156
<item row="0" column="4" rowspan="2">
157-
<widget class="QToolButton" name="remove">
157+
<widget class="QPushButton" name="remove">
158158
<property name="maximumSize">
159159
<size>
160160
<width>24</width>
@@ -168,7 +168,7 @@ icon: url(:/images/icon_remove_clicked.svg);
168168
<string>Remove</string>
169169
</property>
170170
<property name="styleSheet">
171-
<string notr="true">border: none; background: none;</string>
171+
<string notr="true">border: none</string>
172172
</property>
173173
<property name="icon">
174174
<iconset resource="../images/images.qrc">

client/widgets/ContainerPage.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
#include "dialogs/SmartIDDialog.h"
3434
#include "dialogs/WarningDialog.h"
3535
#include "widgets/AddressItem.h"
36+
#include "widgets/MainAction.h"
3637
#include "widgets/SignatureItem.h"
3738
#include "widgets/WarningItem.h"
3839

@@ -534,4 +535,3 @@ void ContainerPage::translateLabels()
534535
ui->cancel->setText(tr(cancelText));
535536
ui->convert->setText(tr(convertText));
536537
}
537-

client/widgets/ContainerPage.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,16 @@
1919

2020
#pragma once
2121

22+
#include <QWidget>
23+
2224
#include "common_enums.h"
23-
#include "widgets/MainAction.h"
24-
#include "CryptoDoc.h"
2525

26-
namespace Ui {
27-
class ContainerPage;
28-
}
26+
namespace libcdoc { struct Lock; }
27+
namespace Ui { class ContainerPage; }
2928

3029
class CryptoDoc;
3130
class DigiDoc;
31+
class MainAction;
3232
class QSslCertificate;
3333
class SignatureItem;
3434
class SslCertificate;

0 commit comments

Comments
 (0)