Skip to content

Commit 724ca82

Browse files
committed
Updates to quality declaration
Signed-off-by: Nordmann Arne (CR/ADT3) <arne.nordmann@de.bosch.com>
1 parent 6251d63 commit 724ca82

1 file changed

Lines changed: 13 additions & 11 deletions

File tree

system_modes/QUALITY_DECLARATION.md

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ This package uses DCO as its confirmation of contributor origin policy. More inf
4949

5050
### Continuous Integration [2.iv]
5151

52-
All pull requests must pass CI on all [tier 1 platforms](https://www.ros.org/reps/rep-2000.html#support-tiers) except tier 1 platform Windows.
53-
**TODO: build status**
52+
All pull requests must pass CI on all [tier 1 platforms](https://www.ros.org/reps/rep-2000.html#support-tiers) (currently not true for tier 1 platform _Windows_).
53+
Latest build results can be seen [here](https://github.com/micro-ROS/system_modes/actions).
5454

5555
### Documentation Policy [2.v]
5656

@@ -78,9 +78,9 @@ There is an automated test which runs a linter that ensures each file has at lea
7878

7979
### Feature Testing [4.i]
8080

81-
Each feature in `system_modes` has corresponding tests which simulate typical usage, and they are located in the [`test`](https://github.com/micro-ROS/system_modes/tree/master/system_modes/test) directory.
81+
Each feature in `system_modes` has corresponding tests which simulate typical usage, located in the [`test`](https://github.com/micro-ROS/system_modes/tree/master/system_modes/test) directory.
8282
New features are required to have tests before being added.
83-
**TODO: test status**
83+
Latest test results can be seen [here](https://github.com/micro-ROS/system_modes/actions).
8484

8585
### Coverage [4.iii]
8686

@@ -94,16 +94,15 @@ This includes:
9494

9595
Changes are required to make a best effort to keep or increase coverage before being accepted, but decreases are allowed if properly justified and accepted by reviewers.
9696

97-
Current coverage statistics can be viewed [here](https://ci.ros2.org/job/nightly_linux_coverage/lastCompletedBuild/cobertura/src_ros2_system_modes_system_modes_src_system_modes/). A description of how coverage statistics are calculated is summarized in this page ["ROS 2 Onboarding Guide"](https://index.ros.org/doc/ros2/Contributing/ROS-2-On-boarding-Guide/#note-on-coverage-runs).**TODO**
97+
Current coverage statistics can be viewed [here](https://codecov.io/gh/micro-ROS/system_modes).
9898

99-
`system_modes` has a line coverage `>= 95%`**TODO**, which is calculated over all directories within `system_modes`.
99+
`system_modes` has a line coverage `>= 20%`, which is calculated over all directories within `system_modes`.
100100

101101
### Linters and Static Analysis [4.v]
102102

103103
`system_modes` uses and passes all the ROS2 standard linters and static analysis tools for a C++ package as described in the [ROS 2 Developer Guide](https://index.ros.org/doc/ros2/Contributing/Developer-Guide/#linters-and-static-analysis). Passing implies there are no linter/static errors when testing against CI of supported platforms.
104104

105-
Currently nightly test results can be seen here:
106-
**TODO**
105+
Latest linting results can be seen [here](https://github.com/micro-ROS/system_modes/actions).
107106

108107
## Dependencies [5]
109108

@@ -119,16 +118,19 @@ It also has several test dependencies, which do not affect the resulting quality
119118

120119
#### `rclcpp_lifecycle`
121120

122-
The `rclcpp_lifecycle` package provides the ROS 2 standard lifecycle in c**. It is **Quality Level 1**, see its [Quality Declaration document](https://github.com/ros2/rclcpp/blob/master/rclcpp/QUALITY_DECLARATION.md). The same is true for its transient dependencies, see its [Quality Declaration document](https://github.com/ros2/rclcpp/blob/master/rclcpp/QUALITY_DECLARATION.md).
121+
The `rclcpp` package provides theROS client library in C++. It is **Quality Level 1**, see its [Quality Declaration document](https://github.com/ros2/rclcpp/blob/master/rclcpp/QUALITY_DECLARATION.md). The same is true for its transient dependencies, see its [Quality Declaration document](https://github.com/ros2/rclcpp/blob/master/rclcpp/QUALITY_DECLARATION.md).
122+
123+
#### `rclcpp_lifecycle`
124+
125+
The `rclcpp_lifecycle` package provides the ROS 2 standard lifecycle in C++. It is **Quality Level 1**, see its [Quality Declaration document](https://github.com/ros2/rclcpp/blob/master/rclcpp_lifecycle/QUALITY_DECLARATION.md). The same is true for its transient dependencies, see its [Quality Declaration document](https://github.com/ros2/rclcpp/blob/master/rclcpp_lifecycle/QUALITY_DECLARATION.md).
123126

124127
### Direct Runtime non-ROS Dependency [5.iii]
125128

126129
`system_modes` has no run-time or build-time dependencies that need to be considered for this declaration.
127130

128131
## Platform Support [6]
129132

130-
`system_modes` supports all of the tier 1 platforms as described in [REP-2000](https://www.ros.org/reps/rep-2000.html#support-tiers), and tests each change against all of them.
131-
**TODO: windows**
133+
`system_modes` supports all of the tier 1 platforms as described in [REP-2000](https://www.ros.org/reps/rep-2000.html#support-tiers) (currently not true for tier 1 platform _Windows_), and tests each change against all of them.
132134

133135
## Security
134136

0 commit comments

Comments
 (0)