You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: system_modes/QUALITY_DECLARATION.md
+13-11Lines changed: 13 additions & 11 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -49,8 +49,8 @@ This package uses DCO as its confirmation of contributor origin policy. More inf
49
49
50
50
### Continuous Integration [2.iv]
51
51
52
-
All pull requests must pass CI on all [tier 1 platforms](https://www.ros.org/reps/rep-2000.html#support-tiers)except tier 1 platform Windows.
53
-
**TODO: build status**
52
+
All pull requests must pass CI on all [tier 1 platforms](https://www.ros.org/reps/rep-2000.html#support-tiers)(currently not true for tier 1 platform _Windows_).
53
+
Latest build results can be seen [here](https://github.com/micro-ROS/system_modes/actions).
54
54
55
55
### Documentation Policy [2.v]
56
56
@@ -78,9 +78,9 @@ There is an automated test which runs a linter that ensures each file has at lea
78
78
79
79
### Feature Testing [4.i]
80
80
81
-
Each feature in `system_modes` has corresponding tests which simulate typical usage, and they are located in the [`test`](https://github.com/micro-ROS/system_modes/tree/master/system_modes/test) directory.
81
+
Each feature in `system_modes` has corresponding tests which simulate typical usage, located in the [`test`](https://github.com/micro-ROS/system_modes/tree/master/system_modes/test) directory.
82
82
New features are required to have tests before being added.
83
-
**TODO: test status**
83
+
Latest test results can be seen [here](https://github.com/micro-ROS/system_modes/actions).
84
84
85
85
### Coverage [4.iii]
86
86
@@ -94,16 +94,15 @@ This includes:
94
94
95
95
Changes are required to make a best effort to keep or increase coverage before being accepted, but decreases are allowed if properly justified and accepted by reviewers.
96
96
97
-
Current coverage statistics can be viewed [here](https://ci.ros2.org/job/nightly_linux_coverage/lastCompletedBuild/cobertura/src_ros2_system_modes_system_modes_src_system_modes/). A description of how coverage statistics are calculated is summarized in this page ["ROS 2 Onboarding Guide"](https://index.ros.org/doc/ros2/Contributing/ROS-2-On-boarding-Guide/#note-on-coverage-runs).**TODO**
97
+
Current coverage statistics can be viewed [here](https://codecov.io/gh/micro-ROS/system_modes).
98
98
99
-
`system_modes` has a line coverage `>= 95%`**TODO**, which is calculated over all directories within `system_modes`.
99
+
`system_modes` has a line coverage `>= 20%`, which is calculated over all directories within `system_modes`.
100
100
101
101
### Linters and Static Analysis [4.v]
102
102
103
103
`system_modes` uses and passes all the ROS2 standard linters and static analysis tools for a C++ package as described in the [ROS 2 Developer Guide](https://index.ros.org/doc/ros2/Contributing/Developer-Guide/#linters-and-static-analysis). Passing implies there are no linter/static errors when testing against CI of supported platforms.
104
104
105
-
Currently nightly test results can be seen here:
106
-
**TODO**
105
+
Latest linting results can be seen [here](https://github.com/micro-ROS/system_modes/actions).
107
106
108
107
## Dependencies [5]
109
108
@@ -119,16 +118,19 @@ It also has several test dependencies, which do not affect the resulting quality
119
118
120
119
#### `rclcpp_lifecycle`
121
120
122
-
The `rclcpp_lifecycle` package provides the ROS 2 standard lifecycle in c**. It is **Quality Level 1**, see its [Quality Declaration document](https://github.com/ros2/rclcpp/blob/master/rclcpp/QUALITY_DECLARATION.md). The same is true for its transient dependencies, see its [Quality Declaration document](https://github.com/ros2/rclcpp/blob/master/rclcpp/QUALITY_DECLARATION.md).
121
+
The `rclcpp` package provides theROS client library in C++. It is **Quality Level 1**, see its [Quality Declaration document](https://github.com/ros2/rclcpp/blob/master/rclcpp/QUALITY_DECLARATION.md). The same is true for its transient dependencies, see its [Quality Declaration document](https://github.com/ros2/rclcpp/blob/master/rclcpp/QUALITY_DECLARATION.md).
122
+
123
+
#### `rclcpp_lifecycle`
124
+
125
+
The `rclcpp_lifecycle` package provides the ROS 2 standard lifecycle in C++. It is **Quality Level 1**, see its [Quality Declaration document](https://github.com/ros2/rclcpp/blob/master/rclcpp_lifecycle/QUALITY_DECLARATION.md). The same is true for its transient dependencies, see its [Quality Declaration document](https://github.com/ros2/rclcpp/blob/master/rclcpp_lifecycle/QUALITY_DECLARATION.md).
123
126
124
127
### Direct Runtime non-ROS Dependency [5.iii]
125
128
126
129
`system_modes` has no run-time or build-time dependencies that need to be considered for this declaration.
127
130
128
131
## Platform Support [6]
129
132
130
-
`system_modes` supports all of the tier 1 platforms as described in [REP-2000](https://www.ros.org/reps/rep-2000.html#support-tiers), and tests each change against all of them.
131
-
**TODO: windows**
133
+
`system_modes` supports all of the tier 1 platforms as described in [REP-2000](https://www.ros.org/reps/rep-2000.html#support-tiers) (currently not true for tier 1 platform _Windows_), and tests each change against all of them.
0 commit comments