[ES] Codeunit 7000000 CarteraManagement - Refactor the Functions InsertReceivableDocs and InsertPayableDocs

[cesarbs77]

Why do you need this change?

We need to use the standar functions for InsertReceivableDocs or InsertPayableDocs in batch mode without open a form for select the "Cartera Docs." to insert

Describe the request

We nee taht the code will be Refactor using new functions creating a new function with the code after the Run of the page, for use externally, like this:

Old Code
if CarteraDocuments.RunModal() <> ACTION::LookupOK then
exit;
CarteraDocuments.GetSelected(CarteraDoc);
Clear(CarteraDocuments);
if not CarteraDoc.Find('-') then
exit;

New Code

if CarteraDocuments.RunModal() <> ACTION::LookupOK then
exit;

CarteraDocuments.GetSelected(CarteraDoc);
Clear(CarteraDocuments);

InsertSelectedCarteraDocs(GroupNo, BillGr, CarteraDoc)
end;

procedure InsertSelectedCarteraDocs(GroupNo: Code[20]; var BillGr: Record "Bill Group"; var CarteraDoc: Record "Cartera Doc.")
var
BankAcc: Record "Bank Account";
CarteraSetup: Record "Cartera Setup";
CustLedgEntry: Record "Cust. Ledger Entry";
CheckDiscCreditLimit: Page "Check Discount Credit Limit";
SelectedAmount: Decimal;
begin
if not CarteraDoc.Find('-') then
exit;

Internal work item: AB#635592

[github-actions]

Hi @cesarbs77,

Thank you for your extensibility request. To help us process it efficiently, please update the issue to include the required information.

📚 Extensibility Guidelines

Missing Information:

• Performance considerations: Add a brief note about expected execution frequency and any anticipated performance impact.
• Data sensitivity review: Add a short statement confirming whether this change would expose any sensitive data.
• Multi-extension interaction: Add a short note acknowledging possible conflicts or behavior if multiple extensions subscribe to the event.

Please update the issue with the missing details. We'll automatically re-analyze once updated.

Note

Automatically generated by the Triage Agent — advisory only. An engineer will review before any action is taken.

Tip

Not accurate? Reply with /not-accurate (optional: add a short explanation). Your feedback improves future responses.

[cesarbs77]

Performance considerations: This modification is for a procedure to create automatic Bill Group with a very large number of bills. The user should not have to wait for the process to complete.

Data confidentiality review: This procedure will not expose sensitive data, as it would involve transferring the current code to a new function to allow the use of part of the code without needing to run a page.

Interaction with multiple extensions: Creating the function would avoid conflicts with events, as it would be a new function, while maintaining the existing code.

[AleksandricMarko]

✅ Analysis complete - approved for implementation

---

Implementation:

Refactor the non-UI processing into externally accessible procedures so batch callers can reuse the selected-document application logic without opening the Cartera Documents page. Use the existing payable helper as the external entry point, and extract the equivalent receivable logic into a new public helper.

Current code:

procedure InsertReceivableDocs(var CarteraDoc2: Record "Cartera Doc.")
begin
    // ...
    if CarteraDocuments.RunModal() <> Action::LookupOK then
        exit;
    CarteraDocuments.GetSelected(CarteraDoc);
    Clear(CarteraDocuments);
    if not CarteraDoc.Find('-') then
        exit;

    // inline processing of selected receivable documents
end;

internal procedure ApplySelectedPayableDocsToPaymentOrder(var CarteraDoc: Record "Cartera Doc."; var PmtOrd: Record "Payment Order"; GroupNo: Code[20])
begin
    // processing of selected payable documents
end;

Proposed change:

procedure InsertReceivableDocs(var CarteraDoc2: Record "Cartera Doc.")
begin
    // ...
    if CarteraDocuments.RunModal() <> Action::LookupOK then
        exit;
    CarteraDocuments.GetSelected(CarteraDoc);
    Clear(CarteraDocuments);

    InsertSelectedReceivableDocs(GroupNo, BillGr, CarteraDoc);
end;

procedure InsertSelectedReceivableDocs(GroupNo: Code[20]; var BillGr: Record "Bill Group"; var CarteraDoc: Record "Cartera Doc.")
begin
    // extracted processing of selected receivable documents
end;

procedure ApplySelectedPayableDocsToPaymentOrder(var CarteraDoc: Record "Cartera Doc."; var PmtOrd: Record "Payment Order"; GroupNo: Code[20])
begin
    // existing selected payable document processing, now externally accessible
end;

---

File: CarteraManagement.Codeunit.al