From b7fc20861ec07a4930de0863d2c3d587c2fe715d Mon Sep 17 00:00:00 2001 From: Jesper Schulz-Wedde Date: Tue, 28 Apr 2026 12:15:27 +0200 Subject: [PATCH 1/5] [28.x][SFTP] Deprecate SFTP connector due to platform hardening; add obsolescence details to relevant files --- .../App/Entitlements/ExtSFTPConnector.Entitlement.al | 5 +++-- .../App/permissions/ExtSFTPEdit.PermissionSet.al | 3 +++ .../App/permissions/ExtSFTPObjects.PermissionSet.al | 3 +++ .../App/permissions/ExtSFTPRead.PermissionSet.al | 3 +++ .../FileStorageAdminExtSFTP.PermissionSetExt.al | 2 ++ .../FileStorageEditExtSFTP.PermissionSetExt.al | 2 ++ .../App/src/ExtSFTPAccount.Page.al | 5 ++++- .../App/src/ExtSFTPAccount.Table.al | 5 ++++- .../App/src/ExtSFTPAccountWizard.Page.al | 5 ++++- .../App/src/ExtSFTPAuthType.Enum.al | 3 +++ .../App/src/ExtSFTPConnector.EnumExt.al | 5 ++++- .../App/src/ExtSFTPConnectorImpl.Codeunit.al | 5 ++++- .../Permissions/SystemApplicationAdmin.PermissionSet.al | 2 ++ .../App/SFTP Client/src/DotnetSFTPClient.Codeunit.al | 7 ++++++- .../App/SFTP Client/src/DotnetSFTPFile.Codeunit.al | 7 ++++++- .../App/SFTP Client/src/ISFTPClient.Interface.al | 8 +++++++- .../App/SFTP Client/src/ISFTPFile.Interface.al | 6 +++++- .../src/PermissionSets/SFTPAdmin.PermissionSet.al | 5 ++++- .../App/SFTP Client/src/SFTPClient.Codeunit.al | 5 ++++- .../SFTP Client/src/SFTPClientImplementation.Codeunit.al | 5 ++++- .../App/SFTP Client/src/SFTPExceptionType.Enum.al | 5 ++++- .../App/SFTP Client/src/SFTPFolderContent.Page.al | 5 ++++- .../App/SFTP Client/src/SFTPFolderContent.Table.al | 5 ++++- .../App/SFTP Client/src/SFTPOperationResponse.Codeunit.al | 5 ++++- 24 files changed, 93 insertions(+), 18 deletions(-) diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/Entitlements/ExtSFTPConnector.Entitlement.al b/src/Apps/W1/External File Storage - SFTP Connector/App/Entitlements/ExtSFTPConnector.Entitlement.al index 0c213b4471..5774d841b1 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/Entitlements/ExtSFTPConnector.Entitlement.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/Entitlements/ExtSFTPConnector.Entitlement.al @@ -5,9 +5,10 @@ namespace System.ExternalFileStorage; +#pragma warning disable AL0432 entitlement "Ext. SFTP Connector" { - ObjectEntitlements = "Ext. SFTP - Edit"; Type = Implicit; -} \ No newline at end of file +} +#pragma warning restore AL0432 diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPEdit.PermissionSet.al b/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPEdit.PermissionSet.al index b9b754a5dd..0973ebe9bb 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPEdit.PermissionSet.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPEdit.PermissionSet.al @@ -10,6 +10,9 @@ permissionset 4621 "Ext. SFTP - Edit" Access = Public; Assignable = false; Caption = 'SFTP - Edit'; + ObsoleteReason = 'The SFTP connector is deprecated because platform hardening will prevent support for SFTP connections.'; + ObsoleteState = Pending; + ObsoleteTag = '29.0'; IncludedPermissionSets = "Ext. SFTP - Read"; Permissions = diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPObjects.PermissionSet.al b/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPObjects.PermissionSet.al index e9c9046ff3..7b0047de3d 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPObjects.PermissionSet.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPObjects.PermissionSet.al @@ -10,6 +10,9 @@ permissionset 4622 "Ext. SFTP - Objects" Access = Public; Assignable = false; Caption = 'SFTP - Objects'; + ObsoleteReason = 'The SFTP connector is deprecated because platform hardening will prevent support for SFTP connections.'; + ObsoleteState = Pending; + ObsoleteTag = '29.0'; Permissions = table "Ext. SFTP Account" = X, page "Ext. SFTP Account Wizard" = X, diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPRead.PermissionSet.al b/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPRead.PermissionSet.al index 86482d2513..271f80c8c2 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPRead.PermissionSet.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPRead.PermissionSet.al @@ -10,6 +10,9 @@ permissionset 4623 "Ext. SFTP - Read" Access = Public; Assignable = false; Caption = 'SFTP - Read'; + ObsoleteReason = 'The SFTP connector is deprecated because platform hardening will prevent support for SFTP connections.'; + ObsoleteState = Pending; + ObsoleteTag = '29.0'; IncludedPermissionSets = "Ext. SFTP - Objects"; Permissions = diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/FileStorageAdminExtSFTP.PermissionSetExt.al b/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/FileStorageAdminExtSFTP.PermissionSetExt.al index ea2008d1cf..6ce6617294 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/FileStorageAdminExtSFTP.PermissionSetExt.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/FileStorageAdminExtSFTP.PermissionSetExt.al @@ -5,7 +5,9 @@ namespace System.ExternalFileStorage; +#pragma warning disable AL0432 permissionsetextension 4621 "File Storage - Admin - Ext. SFTP" extends "File Storage - Admin" { IncludedPermissionSets = "Ext. SFTP - Edit"; } +#pragma warning restore AL0432 diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/FileStorageEditExtSFTP.PermissionSetExt.al b/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/FileStorageEditExtSFTP.PermissionSetExt.al index d0be734af5..c5dbea6a0a 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/FileStorageEditExtSFTP.PermissionSetExt.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/FileStorageEditExtSFTP.PermissionSetExt.al @@ -5,7 +5,9 @@ namespace System.ExternalFileStorage; +#pragma warning disable AL0432 permissionsetextension 4622 "File Storage - Edit - Ext. SFTP" extends "File Storage - Edit" { IncludedPermissionSets = "Ext. SFTP - Read"; } +#pragma warning restore AL0432 diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccount.Page.al b/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccount.Page.al index 494c526fa5..bd6a3af8f5 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccount.Page.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccount.Page.al @@ -19,6 +19,9 @@ page 4621 "Ext. SFTP Account" Permissions = tabledata "Ext. SFTP Account" = rimd; SourceTable = "Ext. SFTP Account"; UsageCategory = None; + ObsoleteReason = 'The SFTP connector is deprecated because platform hardening will prevent support for SFTP connections.'; + ObsoleteState = Pending; + ObsoleteTag = '29.0'; layout { @@ -158,4 +161,4 @@ page 4621 "Ext. SFTP Account" else CertificateStatusText := CertificateUploadedLbl; end; -} \ No newline at end of file +} diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccount.Table.al b/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccount.Table.al index 49744be512..30d8e0296b 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccount.Table.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccount.Table.al @@ -15,6 +15,9 @@ table 4621 "Ext. SFTP Account" { Caption = 'SFTP Account'; DataClassification = CustomerContent; + ObsoleteReason = 'The SFTP connector is deprecated because platform hardening will prevent support for SFTP connections.'; + ObsoleteState = Pending; + ObsoleteTag = '29.0'; fields { @@ -236,4 +239,4 @@ table 4621 "Ext. SFTP Account" CertificateBase64 := Base64Convert.ToBase64(InStr); exit(CertificateBase64); end; -} \ No newline at end of file +} diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccountWizard.Page.al b/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccountWizard.Page.al index 74696cdb3e..ba5437a8d5 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccountWizard.Page.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccountWizard.Page.al @@ -20,6 +20,9 @@ page 4622 "Ext. SFTP Account Wizard" Permissions = tabledata "Ext. SFTP Account" = rimd; SourceTable = "Ext. SFTP Account"; SourceTableTemporary = true; + ObsoleteReason = 'The SFTP connector is deprecated because platform hardening will prevent support for SFTP connections.'; + ObsoleteState = Pending; + ObsoleteTag = '29.0'; layout { @@ -240,4 +243,4 @@ page 4622 "Ext. SFTP Account Wizard" else CertificateStatusText := CertificateUploadedLbl; end; -} \ No newline at end of file +} diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAuthType.Enum.al b/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAuthType.Enum.al index 0c2aff7247..e6e0c56386 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAuthType.Enum.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAuthType.Enum.al @@ -12,6 +12,9 @@ enum 4621 "Ext. SFTP Auth Type" { Extensible = false; Access = Public; + ObsoleteReason = 'The SFTP connector is deprecated because platform hardening will prevent support for SFTP connections.'; + ObsoleteState = Pending; + ObsoleteTag = '29.0'; /// /// Authenticate using password. diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPConnector.EnumExt.al b/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPConnector.EnumExt.al index 3a2a7fa8a7..a40ccea899 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPConnector.EnumExt.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPConnector.EnumExt.al @@ -17,5 +17,8 @@ enumextension 4621 "Ext. SFTP Connector" extends "Ext. File Storage Connector" { Caption = 'SFTP'; Implementation = "External File Storage Connector" = "Ext. SFTP Connector Impl"; + ObsoleteReason = 'The SFTP connector is deprecated because platform hardening will prevent support for SFTP connections.'; + ObsoleteState = Pending; + ObsoleteTag = '29.0'; } -} \ No newline at end of file +} diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPConnectorImpl.Codeunit.al b/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPConnectorImpl.Codeunit.al index 473feb955b..e4d9751ba9 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPConnectorImpl.Codeunit.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPConnectorImpl.Codeunit.al @@ -15,6 +15,9 @@ codeunit 4621 "Ext. SFTP Connector Impl" implements "External File Storage Conne Access = Internal; InherentEntitlements = X; InherentPermissions = X; + ObsoleteReason = 'The SFTP connector is deprecated because platform hardening will prevent support for SFTP connections.'; + ObsoleteState = Pending; + ObsoleteTag = '29.0'; Permissions = tabledata "Ext. SFTP Account" = rimd; var @@ -494,4 +497,4 @@ codeunit 4621 "Ext. SFTP Connector Impl" implements "External File Storage Conne Account.ModifyAll(Disabled, true); end; -} \ No newline at end of file +} diff --git a/src/System Application/App/Permissions/SystemApplicationAdmin.PermissionSet.al b/src/System Application/App/Permissions/SystemApplicationAdmin.PermissionSet.al index 32e8a6c7dc..5e4e688e4c 100644 --- a/src/System Application/App/Permissions/SystemApplicationAdmin.PermissionSet.al +++ b/src/System Application/App/Permissions/SystemApplicationAdmin.PermissionSet.al @@ -16,6 +16,7 @@ using System.MCP; using System.Privacy; using System.SFTPClient; +#pragma warning disable AL0432 permissionset 154 "System Application - Admin" { Access = Internal; @@ -42,3 +43,4 @@ permissionset 154 "System Application - Admin" "TROUBLESHOOT TOOLS", "VSC Intgr. - Admin"; } +#pragma warning restore AL0432 diff --git a/src/System Application/App/SFTP Client/src/DotnetSFTPClient.Codeunit.al b/src/System Application/App/SFTP Client/src/DotnetSFTPClient.Codeunit.al index 254ceb516f..214b1b773f 100644 --- a/src/System Application/App/SFTP Client/src/DotnetSFTPClient.Codeunit.al +++ b/src/System Application/App/SFTP Client/src/DotnetSFTPClient.Codeunit.al @@ -7,11 +7,15 @@ namespace System.SFTPClient; using System; +#pragma warning disable AL0432 codeunit 9760 "Dotnet SFTP Client" implements "ISFTP Client" { Access = Internal; InherentEntitlements = X; InherentPermissions = X; + ObsoleteReason = 'The SFTP module is deprecated because platform hardening will prevent support for SFTP connections.'; + ObsoleteState = Pending; + ObsoleteTag = '29.0'; var [WithEvents] @@ -259,4 +263,5 @@ codeunit 9760 "Dotnet SFTP Client" implements "ISFTP Client" begin FingerprintsMD5 := Fingerprints; end; -} \ No newline at end of file +} +#pragma warning restore AL0432 diff --git a/src/System Application/App/SFTP Client/src/DotnetSFTPFile.Codeunit.al b/src/System Application/App/SFTP Client/src/DotnetSFTPFile.Codeunit.al index 083f076754..7bb3ea4729 100644 --- a/src/System Application/App/SFTP Client/src/DotnetSFTPFile.Codeunit.al +++ b/src/System Application/App/SFTP Client/src/DotnetSFTPFile.Codeunit.al @@ -7,11 +7,15 @@ namespace System.SFTPClient; using System; +#pragma warning disable AL0432 codeunit 9761 "Dotnet SFTP File" implements "ISFTP File" { Access = Internal; InherentEntitlements = X; InherentPermissions = X; + ObsoleteReason = 'The SFTP module is deprecated because platform hardening will prevent support for SFTP connections.'; + ObsoleteState = Pending; + ObsoleteTag = '29.0'; var RenciSFTPFile: DotNet RenciISftpFile; @@ -58,4 +62,5 @@ codeunit 9761 "Dotnet SFTP File" implements "ISFTP File" begin RenciSFTPFile := NewFile; end; -} \ No newline at end of file +} +#pragma warning restore AL0432 diff --git a/src/System Application/App/SFTP Client/src/ISFTPClient.Interface.al b/src/System Application/App/SFTP Client/src/ISFTPClient.Interface.al index 8de4e7f3fc..f202658baa 100644 --- a/src/System Application/App/SFTP Client/src/ISFTPClient.Interface.al +++ b/src/System Application/App/SFTP Client/src/ISFTPClient.Interface.al @@ -7,9 +7,14 @@ namespace System.SFTPClient; using System; +#pragma warning disable AL0432 interface "ISFTP Client" { Access = Internal; + ObsoleteReason = 'The SFTP module is deprecated because platform hardening will prevent support for SFTP connections.'; + ObsoleteState = Pending; + ObsoleteTag = '29.0'; + procedure SftpClient(Host: Text; Port: Integer; UserName: Text; Password: SecretText): Boolean procedure SftpClient(Host: Text; Port: Integer; UserName: Text; PrivateKey: InStream): Boolean procedure SftpClient(HostName: Text; Port: Integer; Username: Text; PrivateKey: InStream; Passphrase: SecretText): Boolean @@ -27,4 +32,5 @@ interface "ISFTP Client" procedure CreateDirectory(Path: Text): Boolean procedure SetSHA256Fingerprints(FingerPrints: List of [Text]) procedure SetMD5Fingerprints(FingerPrints: List of [Text]) -} \ No newline at end of file +} +#pragma warning restore AL0432 diff --git a/src/System Application/App/SFTP Client/src/ISFTPFile.Interface.al b/src/System Application/App/SFTP Client/src/ISFTPFile.Interface.al index 85e1c6076a..944423fc40 100644 --- a/src/System Application/App/SFTP Client/src/ISFTPFile.Interface.al +++ b/src/System Application/App/SFTP Client/src/ISFTPFile.Interface.al @@ -8,10 +8,14 @@ namespace System.SFTPClient; interface "ISFTP File" { Access = Public; + ObsoleteReason = 'The SFTP module is deprecated because platform hardening will prevent support for SFTP connections.'; + ObsoleteState = Pending; + ObsoleteTag = '29.0'; + procedure MoveTo(Destination: Text): Boolean procedure Name(): Text procedure FullName(): Text procedure IsDirectory(): Boolean procedure Length(): BigInteger procedure LastWriteTime(): DateTime -} \ No newline at end of file +} diff --git a/src/System Application/App/SFTP Client/src/PermissionSets/SFTPAdmin.PermissionSet.al b/src/System Application/App/SFTP Client/src/PermissionSets/SFTPAdmin.PermissionSet.al index 71fb582164..46bd0fb43c 100644 --- a/src/System Application/App/SFTP Client/src/PermissionSets/SFTPAdmin.PermissionSet.al +++ b/src/System Application/App/SFTP Client/src/PermissionSets/SFTPAdmin.PermissionSet.al @@ -9,7 +9,10 @@ permissionset 9762 "SFTP - Admin" Access = Public; Assignable = true; Caption = 'SFTP - Admin'; + ObsoleteReason = 'The SFTP module is deprecated because platform hardening will prevent support for SFTP connections.'; + ObsoleteState = Pending; + ObsoleteTag = '29.0'; Permissions = page "SFTP Folder Content" = X; -} \ No newline at end of file +} diff --git a/src/System Application/App/SFTP Client/src/SFTPClient.Codeunit.al b/src/System Application/App/SFTP Client/src/SFTPClient.Codeunit.al index 463f372737..607767b12c 100644 --- a/src/System Application/App/SFTP Client/src/SFTPClient.Codeunit.al +++ b/src/System Application/App/SFTP Client/src/SFTPClient.Codeunit.al @@ -10,6 +10,9 @@ codeunit 9762 "SFTP Client" Access = Public; InherentEntitlements = X; InherentPermissions = X; + ObsoleteReason = 'The SFTP module is deprecated because platform hardening will prevent support for SFTP connections.'; + ObsoleteState = Pending; + ObsoleteTag = '29.0'; /// /// Adds a SHA256 fingerprint to the list of accepted host key fingerprints. @@ -202,4 +205,4 @@ codeunit 9762 "SFTP Client" var SFTPClientImplementation: Codeunit "SFTP Client Implementation"; -} \ No newline at end of file +} diff --git a/src/System Application/App/SFTP Client/src/SFTPClientImplementation.Codeunit.al b/src/System Application/App/SFTP Client/src/SFTPClientImplementation.Codeunit.al index 38f77fa493..add71ba3dc 100644 --- a/src/System Application/App/SFTP Client/src/SFTPClientImplementation.Codeunit.al +++ b/src/System Application/App/SFTP Client/src/SFTPClientImplementation.Codeunit.al @@ -13,6 +13,9 @@ codeunit 9763 "SFTP Client Implementation" Access = Internal; InherentEntitlements = X; InherentPermissions = X; + ObsoleteReason = 'The SFTP module is deprecated because platform hardening will prevent support for SFTP connections.'; + ObsoleteState = Pending; + ObsoleteTag = '29.0'; procedure Initialize(Host: Text; Port: Integer; UserName: Text; Password: SecretText): Codeunit "SFTP Operation Response" begin @@ -209,4 +212,4 @@ codeunit 9763 "SFTP Client Implementation" HostkeyFingerprintsSHA256: List of [Text]; HostkeyFingerprintsMD5: List of [Text]; ISFTPClientSet: Boolean; -} \ No newline at end of file +} diff --git a/src/System Application/App/SFTP Client/src/SFTPExceptionType.Enum.al b/src/System Application/App/SFTP Client/src/SFTPExceptionType.Enum.al index 1ffc3b63e1..a8b55b8a5b 100644 --- a/src/System Application/App/SFTP Client/src/SFTPExceptionType.Enum.al +++ b/src/System Application/App/SFTP Client/src/SFTPExceptionType.Enum.al @@ -9,6 +9,9 @@ enum 9760 "SFTP Exception Type" { Extensible = false; Access = Public; + ObsoleteReason = 'The SFTP module is deprecated because platform hardening will prevent support for SFTP connections.'; + ObsoleteState = Pending; + ObsoleteTag = '29.0'; value(0; None) { @@ -42,4 +45,4 @@ enum 9760 "SFTP Exception Type" { Caption = 'Untrusted Server Exception'; } -} \ No newline at end of file +} diff --git a/src/System Application/App/SFTP Client/src/SFTPFolderContent.Page.al b/src/System Application/App/SFTP Client/src/SFTPFolderContent.Page.al index d18cbde862..27ba07ed2a 100644 --- a/src/System Application/App/SFTP Client/src/SFTPFolderContent.Page.al +++ b/src/System Application/App/SFTP Client/src/SFTPFolderContent.Page.al @@ -16,6 +16,9 @@ page 9761 "SFTP Folder Content" DeleteAllowed = false; Editable = false; Extensible = false; + ObsoleteReason = 'The SFTP module is deprecated because platform hardening will prevent support for SFTP connections.'; + ObsoleteState = Pending; + ObsoleteTag = '29.0'; layout { @@ -52,4 +55,4 @@ page 9761 "SFTP Folder Content" } } } -} \ No newline at end of file +} diff --git a/src/System Application/App/SFTP Client/src/SFTPFolderContent.Table.al b/src/System Application/App/SFTP Client/src/SFTPFolderContent.Table.al index ecb670e559..b5fc4fb806 100644 --- a/src/System Application/App/SFTP Client/src/SFTPFolderContent.Table.al +++ b/src/System Application/App/SFTP Client/src/SFTPFolderContent.Table.al @@ -14,6 +14,9 @@ table 9760 "SFTP Folder Content" Extensible = false; Caption = 'SFTP Folder Content'; TableType = Temporary; + ObsoleteReason = 'The SFTP module is deprecated because platform hardening will prevent support for SFTP connections.'; + ObsoleteState = Pending; + ObsoleteTag = '29.0'; fields { @@ -58,4 +61,4 @@ table 9760 "SFTP Folder Content" Clustered = true; } } -} \ No newline at end of file +} diff --git a/src/System Application/App/SFTP Client/src/SFTPOperationResponse.Codeunit.al b/src/System Application/App/SFTP Client/src/SFTPOperationResponse.Codeunit.al index d84e840839..55a47b9714 100644 --- a/src/System Application/App/SFTP Client/src/SFTPOperationResponse.Codeunit.al +++ b/src/System Application/App/SFTP Client/src/SFTPOperationResponse.Codeunit.al @@ -12,6 +12,9 @@ codeunit 9764 "SFTP Operation Response" Access = Public; InherentEntitlements = X; InherentPermissions = X; + ObsoleteReason = 'The SFTP module is deprecated because platform hardening will prevent support for SFTP connections.'; + ObsoleteState = Pending; + ObsoleteTag = '29.0'; internal procedure GetResponseStream(var ResultInstream: InStream) begin @@ -69,4 +72,4 @@ codeunit 9764 "SFTP Operation Response" IsErrorVar: Boolean; ErrorType: Enum "SFTP Exception Type"; ErrorMsg: Text; -} \ No newline at end of file +} From faed0c19137b8c1a7fb8036af78ba39c3e93dcf6 Mon Sep 17 00:00:00 2001 From: Jesper Schulz-Wedde Date: Tue, 28 Apr 2026 13:51:42 +0200 Subject: [PATCH 2/5] [28.x][SFTP] Update warnings for SFTP connector files to include AS0105; ensure compliance with platform standards --- .../App/Entitlements/ExtSFTPConnector.Entitlement.al | 4 ++-- .../App/permissions/ExtSFTPEdit.PermissionSet.al | 2 ++ .../App/permissions/ExtSFTPObjects.PermissionSet.al | 2 ++ .../App/permissions/ExtSFTPRead.PermissionSet.al | 2 ++ .../permissions/FileStorageAdminExtSFTP.PermissionSetExt.al | 4 ++-- .../permissions/FileStorageEditExtSFTP.PermissionSetExt.al | 4 ++-- .../App/src/ExtSFTPAccount.Page.al | 2 ++ .../App/src/ExtSFTPAccount.Table.al | 2 ++ .../App/src/ExtSFTPAccountWizard.Page.al | 2 ++ .../App/src/ExtSFTPConnector.EnumExt.al | 2 ++ .../App/src/ExtSFTPConnectorImpl.Codeunit.al | 2 ++ .../App/Permissions/SystemApplicationAdmin.PermissionSet.al | 4 ++-- .../App/SFTP Client/src/DotnetSFTPClient.Codeunit.al | 4 ++-- .../App/SFTP Client/src/DotnetSFTPFile.Codeunit.al | 4 ++-- .../App/SFTP Client/src/ISFTPClient.Interface.al | 4 ++-- .../SFTP Client/src/PermissionSets/SFTPAdmin.PermissionSet.al | 2 ++ .../App/SFTP Client/src/SFTPClient.Codeunit.al | 2 ++ .../App/SFTP Client/src/SFTPClientImplementation.Codeunit.al | 2 ++ .../App/SFTP Client/src/SFTPFolderContent.Page.al | 2 ++ .../App/SFTP Client/src/SFTPOperationResponse.Codeunit.al | 2 ++ 20 files changed, 40 insertions(+), 14 deletions(-) diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/Entitlements/ExtSFTPConnector.Entitlement.al b/src/Apps/W1/External File Storage - SFTP Connector/App/Entitlements/ExtSFTPConnector.Entitlement.al index 5774d841b1..318c3a9aa4 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/Entitlements/ExtSFTPConnector.Entitlement.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/Entitlements/ExtSFTPConnector.Entitlement.al @@ -5,10 +5,10 @@ namespace System.ExternalFileStorage; -#pragma warning disable AL0432 +#pragma warning disable AL0432, AS0105 entitlement "Ext. SFTP Connector" { ObjectEntitlements = "Ext. SFTP - Edit"; Type = Implicit; } -#pragma warning restore AL0432 +#pragma warning restore AL0432, AS0105 diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPEdit.PermissionSet.al b/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPEdit.PermissionSet.al index 0973ebe9bb..e1f9a5420a 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPEdit.PermissionSet.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPEdit.PermissionSet.al @@ -5,6 +5,7 @@ namespace System.ExternalFileStorage; +#pragma warning disable AL0432, AS0105 permissionset 4621 "Ext. SFTP - Edit" { Access = Public; @@ -18,3 +19,4 @@ permissionset 4621 "Ext. SFTP - Edit" Permissions = tabledata "Ext. SFTP Account" = imd; } +#pragma warning restore AL0432, AS0105 diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPObjects.PermissionSet.al b/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPObjects.PermissionSet.al index 7b0047de3d..9792e6bca1 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPObjects.PermissionSet.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPObjects.PermissionSet.al @@ -5,6 +5,7 @@ namespace System.ExternalFileStorage; +#pragma warning disable AL0432, AS0105 permissionset 4622 "Ext. SFTP - Objects" { Access = Public; @@ -18,3 +19,4 @@ permissionset 4622 "Ext. SFTP - Objects" page "Ext. SFTP Account Wizard" = X, page "Ext. SFTP Account" = X; } +#pragma warning restore AL0432, AS0105 diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPRead.PermissionSet.al b/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPRead.PermissionSet.al index 271f80c8c2..2ccd5a2f87 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPRead.PermissionSet.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/ExtSFTPRead.PermissionSet.al @@ -5,6 +5,7 @@ namespace System.ExternalFileStorage; +#pragma warning disable AL0432, AS0105 permissionset 4623 "Ext. SFTP - Read" { Access = Public; @@ -18,3 +19,4 @@ permissionset 4623 "Ext. SFTP - Read" Permissions = tabledata "Ext. SFTP Account" = r; } +#pragma warning restore AL0432, AS0105 diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/FileStorageAdminExtSFTP.PermissionSetExt.al b/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/FileStorageAdminExtSFTP.PermissionSetExt.al index 6ce6617294..d6efea7084 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/FileStorageAdminExtSFTP.PermissionSetExt.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/FileStorageAdminExtSFTP.PermissionSetExt.al @@ -5,9 +5,9 @@ namespace System.ExternalFileStorage; -#pragma warning disable AL0432 +#pragma warning disable AL0432, AS0105 permissionsetextension 4621 "File Storage - Admin - Ext. SFTP" extends "File Storage - Admin" { IncludedPermissionSets = "Ext. SFTP - Edit"; } -#pragma warning restore AL0432 +#pragma warning restore AL0432, AS0105 diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/FileStorageEditExtSFTP.PermissionSetExt.al b/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/FileStorageEditExtSFTP.PermissionSetExt.al index c5dbea6a0a..e28e1ac7c2 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/FileStorageEditExtSFTP.PermissionSetExt.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/permissions/FileStorageEditExtSFTP.PermissionSetExt.al @@ -5,9 +5,9 @@ namespace System.ExternalFileStorage; -#pragma warning disable AL0432 +#pragma warning disable AL0432, AS0105 permissionsetextension 4622 "File Storage - Edit - Ext. SFTP" extends "File Storage - Edit" { IncludedPermissionSets = "Ext. SFTP - Read"; } -#pragma warning restore AL0432 +#pragma warning restore AL0432, AS0105 diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccount.Page.al b/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccount.Page.al index bd6a3af8f5..9711148424 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccount.Page.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccount.Page.al @@ -8,6 +8,7 @@ namespace System.ExternalFileStorage; /// /// Displays an account that was registered via the SFTP connector. /// +#pragma warning disable AL0432, AS0105 page 4621 "Ext. SFTP Account" { ApplicationArea = All; @@ -162,3 +163,4 @@ page 4621 "Ext. SFTP Account" CertificateStatusText := CertificateUploadedLbl; end; } +#pragma warning restore AL0432, AS0105 diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccount.Table.al b/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccount.Table.al index 30d8e0296b..50e8be0e85 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccount.Table.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccount.Table.al @@ -11,6 +11,7 @@ using System.Utilities; /// /// Holds the information for all file accounts that are registered via the SFTP connector /// +#pragma warning disable AL0432, AS0105 table 4621 "Ext. SFTP Account" { Caption = 'SFTP Account'; @@ -240,3 +241,4 @@ table 4621 "Ext. SFTP Account" exit(CertificateBase64); end; } +#pragma warning restore AL0432, AS0105 diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccountWizard.Page.al b/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccountWizard.Page.al index ba5437a8d5..0b6ba4781d 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccountWizard.Page.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPAccountWizard.Page.al @@ -10,6 +10,7 @@ using System.Environment; /// /// Displays an account that is being registered via the SFTP connector. /// +#pragma warning disable AL0432, AS0105 page 4622 "Ext. SFTP Account Wizard" { ApplicationArea = All; @@ -244,3 +245,4 @@ page 4622 "Ext. SFTP Account Wizard" CertificateStatusText := CertificateUploadedLbl; end; } +#pragma warning restore AL0432, AS0105 diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPConnector.EnumExt.al b/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPConnector.EnumExt.al index a40ccea899..ea56e61594 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPConnector.EnumExt.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPConnector.EnumExt.al @@ -8,6 +8,7 @@ namespace System.ExternalFileStorage; /// /// Enum extension to register the SFTP connector. /// +#pragma warning disable AL0432, AS0105 enumextension 4621 "Ext. SFTP Connector" extends "Ext. File Storage Connector" { /// @@ -22,3 +23,4 @@ enumextension 4621 "Ext. SFTP Connector" extends "Ext. File Storage Connector" ObsoleteTag = '29.0'; } } +#pragma warning restore AL0432, AS0105 diff --git a/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPConnectorImpl.Codeunit.al b/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPConnectorImpl.Codeunit.al index e4d9751ba9..c64d080b24 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPConnectorImpl.Codeunit.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/App/src/ExtSFTPConnectorImpl.Codeunit.al @@ -10,6 +10,7 @@ using System.SFTPClient; using System.Text; using System.Utilities; +#pragma warning disable AL0432, AS0105 codeunit 4621 "Ext. SFTP Connector Impl" implements "External File Storage Connector" { Access = Internal; @@ -498,3 +499,4 @@ codeunit 4621 "Ext. SFTP Connector Impl" implements "External File Storage Conne Account.ModifyAll(Disabled, true); end; } +#pragma warning restore AL0432, AS0105 diff --git a/src/System Application/App/Permissions/SystemApplicationAdmin.PermissionSet.al b/src/System Application/App/Permissions/SystemApplicationAdmin.PermissionSet.al index 5e4e688e4c..63cbd6d335 100644 --- a/src/System Application/App/Permissions/SystemApplicationAdmin.PermissionSet.al +++ b/src/System Application/App/Permissions/SystemApplicationAdmin.PermissionSet.al @@ -16,7 +16,7 @@ using System.MCP; using System.Privacy; using System.SFTPClient; -#pragma warning disable AL0432 +#pragma warning disable AL0432, AS0105 permissionset 154 "System Application - Admin" { Access = Internal; @@ -43,4 +43,4 @@ permissionset 154 "System Application - Admin" "TROUBLESHOOT TOOLS", "VSC Intgr. - Admin"; } -#pragma warning restore AL0432 +#pragma warning restore AL0432, AS0105 diff --git a/src/System Application/App/SFTP Client/src/DotnetSFTPClient.Codeunit.al b/src/System Application/App/SFTP Client/src/DotnetSFTPClient.Codeunit.al index 214b1b773f..380b90a272 100644 --- a/src/System Application/App/SFTP Client/src/DotnetSFTPClient.Codeunit.al +++ b/src/System Application/App/SFTP Client/src/DotnetSFTPClient.Codeunit.al @@ -7,7 +7,7 @@ namespace System.SFTPClient; using System; -#pragma warning disable AL0432 +#pragma warning disable AL0432, AS0105 codeunit 9760 "Dotnet SFTP Client" implements "ISFTP Client" { Access = Internal; @@ -264,4 +264,4 @@ codeunit 9760 "Dotnet SFTP Client" implements "ISFTP Client" FingerprintsMD5 := Fingerprints; end; } -#pragma warning restore AL0432 +#pragma warning restore AL0432, AS0105 diff --git a/src/System Application/App/SFTP Client/src/DotnetSFTPFile.Codeunit.al b/src/System Application/App/SFTP Client/src/DotnetSFTPFile.Codeunit.al index 7bb3ea4729..ba39ad03bd 100644 --- a/src/System Application/App/SFTP Client/src/DotnetSFTPFile.Codeunit.al +++ b/src/System Application/App/SFTP Client/src/DotnetSFTPFile.Codeunit.al @@ -7,7 +7,7 @@ namespace System.SFTPClient; using System; -#pragma warning disable AL0432 +#pragma warning disable AL0432, AS0105 codeunit 9761 "Dotnet SFTP File" implements "ISFTP File" { Access = Internal; @@ -63,4 +63,4 @@ codeunit 9761 "Dotnet SFTP File" implements "ISFTP File" RenciSFTPFile := NewFile; end; } -#pragma warning restore AL0432 +#pragma warning restore AL0432, AS0105 diff --git a/src/System Application/App/SFTP Client/src/ISFTPClient.Interface.al b/src/System Application/App/SFTP Client/src/ISFTPClient.Interface.al index f202658baa..7a349623d0 100644 --- a/src/System Application/App/SFTP Client/src/ISFTPClient.Interface.al +++ b/src/System Application/App/SFTP Client/src/ISFTPClient.Interface.al @@ -7,7 +7,7 @@ namespace System.SFTPClient; using System; -#pragma warning disable AL0432 +#pragma warning disable AL0432, AS0105 interface "ISFTP Client" { Access = Internal; @@ -33,4 +33,4 @@ interface "ISFTP Client" procedure SetSHA256Fingerprints(FingerPrints: List of [Text]) procedure SetMD5Fingerprints(FingerPrints: List of [Text]) } -#pragma warning restore AL0432 +#pragma warning restore AL0432, AS0105 diff --git a/src/System Application/App/SFTP Client/src/PermissionSets/SFTPAdmin.PermissionSet.al b/src/System Application/App/SFTP Client/src/PermissionSets/SFTPAdmin.PermissionSet.al index 46bd0fb43c..9347bc6857 100644 --- a/src/System Application/App/SFTP Client/src/PermissionSets/SFTPAdmin.PermissionSet.al +++ b/src/System Application/App/SFTP Client/src/PermissionSets/SFTPAdmin.PermissionSet.al @@ -4,6 +4,7 @@ // ------------------------------------------------------------------------------------------------ namespace System.SFTPClient; +#pragma warning disable AL0432, AS0105 permissionset 9762 "SFTP - Admin" { Access = Public; @@ -16,3 +17,4 @@ permissionset 9762 "SFTP - Admin" Permissions = page "SFTP Folder Content" = X; } +#pragma warning restore AL0432, AS0105 diff --git a/src/System Application/App/SFTP Client/src/SFTPClient.Codeunit.al b/src/System Application/App/SFTP Client/src/SFTPClient.Codeunit.al index 607767b12c..b887095a22 100644 --- a/src/System Application/App/SFTP Client/src/SFTPClient.Codeunit.al +++ b/src/System Application/App/SFTP Client/src/SFTPClient.Codeunit.al @@ -5,6 +5,7 @@ namespace System.SFTPClient; +#pragma warning disable AL0432, AS0105 codeunit 9762 "SFTP Client" { Access = Public; @@ -206,3 +207,4 @@ codeunit 9762 "SFTP Client" var SFTPClientImplementation: Codeunit "SFTP Client Implementation"; } +#pragma warning restore AL0432, AS0105 diff --git a/src/System Application/App/SFTP Client/src/SFTPClientImplementation.Codeunit.al b/src/System Application/App/SFTP Client/src/SFTPClientImplementation.Codeunit.al index add71ba3dc..c960277f19 100644 --- a/src/System Application/App/SFTP Client/src/SFTPClientImplementation.Codeunit.al +++ b/src/System Application/App/SFTP Client/src/SFTPClientImplementation.Codeunit.al @@ -8,6 +8,7 @@ namespace System.SFTPClient; using System; using System.Utilities; +#pragma warning disable AL0432, AS0105 codeunit 9763 "SFTP Client Implementation" { Access = Internal; @@ -213,3 +214,4 @@ codeunit 9763 "SFTP Client Implementation" HostkeyFingerprintsMD5: List of [Text]; ISFTPClientSet: Boolean; } +#pragma warning restore AL0432, AS0105 diff --git a/src/System Application/App/SFTP Client/src/SFTPFolderContent.Page.al b/src/System Application/App/SFTP Client/src/SFTPFolderContent.Page.al index 27ba07ed2a..b77cbd8dbf 100644 --- a/src/System Application/App/SFTP Client/src/SFTPFolderContent.Page.al +++ b/src/System Application/App/SFTP Client/src/SFTPFolderContent.Page.al @@ -5,6 +5,7 @@ namespace System.SFTPClient; +#pragma warning disable AL0432, AS0105 page 9761 "SFTP Folder Content" { Caption = 'SFTP Folder Content'; @@ -56,3 +57,4 @@ page 9761 "SFTP Folder Content" } } } +#pragma warning restore AL0432, AS0105 diff --git a/src/System Application/App/SFTP Client/src/SFTPOperationResponse.Codeunit.al b/src/System Application/App/SFTP Client/src/SFTPOperationResponse.Codeunit.al index 55a47b9714..ff5939dcc9 100644 --- a/src/System Application/App/SFTP Client/src/SFTPOperationResponse.Codeunit.al +++ b/src/System Application/App/SFTP Client/src/SFTPOperationResponse.Codeunit.al @@ -7,6 +7,7 @@ namespace System.SFTPClient; using System.Utilities; +#pragma warning disable AL0432, AS0105 codeunit 9764 "SFTP Operation Response" { Access = Public; @@ -73,3 +74,4 @@ codeunit 9764 "SFTP Operation Response" ErrorType: Enum "SFTP Exception Type"; ErrorMsg: Text; } +#pragma warning restore AL0432, AS0105 From ac0450c6aa0b2e05e66ddfe7da414803fee825f5 Mon Sep 17 00:00:00 2001 From: Jesper Schulz-Wedde Date: Tue, 28 Apr 2026 13:54:13 +0200 Subject: [PATCH 3/5] [28.x][SFTP] Bump System Application version Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- src/System Application/App/app.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/System Application/App/app.json b/src/System Application/App/app.json index 8f6f258e03..f56f8b7833 100644 --- a/src/System Application/App/app.json +++ b/src/System Application/App/app.json @@ -4,7 +4,7 @@ "publisher": "Microsoft", "brief": "Provides a standard set of capabilities that serve as a foundation for developing business apps.", "description": "Contains an expansive set of open source modules that make it easier to build, maintain, and easily upgrade on-premises and online apps. These modules let you focus on the business logic, and the needs of your users or customers.", - "version": "28.1.0.0", + "version": "28.1.0.1", "privacyStatement": "https://go.microsoft.com/fwlink/?linkid=724009", "EULA": "https://go.microsoft.com/fwlink/?linkid=2009120", "help": "https://go.microsoft.com/fwlink/?linkid=2103698", @@ -65,4 +65,4 @@ "Resources/Files" ], "contextSensitiveHelpUrl": "https://learn.microsoft.com/dynamics365/business-central/" -} \ No newline at end of file +} From 385aae82be8cfc085c7cb3376c87736131dce9be Mon Sep 17 00:00:00 2001 From: Jesper Schulz-Wedde Date: Tue, 28 Apr 2026 16:39:09 +0200 Subject: [PATCH 4/5] [28.x][SFTP] Restore System Application version Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- src/System Application/App/app.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/System Application/App/app.json b/src/System Application/App/app.json index f56f8b7833..1500da0caf 100644 --- a/src/System Application/App/app.json +++ b/src/System Application/App/app.json @@ -4,7 +4,7 @@ "publisher": "Microsoft", "brief": "Provides a standard set of capabilities that serve as a foundation for developing business apps.", "description": "Contains an expansive set of open source modules that make it easier to build, maintain, and easily upgrade on-premises and online apps. These modules let you focus on the business logic, and the needs of your users or customers.", - "version": "28.1.0.1", + "version": "28.1.0.0", "privacyStatement": "https://go.microsoft.com/fwlink/?linkid=724009", "EULA": "https://go.microsoft.com/fwlink/?linkid=2009120", "help": "https://go.microsoft.com/fwlink/?linkid=2103698", From 74927f6aceff1db8d635128336fe6de449f1dfa8 Mon Sep 17 00:00:00 2001 From: Jesper Schulz-Wedde Date: Wed, 29 Apr 2026 09:31:37 +0200 Subject: [PATCH 5/5] [28.x][SFTP] Suppress obsolete warnings in SFTP tests The SFTP test apps intentionally reference the newly deprecated SFTP module and connector objects, so suppress AL0432 and AS0105 in the affected test code. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../Test/src/ExtSFTPConnectorTest.Codeunit.al | 4 +++- .../Test/SFTP Client/src/MockSFTPClient.Codeunit.al | 4 +++- .../Test/SFTP Client/src/MockSFTPFile.Codeunit.al | 4 +++- .../Test/SFTP Client/src/SFTPClientTest.Codeunit.al | 4 +++- 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/src/Apps/W1/External File Storage - SFTP Connector/Test/src/ExtSFTPConnectorTest.Codeunit.al b/src/Apps/W1/External File Storage - SFTP Connector/Test/src/ExtSFTPConnectorTest.Codeunit.al index 7241327e0f..76eb0665be 100644 --- a/src/Apps/W1/External File Storage - SFTP Connector/Test/src/ExtSFTPConnectorTest.Codeunit.al +++ b/src/Apps/W1/External File Storage - SFTP Connector/Test/src/ExtSFTPConnectorTest.Codeunit.al @@ -9,6 +9,7 @@ using System.Environment; using System.ExternalFileStorage; using System.TestLibraries.Utilities; +#pragma warning disable AL0432, AS0105 codeunit 144591 "Ext. SFTP Connector Test" { Subtype = Test; @@ -159,4 +160,5 @@ codeunit 144591 "Ext. SFTP Connector Test" Any: Codeunit Any; Assert: Codeunit "Library Assert"; FileAccountMock: Codeunit "Ext. SFTP Account Mock"; -} \ No newline at end of file +} +#pragma warning restore AL0432, AS0105 diff --git a/src/System Application/Test/SFTP Client/src/MockSFTPClient.Codeunit.al b/src/System Application/Test/SFTP Client/src/MockSFTPClient.Codeunit.al index 407f93dbfd..4cd0779c4d 100644 --- a/src/System Application/Test/SFTP Client/src/MockSFTPClient.Codeunit.al +++ b/src/System Application/Test/SFTP Client/src/MockSFTPClient.Codeunit.al @@ -8,6 +8,7 @@ namespace System.Test.SFTPClient; using System; using System.SFTPClient; +#pragma warning disable AL0432, AS0105 codeunit 139075 "Mock SFTP Client" implements "ISFTP Client" { Access = Internal; @@ -292,4 +293,5 @@ codeunit 139075 "Mock SFTP Client" implements "ISFTP Client" FilesExist.Add(Path, true); exit(true); end; -} \ No newline at end of file +} +#pragma warning restore AL0432, AS0105 diff --git a/src/System Application/Test/SFTP Client/src/MockSFTPFile.Codeunit.al b/src/System Application/Test/SFTP Client/src/MockSFTPFile.Codeunit.al index 892e0e8771..d2e36e33ac 100644 --- a/src/System Application/Test/SFTP Client/src/MockSFTPFile.Codeunit.al +++ b/src/System Application/Test/SFTP Client/src/MockSFTPFile.Codeunit.al @@ -7,6 +7,7 @@ namespace System.Test.SFTPClient; using System.SFTPClient; +#pragma warning disable AL0432, AS0105 codeunit 139076 "Mock SFTP File" implements "ISFTP File" { Access = Internal; @@ -60,4 +61,5 @@ codeunit 139076 "Mock SFTP File" implements "ISFTP File" begin exit(LastWriteTimeVar); end; -} \ No newline at end of file +} +#pragma warning restore AL0432, AS0105 diff --git a/src/System Application/Test/SFTP Client/src/SFTPClientTest.Codeunit.al b/src/System Application/Test/SFTP Client/src/SFTPClientTest.Codeunit.al index cda2602439..5cb0079646 100644 --- a/src/System Application/Test/SFTP Client/src/SFTPClientTest.Codeunit.al +++ b/src/System Application/Test/SFTP Client/src/SFTPClientTest.Codeunit.al @@ -9,6 +9,7 @@ using System.SFTPClient; using System.TestLibraries.Utilities; using System.Utilities; +#pragma warning disable AL0432, AS0105 codeunit 139077 "SFTP Client Test" { Subtype = Test; @@ -409,4 +410,5 @@ codeunit 139077 "SFTP Client Test" Assert.AreEqual(ExpectedErrorMessage, Response.GetError(), 'Incorrect error message'); Assert.AreEqual(Enum::"SFTP Exception Type"::"Untrusted Server Exception", Response.GetErrorType(), 'Incorrect error type'); end; -} \ No newline at end of file +} +#pragma warning restore AL0432, AS0105