Skip to content

Commit 41e8175

Browse files
authored
fix: respect outer visibility across Web Chat (#5473)
* fix: respect outer visibility across Web Chat * Changelog
1 parent a6b3ad8 commit 41e8175

4 files changed

Lines changed: 5 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -212,6 +212,7 @@ Notes: web developers are advised to use [`~` (tilde range)](https://github.com/
212212
- Fixed [#5439](https://github.com/microsoft/BotFramework-WebChat/issues/5439). Fixed batched livestream activities are not recognized in the same session, in PR [#5440](https://github.com/microsoft/BotFramework-WebChat/pull/5440), by [@compulim](https://github.com/compulim)
213213
- Fixed [#5452](https://github.com/microsoft/BotFramework-WebChat/issues/5452). With Fluent/Copilot theme, the typing indicator padding should not be squashed, in PR [#5453](https://github.com/microsoft/BotFramework-WebChat/pull/5453), by [@compulim](https://github.com/compulim)
214214
- Fixed [#5461](https://github.com/microsoft/BotFramework-WebChat/issues/5461). On macOS and Fluent skinpack applied, using Japanese IME to input some Japanese text should not send them immediately, in PR [#5462](https://github.com/microsoft/BotFramework-WebChat/pull/5462), by [@compulim](https://github.com/compulim)
215+
- Fixed [#5472](https://github.com/microsoft/BotFramework-WebChat/issues/5472), ensure proper inheritance from the outside of Web Chat for visibility CSS property when hidden, in PR [#5473](https://github.com/microsoft/BotFramework-WebChat/pull/5473), by [@OEvgeny](https://github.com/OEvgeny)
215216

216217
# Removed
217218

packages/component/src/Styles/StyleSet/ActivityCopyButton.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ export default function createActivityButtonStyle() {
2727

2828
'@keyframes webchat__activity-copy-button__copied-animation': {
2929
'0%': {
30+
// This is set during the animation only hence shouldn't spill when hidden from the above tree
3031
visibility: 'visible'
3132
},
3233

packages/component/src/Styles/StyleSet/ThumbButton.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export default function () {
5555
width: 14,
5656

5757
'&.webchat__thumb-button__image--is-stroked': {
58-
visibility: 'visible'
58+
visibility: 'unset'
5959
}
6060
},
6161

@@ -66,7 +66,7 @@ export default function () {
6666
},
6767

6868
'&.webchat__thumb-button__image--is-filled': {
69-
visibility: 'visible'
69+
visibility: 'unset'
7070
}
7171
}
7272
}

packages/fluent-theme/src/components/sendBox/TextArea.module.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
:global(.webchat-fluent) .sendbox__text-area--in-completion {
1616
.sendbox__text-area-doppelganger {
17-
visibility: visible;
17+
visibility: unset;
1818
}
1919

2020
.sendbox__text-area-input {

0 commit comments

Comments
 (0)