review comment fixed

Author: pranavjoshi001

__tests__/html2/speechToSpeech/mute.unmute.html

@@ -16,12 +16,13 @@
       Test: Mute/Unmute functionality for Speech-to-Speech
       
       This test validates:
-      1. Mute is allowed from all state except idle
-      2. When muted during listening, chunks contain all zeros (silent audio)
-      3. When unmuted, chunks contain real audio
-      4. Mute resets to false when recording stops
-      5. Stopping while muted does NOT re-acquire microphone (cleanup order test)
-      6. Uses useVoiceRecordingMuted hook for mute/unmute control
+      1. Mute is independent of voiceState - can be toggled anytime
+      2. Starting recording while muted should reset and start recording always unmuted.
+      3. When muted during listening, chunks contain all zeros (silent audio)
+      4. When unmuted, chunks contain real audio
+      5. Mute resets to false when recording stops
+      6. Stopping while muted does NOT re-acquire microphone (cleanup order test)
+      7. Uses useVoiceRecordingMuted hook for mute/unmute control
     -->
     <script type="module">
       import { setupMockMediaDevices } from '/assets/esm/speechToSpeech/mockMediaDevices.js';
@@ -123,17 +124,17 @@
         const micButton = document.querySelector(`[data-testid="${testIds.sendBoxMicrophoneButton}"]`);
         expect(micButton).toBeTruthy();
 
-        // ===== TEST 1: Muting from idle state should be no-op =====
+        // ===== TEST 1: Muting from idle state should work as independent from voice state =====
         expect(getVoiceState()).toBe('idle');
         expect(muteControlRef.muted).toBe(false);
 
         muteControlRef.setMuted(true);
         await new Promise(r => setTimeout(r, 100));
 
         expect(getVoiceState()).toBe('idle'); // Still idle, not muted
-        expect(muteControlRef.muted).toBe(false);
+        expect(muteControlRef.muted).toBe(true);
 
-        // ===== TEST 2: Start recording → listening state =====
+        // ===== TEST 2: Start recording → listening state, microphoneMuted resets to false =====
         await host.click(micButton);
 
         await pageConditions.became(
@@ -142,6 +143,10 @@
           2000
         );
 
+        // Starting recording resets microphoneMuted to false.
+        // This ensures a clean slate - recording always starts unmuted.
+        expect(muteControlRef.muted).toBe(false);
+
         // Wait for some listening chunks
         await pageConditions.became(
           'At least 2 listening chunks received',

packages/core/src/reducers/voiceActivity.ts

@@ -41,12 +41,6 @@ export default function voiceActivity(
 ): VoiceActivityState {
   switch (action.type) {
     case VOICE_MUTE_RECORDING:
-      // Only allow muting when in recording state
-      if (state.voiceState === 'idle') {
-        console.warn(`botframework-webchat: Cannot mute from "${state.voiceState}" state, must be in recording state.`);
-        return state;
-      }
-
       return {
         ...state,
         microphoneMuted: true
@@ -83,6 +77,7 @@ export default function voiceActivity(
 
       return {
         ...state,
+        microphoneMuted: false,
         voiceState: 'listening'
       };