Skip to content

Commit ee6af7a

Browse files
committed
Apply PR suggestions
1 parent 1e2355d commit ee6af7a

9 files changed

Lines changed: 14 additions & 15 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ Breaking changes in this release:
4040
- 💥 Root-level (unconnected) `Claim` entity is being deprecated, in PR [#5564](https://github.com/microsoft/BotFramework-WebChat/pull/5564), by [@compulim](https://github.com/compulim). It will be removed on or after 2027-08-29
4141
- Use `entities[@id=""][@type="Message"].citation[@type="Claim"]` instead
4242
- 💥 `activityStatusMiddleware.nextVisibleActivity` and `activityStatusMiddleware.sameTimestampGroup` is removed after deprecation, in PR [#5565](https://github.com/microsoft/BotFramework-WebChat/issues/5565), by [@compulim](https://github.com/compulim)
43-
- 💥 `avatarMiddleware` is being deprecated in favor of [`polymiddleware`](./docs/MIDDLEWARE.md). It will be removed on or after 2028-03-18, related to PR [#5779](https://github.com/microsoft/BotFramework-WebChat/pull/5779)
43+
- 💥 `avatarMiddleware` is being deprecated in favor of [`polymiddleware`](./docs/MIDDLEWARE.md). It will be removed on or after 2028-03-16, related to PR [#5779](https://github.com/microsoft/BotFramework-WebChat/pull/5779)
4444

4545
### Added
4646

@@ -357,7 +357,7 @@ Breaking changes in this release:
357357
- Removed legacy test harness, in PR [#5655](https://github.com/microsoft/BotFramework-WebChat/issues/5655), by [@compulim](https://github.com/compulim)
358358
- All tests are now either using `html2` test harness or simple unit tests
359359
- Legacy and `html` (html1) test harness are all migrated to `html2`
360-
- `avatarMiddleware` is being deprecated in favor of [`polymiddleware`](./docs/MIDDLEWARE.md). It will be removed on or after 2028-03-18, related to PR [#5779](https://github.com/microsoft/BotFramework-WebChat/pull/5779)
360+
- `avatarMiddleware` is being deprecated in favor of [`polymiddleware`](./docs/MIDDLEWARE.md). It will be removed on or after 2028-03-16, related to PR [#5779](https://github.com/microsoft/BotFramework-WebChat/pull/5779)
361361

362362
### Fixed
363363

__tests__/html2/middleware/avatar/useBuildRenderAvatarCallback.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@
132132
from: { role: 'bot' },
133133
id: 'a-00001',
134134
text: 'Hello, World!',
135-
type: 'messagenp'
135+
type: 'message'
136136
}
137137
})
138138
)

docs/MIDDLEWARE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ We introduced polymiddleware in 2025-08-16. Based on our 2-year deprecation rule
330330
| Activity status | | (TBD) |
331331
| Attachment | | (TBD) |
332332
| Attachment for screen reader | | (TBD) |
333-
| Avatar | PR [#5779](https://github.com/microsoft/BotFramework-WebChat/pull/5779) | 2028-03-18 |
333+
| Avatar | PR [#5779](https://github.com/microsoft/BotFramework-WebChat/pull/5779) | 2028-03-16 |
334334
| Card action | | (TBD) |
335335
| Group activities | | (TBD) |
336336
| Scroll to end button | | (TBD) |

packages/api-middleware/src/legacy/avatarMiddleware.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { type ReactNode } from 'react';
44
import type { AvatarPolymiddlewareRequest } from '../avatarPolymiddleware';
55

66
// Polymiddleware requires immutable request object.
7-
// When bridging between legacy and polymiddlware, this symbol helps keeping the original object.
7+
// When bridging between legacy and polymiddleware, this symbol helps keeping the original object.
88
const __INTERNAL_DO_NOT_USE__legacyAvatarMiddlewareOriginalRequestSymbol = Symbol();
99

1010
type LegacyAvatarComponentFactoryArguments = {

packages/api/src/legacy/createAvatarPolymiddlewareFromLegacy.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ const MemoizedLegacyAvatarBridge = memo(LegacyAvatarBridge);
3939
/**
4040
* Polyfill legacy avatar middleware into a polymiddleware.
4141
*
42-
* @deprecated Use `polymiddleware` instead. Legacy avatar middleware is being deprecated and will be removed on or after 2027-08-16.
42+
* @deprecated Use `polymiddleware` instead. Legacy avatar middleware is being deprecated and will be removed on or after 2028-03-16.
4343
* @param middleware An array of legacy avatar middleware.
4444
* @returns A polymiddleware composed by legacy avatar middleware.
4545
*/

packages/api/src/types/AvatarMiddleware.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { type WebChatActivity } from 'botframework-webchat-core';
22

3-
import type {
3+
import {
44
__INTERNAL_DO_NOT_USE__legacyAvatarMiddlewareOriginalRequestSymbol,
5-
AvatarPolymiddlewareRequest
5+
type AvatarPolymiddlewareRequest
66
} from '@msinternal/botframework-webchat-api-middleware';
77
import { StrictStyleOptions } from '../StyleOptions';
88
import ComponentMiddleware, { ComponentFactory } from './ComponentMiddleware';
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
/** @deprecated Will be removed on or after 2028-03-18. */
1+
/** @deprecated Will be removed on or after 2028-03-16. */
22
export default function singleToArray<T>(singleOrArray: T | T[]): T[];
3-
/** @deprecated Will be removed on or after 2028-03-18. */
3+
/** @deprecated Will be removed on or after 2028-03-16. */
44
export default function singleToArray<T>(singleOrArray: T | readonly T[]): readonly T[];
55

6-
/** @deprecated Will be removed on or after 2028-03-18. */
6+
/** @deprecated Will be removed on or after 2028-03-16. */
77
export default function singleToArray<T>(singleOrArray: T | T[]): T[] {
88
return singleOrArray ? (Array.isArray(singleOrArray) ? [...singleOrArray] : [singleOrArray]) : [];
99
}

packages/component/src/Middleware/Activity/defaultActivityPolymiddleware.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ function shouldFilterActivity(activity, messageThing) {
3737
}
3838

3939
/**
40-
* @deprecated Use `defaultActivityPolymiddleware` instead. The `createCoreActivityMiddleware` will be removed on or after 2028-03-18.
40+
* @deprecated Use `defaultActivityPolymiddleware` instead. The `createCoreActivityMiddleware` will be removed on or after 2028-03-16.
4141
*/
4242
function createCoreActivityMiddleware(): readonly ActivityMiddleware[] {
4343
return Object.freeze([

packages/test/page-object/src/globals/testHelpers/createDirectLineWithTranscript.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,9 @@ export default function createDirectLineWithTranscript(
3939
{ overridePostActivity, patchActivity: patchActivityFromOptions, ponyfill: { Date } = { Date: window.Date } } = {}
4040
) {
4141
const now = Date.now();
42+
const updateRelativeTimestamp = createUpdateRelativeTimestamp(now, { Date });
4243
const patchActivity = activity =>
43-
createUpdateRelativeTimestamp(now, { Date })(
44-
patchActivityFromOptions ? patchActivityFromOptions(activity) : activity
45-
);
44+
updateRelativeTimestamp(patchActivityFromOptions ? patchActivityFromOptions(activity) : activity);
4645
const connectionStatusDeferredObservable = createDeferredObservable(() => {
4746
connectionStatusDeferredObservable.next(0);
4847
});

0 commit comments

Comments
 (0)