feat(scripts): Make version sync script error by default

The `verify-version-sync.js` script now errors and exits with a non-zero status code if a version mismatch is detected between `package.json` and `source.extension.vsixmanifest`.

Previously, the script would automatically update the manifest, which could hide versioning issues in CI environments. The new behavior ensures that verification steps fail as expected.

To retain the auto-fixing functionality, a `--fix` flag has been introduced. A corresponding `npm run fix:version` script has been added to `package.json` for convenience.

Additionally, this commit includes:
- Refactoring in `MockFileService` to use a more robust path comparison method.
- Improved error handling in the integration test runner.

Author: joninafta

package.json

@@ -415,6 +415,7 @@
     "bundle": "esbuild ./src/extension.ts --bundle --outfile=dist/extension.js --platform=node --format=cjs --external:vscode --sourcemap",
     "package": "echo 'vsce not installed in offline env'",
     "verify:version": "node scripts/verify-version-sync.js",
+    "fix:version": "node scripts/verify-version-sync.js --fix",
     "test": "npm run compile && node ./dist/test/runVscodeTests.js",
     "compile": "tsc -p ./",
     "test:unit": "node dist/test/runTest.js",

scripts/verify-version-sync.js

@@ -19,11 +19,19 @@ if(!manifestVersion){
   process.exit(2);
 }
 
+const shouldFix = process.argv.includes('--fix');
+
 if(pkg.version !== manifestVersion){
-  console.log(`Version mismatch detected. package.json=${pkg.version}, manifest=${manifestVersion}. Updating manifest...`);
-  const updatedXml = xml.replace(/(<Identity[^>]*Version=")([^"]+)(")/i, `$1${pkg.version}$3`);
-  fs.writeFileSync(manifestPath, updatedXml, 'utf8');
-  console.log(`Successfully updated ${manifestPath} to version ${pkg.version}`);
+  if (shouldFix) {
+    console.log(`Version mismatch detected. package.json=${pkg.version}, manifest=${manifestVersion}. Updating manifest...`);
+    const updatedXml = xml.replace(/(<Identity[^>]*Version=")([^"]+)(")/i, `$1${pkg.version}$3`);
+    fs.writeFileSync(manifestPath, updatedXml, 'utf8');
+    console.log(`Successfully updated ${manifestPath} to version ${pkg.version}`);
+  } else {
+    console.error(`ERROR: Version mismatch. package.json is ${pkg.version}, but vsixmanifest is ${manifestVersion}.`);
+    console.error('Run with --fix to automatically update the manifest.');
+    process.exit(1);
+  }
 } else {
   console.log(`Version sync OK: ${pkg.version}`);
 }

test/fileService.mock.ts

@@ -27,14 +27,13 @@ export class MockFileService implements IFileService {
   async rm(p: string, options?: { recursive?: boolean; force?: boolean }): Promise<void> {
     const norm = path.resolve(p);
     if (options?.recursive) {
-      const normWithSep = norm + path.sep;
       for (const file of this.files.keys()) {
-        if (file === norm || file.startsWith(normWithSep)) {
+        if (file === norm || this.isChildPath(file, norm)) {
           this.files.delete(file);
         }
       }
       for (const dir of this.dirs.keys()) {
-        if (dir === norm || dir.startsWith(normWithSep)) {
+        if (dir === norm || this.isChildPath(dir, norm)) {
           this.dirs.delete(dir);
         }
       }
@@ -43,4 +42,9 @@ export class MockFileService implements IFileService {
       this.dirs.delete(norm);
     }
   }
+
+  private isChildPath(childPath: string, parentPath: string): boolean {
+    const relative = path.relative(parentPath, childPath);
+    return relative.length > 0 && !relative.startsWith('..') && !path.isAbsolute(relative);
+  }
 }

test/real.integration.test.ts

@@ -92,10 +92,17 @@ async function runRealIntegrationTests() {
 
 // Run tests if this file is executed directly
 if (require.main === module) {
-    runRealIntegrationTests().catch(err => {
-        console.error(err);
-        process.exit(1);
-    });
+  (async () => {
+    try {
+      await runRealIntegrationTests();
+    } catch (err) {
+      console.error('Unhandled error in real integration tests:', err);
+      process.exit(1);
+    }
+  })().catch(err => {
+    console.error('Critical error in test execution:', err);
+    process.exit(1);
+  });
 }
 
 export { runRealIntegrationTests };