-
Notifications
You must be signed in to change notification settings - Fork 2
Expand file tree
/
Copy pathtargeting_context_accessor_test.go
More file actions
249 lines (219 loc) · 6.22 KB
/
targeting_context_accessor_test.go
File metadata and controls
249 lines (219 loc) · 6.22 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.
package featuremanagement
import (
"fmt"
"testing"
"github.com/go-viper/mapstructure/v2"
)
// mockTargetingContextAccessor implements TargetingContextAccessor for testing
type mockTargetingContextAccessor struct {
targetingContext TargetingContext
err error
}
func (m *mockTargetingContextAccessor) GetTargetingContext() (TargetingContext, error) {
return m.targetingContext, m.err
}
func TestTargetingContextAccessor_IsEnabled(t *testing.T) {
featureFlagData := map[string]any{
"ID": "TargetedFeature",
"Enabled": true,
"Conditions": map[string]any{
"ClientFilters": []any{
map[string]any{
"Name": "Microsoft.Targeting",
"Parameters": map[string]any{
"Audience": map[string]any{
"Users": []any{"Alice"},
"Groups": []any{},
"DefaultRolloutPercentage": 0,
},
},
},
},
},
}
var featureFlag FeatureFlag
err := mapstructure.Decode(featureFlagData, &featureFlag)
if err != nil {
t.Fatalf("Failed to decode feature flag: %v", err)
}
provider := &mockFeatureFlagProvider{
featureFlags: []FeatureFlag{featureFlag},
}
tests := []struct {
name string
accessor *mockTargetingContextAccessor
expectedResult bool
expectError bool
}{
{
name: "Accessor provides targeted user - should be enabled",
accessor: &mockTargetingContextAccessor{
targetingContext: TargetingContext{UserID: "Alice"},
},
expectedResult: true,
},
{
name: "Accessor provides non-targeted user - should be disabled",
accessor: &mockTargetingContextAccessor{
targetingContext: TargetingContext{UserID: "Bob"},
},
expectedResult: false,
},
{
name: "Accessor returns error - targeting filter fails gracefully",
accessor: &mockTargetingContextAccessor{
err: fmt.Errorf("no user context available"),
},
expectedResult: false,
expectError: true,
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
manager, err := NewFeatureManager(provider, &Options{
TargetingContextAccessor: tc.accessor,
})
if err != nil {
t.Fatalf("Failed to create feature manager: %v", err)
}
// Call IsEnabled without appContext — accessor should provide targeting context
result, err := manager.IsEnabled("TargetedFeature")
if tc.expectError {
if err == nil {
t.Error("Expected error but got none")
}
return
}
if err != nil {
t.Errorf("Unexpected error: %v", err)
return
}
if result != tc.expectedResult {
t.Errorf("Expected %v, got %v", tc.expectedResult, result)
}
})
}
}
func TestTargetingContextAccessor_ExplicitContextOverridesAccessor(t *testing.T) {
featureFlagData := map[string]any{
"ID": "TargetedFeature",
"Enabled": true,
"Conditions": map[string]any{
"ClientFilters": []any{
map[string]any{
"Name": "Microsoft.Targeting",
"Parameters": map[string]any{
"Audience": map[string]any{
"Users": []any{"Alice"},
"Groups": []any{},
"DefaultRolloutPercentage": 0,
},
},
},
},
},
}
var featureFlag FeatureFlag
err := mapstructure.Decode(featureFlagData, &featureFlag)
if err != nil {
t.Fatalf("Failed to decode feature flag: %v", err)
}
provider := &mockFeatureFlagProvider{
featureFlags: []FeatureFlag{featureFlag},
}
// Accessor returns "Bob" (not targeted), but explicit context says "Alice" (targeted)
accessor := &mockTargetingContextAccessor{
targetingContext: TargetingContext{UserID: "Bob"},
}
manager, err := NewFeatureManager(provider, &Options{
TargetingContextAccessor: accessor,
})
if err != nil {
t.Fatalf("Failed to create feature manager: %v", err)
}
// Explicit context should override the accessor
result, err := manager.IsEnabledWithAppContext("TargetedFeature", TargetingContext{UserID: "Alice"})
if err != nil {
t.Errorf("Unexpected error: %v", err)
return
}
if !result {
t.Error("Expected feature to be enabled for Alice (explicit context), but it was disabled")
}
}
func TestTargetingContextAccessor_GetVariant(t *testing.T) {
featureFlagData := map[string]any{
"ID": "VariantFeature",
"Enabled": true,
"Allocation": map[string]any{
"DefaultWhenEnabled": "Small",
"User": []any{
map[string]any{
"Variant": "Big",
"Users": []any{"Alice"},
},
},
},
"Variants": []any{
map[string]any{"Name": "Big", "ConfigurationValue": "500px"},
map[string]any{"Name": "Small", "ConfigurationValue": "300px"},
},
}
var featureFlag FeatureFlag
err := mapstructure.Decode(featureFlagData, &featureFlag)
if err != nil {
t.Fatalf("Failed to decode feature flag: %v", err)
}
provider := &mockFeatureFlagProvider{
featureFlags: []FeatureFlag{featureFlag},
}
accessor := &mockTargetingContextAccessor{
targetingContext: TargetingContext{UserID: "Alice"},
}
manager, err := NewFeatureManager(provider, &Options{
TargetingContextAccessor: accessor,
})
if err != nil {
t.Fatalf("Failed to create feature manager: %v", err)
}
// Call GetVariant with nil appContext — accessor should provide targeting context
variant, err := manager.GetVariant("VariantFeature", nil)
if err != nil {
t.Fatalf("Unexpected error: %v", err)
}
if variant == nil {
t.Fatal("Expected a variant but got nil")
}
if variant.Name != "Big" {
t.Errorf("Expected variant 'Big' for Alice, got '%s'", variant.Name)
}
}
func TestTargetingContextAccessor_NilAccessor(t *testing.T) {
featureFlagData := map[string]any{
"ID": "SimpleFeature",
"Enabled": true,
}
var featureFlag FeatureFlag
err := mapstructure.Decode(featureFlagData, &featureFlag)
if err != nil {
t.Fatalf("Failed to decode feature flag: %v", err)
}
provider := &mockFeatureFlagProvider{
featureFlags: []FeatureFlag{featureFlag},
}
// No accessor — should work fine for features without targeting
manager, err := NewFeatureManager(provider, nil)
if err != nil {
t.Fatalf("Failed to create feature manager: %v", err)
}
result, err := manager.IsEnabled("SimpleFeature")
if err != nil {
t.Errorf("Unexpected error: %v", err)
return
}
if !result {
t.Error("Expected feature to be enabled")
}
}