fix: variable names and lint

Not complete b/c some of the queries don't return

Author: gadomski

datasets/met-office/met-office-global-deterministic-height.ipynb

@@ -18,7 +18,7 @@
   },
   {
    "cell_type": "code",
-   "execution_count": null,
+   "execution_count": 1,
    "id": "4bafd899",
    "metadata": {},
    "outputs": [],
@@ -49,18 +49,18 @@
    "source": [
     "collections = [\"met-office-uk-deterministic-near-surface\"]\n",
     "asset_id = \"temperature_at_surface\"\n",
-    "datacube_extension_filters = {\n",
+    "forecast_extension_filters = {\n",
     "    \"op\": \"and\",\n",
     "    \"args\": [\n",
     "        {\n",
     "            \"op\": \"=\",\n",
-    "            \"args\": [ { \"property\": \"forecast:reference_datetime\" }, \"2025-12-05T18:00:00Z\" ]\n",
+    "            \"args\": [\n",
+    "                {\"property\": \"forecast:reference_datetime\"},\n",
+    "                \"2026-01-21T09:00:00Z\",\n",
+    "            ],\n",
     "        },\n",
-    "        {\n",
-    "            \"op\": \"=\",\n",
-    "            \"args\": [ { \"property\": \"forecast:horizon\" }, \"PT0001H00M\" ]\n",
-    "        }\n",
-    "    ]\n",
+    "        {\"op\": \"=\", \"args\": [{\"property\": \"forecast:horizon\"}, \"PT0054H00M\"]},\n",
+    "    ],\n",
     "}"
    ]
   },
@@ -77,16 +77,27 @@
    "execution_count": null,
    "id": "edb71afa",
    "metadata": {},
-   "outputs": [],
+   "outputs": [
+    {
+     "ename": "StopIteration",
+     "evalue": "",
+     "output_type": "error",
+     "traceback": [
+      "\u001b[31m---------------------------------------------------------------------------\u001b[39m",
+      "\u001b[31mStopIteration\u001b[39m                             Traceback (most recent call last)",
+      "\u001b[36mCell\u001b[39m\u001b[36m \u001b[39m\u001b[32mIn[19]\u001b[39m\u001b[32m, line 6\u001b[39m\n\u001b[32m      1\u001b[39m search = catalog.search(\n\u001b[32m      2\u001b[39m     collections=collections,\n\u001b[32m      3\u001b[39m     datetime=\u001b[33m\"\u001b[39m\u001b[33m2026-01-21T09:00:00Z\u001b[39m\u001b[33m\"\u001b[39m,\n\u001b[32m      4\u001b[39m )\n\u001b[32m----> \u001b[39m\u001b[32m6\u001b[39m asset_url = \u001b[38;5;28;43mnext\u001b[39;49m\u001b[43m(\u001b[49m\u001b[43mitem\u001b[49m\u001b[43m \u001b[49m\u001b[38;5;28;43;01mfor\u001b[39;49;00m\u001b[43m \u001b[49m\u001b[43mitem\u001b[49m\u001b[43m \u001b[49m\u001b[38;5;129;43;01min\u001b[39;49;00m\u001b[43m \u001b[49m\u001b[43msearch\u001b[49m\u001b[43m.\u001b[49m\u001b[43mitems\u001b[49m\u001b[43m(\u001b[49m\u001b[43m)\u001b[49m\u001b[43m \u001b[49m\u001b[38;5;28;43;01mif\u001b[39;49;00m\u001b[43m \u001b[49m\u001b[43mitem\u001b[49m\u001b[43m.\u001b[49m\u001b[43mproperties\u001b[49m\u001b[43m[\u001b[49m\u001b[33;43m\"\u001b[39;49m\u001b[33;43mforecast:horizon\u001b[39;49m\u001b[33;43m\"\u001b[39;49m\u001b[43m]\u001b[49m\u001b[43m \u001b[49m\u001b[43m==\u001b[49m\u001b[43m \u001b[49m\u001b[33;43m\"\u001b[39;49m\u001b[33;43mPT0054H00M\u001b[39;49m\u001b[33;43m\"\u001b[39;49m\u001b[43m)\u001b[49m.assets[asset_id].href\n",
+      "\u001b[31mStopIteration\u001b[39m: "
+     ]
+    }
+   ],
    "source": [
     "search = catalog.search(\n",
     "    collections=collections,\n",
-    "    filter_lang= \"cql2-json\",\n",
-    "    filter=datacube_extension_filters\n",
+    "    filter_lang=\"cql2-json\",\n",
+    "    filter=forecast_extension_filters,\n",
     ")\n",
     "\n",
-    "items = search.item_collection()\n",
-    "asset_url = items.items[0].assets[asset_id].href"
+    "asset_url = next(search.items()).assets[asset_id].href"
    ]
   },
   {
@@ -116,7 +127,7 @@
  ],
  "metadata": {
   "kernelspec": {
-   "display_name": ".venv",
+   "display_name": "PlanetaryComputerExamples",
    "language": "python",
    "name": "python3"
   },
@@ -130,7 +141,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.13.11"
+   "version": "3.13.2"
   }
  },
  "nbformat": 4,

datasets/met-office/met-office-global-deterministic-near-surface.ipynb

@@ -49,18 +49,18 @@
    "source": [
     "collections = [\"met-office-uk-deterministic-pressure\"]\n",
     "asset_id = \"wet_bulb_potential_temperature_on_pressure_levels\"\n",
-    "datacube_extension_filters = {\n",
+    "forecast_extension_filters = {\n",
     "    \"op\": \"and\",\n",
     "    \"args\": [\n",
     "        {\n",
     "            \"op\": \"=\",\n",
-    "            \"args\": [ { \"property\": \"forecast:reference_datetime\" }, \"2026-01-14T12:00:00Z\" ]\n",
+    "            \"args\": [\n",
+    "                {\"property\": \"forecast:reference_datetime\"},\n",
+    "                \"2026-01-14T12:00:00Z\",\n",
+    "            ],\n",
     "        },\n",
-    "        {\n",
-    "            \"op\": \"=\",\n",
-    "            \"args\": [ { \"property\": \"forecast:horizon\" }, \"PT0052H00M\" ]\n",
-    "        }\n",
-    "    ]\n",
+    "        {\"op\": \"=\", \"args\": [{\"property\": \"forecast:horizon\"}, \"PT0052H00M\"]},\n",
+    "    ],\n",
     "}"
    ]
   },
@@ -80,9 +80,7 @@
    "outputs": [],
    "source": [
     "search = catalog.search(\n",
-    "    collections=collections,\n",
-    "    filter_lang= \"cql2-json\",\n",
-    "    filter=datacube_extension_filters\n",
+    "    collections=collections, filter_lang=\"cql2-json\", filter=forecast_extension_filters\n",
     ")\n",
     "\n",
     "items = search.item_collection()\n",
@@ -135,4 +133,4 @@
  },
  "nbformat": 4,
  "nbformat_minor": 5
-}
+}

datasets/met-office/met-office-global-deterministic-pressure.ipynb

@@ -49,18 +49,18 @@
    "source": [
     "collections = [\"met-office-uk-deterministic-whole-atmosphere\"]\n",
     "asset_id = \"lightning_flash_accumulation-PT01H\"\n",
-    "datacube_extension_filters = {\n",
+    "forecast_extension_filters = {\n",
     "    \"op\": \"and\",\n",
     "    \"args\": [\n",
     "        {\n",
     "            \"op\": \"=\",\n",
-    "            \"args\": [ { \"property\": \"forecast:reference_datetime\" }, \"2025-12-05T18:00:00Z\" ]\n",
+    "            \"args\": [\n",
+    "                {\"property\": \"forecast:reference_datetime\"},\n",
+    "                \"2025-12-05T18:00:00Z\",\n",
+    "            ],\n",
     "        },\n",
-    "        {\n",
-    "            \"op\": \"=\",\n",
-    "            \"args\": [ { \"property\": \"forecast:horizon\" }, \"PT0037H00M\" ]\n",
-    "        }\n",
-    "    ]\n",
+    "        {\"op\": \"=\", \"args\": [{\"property\": \"forecast:horizon\"}, \"PT0037H00M\"]},\n",
+    "    ],\n",
     "}"
    ]
   },
@@ -80,9 +80,7 @@
    "outputs": [],
    "source": [
     "search = catalog.search(\n",
-    "    collections=collections,\n",
-    "    filter_lang= \"cql2-json\",\n",
-    "    filter=datacube_extension_filters\n",
+    "    collections=collections, filter_lang=\"cql2-json\", filter=forecast_extension_filters\n",
     ")\n",
     "\n",
     "items = search.item_collection()\n",
@@ -136,4 +134,4 @@
  },
  "nbformat": 4,
  "nbformat_minor": 5
-}
+}