User/snamilikonda/pipeline warnings (#598)

* asn, codesignvalidation changes

* sign release js, ignore playwright

* js, no debug

* useminimatch, sign nuget

* notjs

* conditional enable

* conditional enable

* conditional enable

* conditional enable

* conditional enable

* conditional enable

* skip copy

* renam to allowlist, binskim

Author: snamilikonda

.azurepipelines/azure-pipelines-1ES.yml

@@ -10,10 +10,10 @@ extends:
   template: v1/1ES.Official.PipelineTemplate.yml@1ESPipelineTemplates
   parameters:
     sdl:
+      binskim:
+        break: true
       policheck:
         enabled: true
-      codeSignValidation:
-        enabled: true
       codeql:
         ${{ if eq(variables['Build.SourceBranch'], variables['AllowedBranch']) }}:
           enabledOnNonDefaultBranches: true
@@ -33,19 +33,25 @@ extends:
             Release:
               BuildConfiguration: 'Release'
         templateContext:
+          sdl:
+            ${{ if eq(variables['BuildConfiguration'], 'Release') }}:
+              codeSignValidation:
+                additionalTargetsGlobPattern: -|**\.playwright\**;-|**PowerAppsTestEngineWrapper\playwright.ps1;-|**PowerAppsTestEngineWrapper\JS\**
+                enabled: true
+                break: true
+                
+            ${{ if ne(variables['BuildConfiguration'], 'Release') }}:
+              codeSignValidation:
+                additionalTargetsGlobPattern: -|**\.playwright\**;-|**PowerAppsTestEngineWrapper\playwright.ps1;-|**PowerAppsTestEngineWrapper\JS\**
+                enabled: false
+                break: true
+            
+
           outputs:
           - output: pipelineArtifact
             condition: succeeded()
             artifactName: 'PowerApps.TestEngine ($(BuildConfiguration))'
             targetPath: '$(Build.ArtifactStagingDirectory)'
-          - output: nuget
-            condition: and(succeeded(), eq(variables['BuildConfiguration'], 'Release'), eq(variables['UpdateVer'], 'true'))
-            useDotNetTask: false # The default is false to use the NuGetCommand task. Set to true to use the DotNetCoreCLI task to publish packages.
-            packagesToPush: '$(Build.ArtifactStagingDirectory)/Microsoft.PowerApps.TestEngine.*.nupkg'
-            packageParentPath: '$(Build.ArtifactStagingDirectory)'
-            publishVstsFeed: $(InternalFeed)
-            nuGetFeedType: internal
-            allowPackageConflicts: true # Optional. NuGetCommand task only.
         steps:
         - script: |
             echo "Hello $(myVariable)"
@@ -79,7 +85,9 @@ extends:
             AuthAKVName: $(EsrpKVName)
             AuthSignCertName: $(EsrpAuthSignCertName)
             FolderPath: '$(Build.SourcesDirectory)/bin/$(BuildConfiguration)/PowerAppsTestEngineWrapper/'
-            Pattern: '*.dll'
+            Pattern: |
+              *.dll
+            UseMinimatch: true  
             signConfigType: inlineSignParams
             inlineOperation: |
               [
@@ -122,26 +130,8 @@ extends:
         - task: CopyFiles@2
           displayName: 'Copy Built Files to Artifact Staging Directory'
           inputs:
-            SourceFolder: '$(Build.SourcesDirectory)/bin'
-            TargetFolder: '$(Build.ArtifactStagingDirectory)/buildoutput/bin'
-            # Include all files except abc.txt
-            Contents: |
-              **/*
-              !**/ThirdPartyNotices.txt
-        - task: CopyFiles@2
-          displayName: 'Copy Built Files to Artifact Staging Directory'
-          inputs:
-            SourceFolder: '$(Build.SourcesDirectory)/obj'
-            TargetFolder: '$(Build.ArtifactStagingDirectory)/buildoutput/obj'
-            # Include all files except abc.txt
-            Contents: |
-              **/*
-              !**/ThirdPartyNotices.txt
-        - task: CopyFiles@2
-          displayName: 'Copy Built Files to Artifact Staging Directory'
-          inputs:
-            SourceFolder: '$(Build.SourcesDirectory)/pkg'
-            TargetFolder: '$(Build.ArtifactStagingDirectory)/buildoutput/pkg'
+            SourceFolder: '$(Build.SourcesDirectory)/bin/$(BuildConfiguration)/PowerAppsTestEngineWrapper'
+            TargetFolder: '$(Build.ArtifactStagingDirectory)/buildoutput/bin/$(BuildConfiguration)/PowerAppsTestEngineWrapper'
             # Include all files except abc.txt
             Contents: |
               **/*

src/Microsoft.PowerApps.TestEngine.Tests/Modules/TestEngineModuleMEFLoaderTests.cs

@@ -122,7 +122,7 @@ public void ModuleMatch(bool checkAssemblies, bool checkResult, string? allow, s
         [InlineData("user", "storagestate", true, true)]
         [InlineData("user", "test", true, false)]
         [InlineData("user", "test", false, false)]
-        [InlineData("auth", "certstore", true, true, Skip = "No auth providers whitelisted for releases")]
+        [InlineData("auth", "certstore", true, true, Skip = "No auth providers allowlisted for releases")]
         [InlineData("auth", "environment.certificate", true, true)]
         [InlineData("auth", "test", true, false)]
         [InlineData("auth", "test", false, false)]

src/PowerAppsTestEngineWrapper/PowerAppsTestEngineWrapper.csproj

@@ -42,6 +42,7 @@
     <PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
     <PackageReference Include="Microsoft.AspNetCore.DataProtection" Version="8.0.0" />
     <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.0" />
+    <PackageReference Include="System.Formats.Asn1" Version="8.0.1" />
     <PackageReference Include="Microsoft.PowerPlatform.Dataverse.Client" Version="1.2.2">
       <NoWarn>NU1701</NoWarn>
     </PackageReference>

src/testengine.user.storagestate/testengine.user.storagestate.csproj

@@ -40,6 +40,7 @@
     <PackageReference Include="Microsoft.AspNetCore.DataProtection" Version="8.0.0" />
     <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0" />
     <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.0" />
+    <PackageReference Include="System.Formats.Asn1" Version="8.0.1" />
     <PackageReference Include="Microsoft.PowerPlatform.Dataverse.Client" Version="1.2.2">
       <NoWarn>NU1701</NoWarn>
     </PackageReference>