msg update and adding separator for directory access (#607)

* msg update and adding separator for directory access

* test msg update

Author: snamilikonda

src/Microsoft.PowerApps.TestEngine.Tests/Config/YamlTestConfigParserTests.cs

@@ -381,7 +381,7 @@ public void YamlTestConfigParserThrowsOnInvalidFilePath()
             var ex = Assert.Throws<UserInputException>(() => parser.ParseTestConfig<TestSettings>("some invalid file path", MockLogger.Object));
             Assert.Equal(ex.Message, UserInputException.ErrorMapping.UserInputExceptionInvalidFilePath.ToString());
             // Verify the message is logged in this case
-            LoggingTestHelper.VerifyLogging(MockLogger, "Invalid file path: TestSettings in test config file.", LogLevel.Error, Times.Once());
+            LoggingTestHelper.VerifyLogging(MockLogger, "Test config file path is invalid or access is not permitted. For more details, check the logs and refer https://aka.ms/pactests/fileaccessrestrictions.", LogLevel.Error, Times.Once());
         }
 
         [Fact]

src/Microsoft.PowerApps.TestEngine.Tests/System/FileSystemTests.cs

@@ -62,6 +62,7 @@ public void Dispose()
         [InlineData(@"C:\folder\PRN.yaml", false)]
         [InlineData(@"C:\WINDOWS\system32", false)]
         [InlineData(@"C:\folder\file.com", false)]
+        [InlineData(@"C:\Users\Public\Videos\test.yaml", false)]
         public void CanAccessFilePathTest_Windows(string? filePath, bool expectedResult)
         {
             if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))

src/Microsoft.PowerApps.TestEngine/Config/YamlTestConfigParser.cs

@@ -31,7 +31,7 @@ public T ParseTestConfig<T>(string testConfigFilePath, ILogger logger)
 
                 if (!_fileSystem.FileExists(testConfigFilePath))
                 {
-                    logger.LogError($"Invalid file path: {typeof(T).Name} in test config file.");
+                    logger.LogError($"Test config file path is invalid or access is not permitted. For more details, check the logs and refer https://aka.ms/pactests/fileaccessrestrictions.");
                     throw new UserInputException(UserInputException.ErrorMapping.UserInputExceptionInvalidFilePath.ToString());
                 }
 

src/Microsoft.PowerApps.TestEngine/PowerFx/Functions/ScreenshotFunction.cs

@@ -38,7 +38,7 @@ public BlankValue Execute(StringValue file)
             var testResultDirectory = _singleTestInstanceState.GetTestResultsDirectory();
             if (!_fileSystem.Exists(testResultDirectory))
             {
-                _logger.LogError("Test result directory needs to be set.");
+                _logger.LogError("Test result directory needs to be set and accessible.");
                 throw new InvalidOperationException();
             }
 

src/Microsoft.PowerApps.TestEngine/System/FileSystem.cs

@@ -233,6 +233,11 @@ public bool WindowsReservedLocationExistsInPath(string fullPath)
             {
                 return true;
             }
+            // Ensure the path ends with a directory separator
+            if (!fullPath.EndsWith(Path.DirectorySeparatorChar.ToString()) && !fullPath.EndsWith(Path.AltDirectorySeparatorChar.ToString()))
+            {
+                fullPathUri = new Uri(fullPathUri.ToString().TrimEnd(Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar) + Path.DirectorySeparatorChar, UriKind.Absolute);
+            }
 
             //check if any of reserved base locations referred then fail
             IEnumerable<Uri> windowsRestrictedPaths = new List<Uri>
@@ -304,6 +309,11 @@ public bool LinuxReservedLocationExistsInPath(string fullPath)
             {
                 return true;
             }
+            // Ensure the path ends with a directory separator
+            if (!fullPath.EndsWith(Path.DirectorySeparatorChar.ToString()) && !fullPath.EndsWith(Path.AltDirectorySeparatorChar.ToString()))
+            {
+                fullPathUri = new Uri(fullPathUri.ToString().TrimEnd(Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar) + Path.DirectorySeparatorChar, UriKind.Absolute);
+            }
 
             IEnumerable<Uri> LinuxRestrictedPaths = new List<Uri>
             {
@@ -354,12 +364,22 @@ public bool LinuxReservedLocationExistsInPath(string fullPath)
         public bool OsxReservedLocationExistsInPath(string fullPath)
         {
             fullPath = Path.GetFullPath(fullPath);
+
+            if (fullPath.Equals("/"))
+            {
+                return true;
+            }
             //check if its a network path if so fail
             var fullPathUri = new Uri(fullPath.StartsWith(@"\\?\") ? fullPath.Replace(@"\\?\", "") : fullPath, UriKind.Absolute);
             if (fullPathUri.IsUnc)
             {
                 return true;
             }
+            // Ensure the path ends with a directory separator
+            if (!fullPath.EndsWith(Path.DirectorySeparatorChar.ToString()) && !fullPath.EndsWith(Path.AltDirectorySeparatorChar.ToString()))
+            {
+                fullPathUri = new Uri(fullPathUri.ToString().TrimEnd(Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar) + Path.DirectorySeparatorChar, UriKind.Absolute);
+            }
 
             IEnumerable<Uri> OsxRestrictedPaths = new List<Uri>
             {

src/Microsoft.PowerApps.TestEngine/TestEngineEventHandler.cs

@@ -18,7 +18,7 @@ public class TestEngineEventHandler : ITestEngineEvents
         // NOTE: Any changes to these messages need to be handled in the consuming tool's console event handler, like in pac cli tool.
         // These console messages need to be considered for localization.
         public static string UserAppExceptionMessage = "   [Critical Error] Could not access Provider. For more details, check the logs.";
-        public static string UserInputExceptionInvalidFilePathMessage = "   Invalid file path. For more details, check the logs.";
+        public static string UserInputExceptionInvalidFilePathMessage = "   File path is invalid or access is not permitted. For more details, check the logs and refer https://aka.ms/pactests/fileaccessrestrictions.";
         public static string UserInputExceptionInvalidOutputPathMessage = "   [Critical Error]: The output directory provided is invalid.";
         public static string UserInputExceptionInvalidTestSettingsMessage = "   Invalid test settings specified in testconfig. For more details, check the logs.";
         public static string UserInputExceptionLoginCredentialMessage = "   Invalid login credential(s). For more details, check the logs.";

src/testengine.module.playwrightaction/PlaywrightActionValueFunction.cs

@@ -74,7 +74,7 @@ public BooleanValue Execute(StringValue locator, StringValue action, StringValue
                     var testResultDirectory = _singleTestInstanceState.GetTestResultsDirectory();
                     if (!_fileSystem.Exists(testResultDirectory))
                     {
-                        _logger.LogError("Test result directory needs to be set.");
+                        _logger.LogError("Test result directory needs to be set and accessible.");
                         throw new InvalidOperationException();
                     }