Skip to content

Commit f883c06

Browse files
authored
Updated the playwright version to 55 (#661)
* Updated the playwright version to 55 * fixing unit tests
1 parent 2f24375 commit f883c06

8 files changed

Lines changed: 21 additions & 9 deletions

File tree

src/Microsoft.PowerApps.TestEngine/Microsoft.PowerApps.TestEngine.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
<PackageReference Include="Microsoft.Data.OData" Version="5.8.4" />
4646
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0" />
4747
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
48-
<PackageReference Include="Microsoft.Playwright" Version="1.52.0" />
48+
<PackageReference Include="Microsoft.Playwright" Version="1.55.0" />
4949
<PackageReference Include="Microsoft.PowerFx.Interpreter" Version="$(PowerFxVersion)" />
5050
<PackageReference Include="Microsoft.PowerFx.Json" Version="$(PowerFxVersion)" />
5151
<PackageReference Include="Microsoft.PowerFx.Dataverse.Eval" Version="$(PowerFxVersion)" />

src/Microsoft.PowerApps.TestEngine/TestInfra/PlaywrightTestInfraFunctions.cs

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,10 +115,22 @@ public async Task SetupAsync(IUserManager userManager)
115115
staticContext.Args = (staticContext.Args ?? Array.Empty<string>()).Concat(headlessArgs).ToArray();
116116
}
117117

118-
var browser = PlaywrightObject[browserConfig.Browser];
118+
// Use indexer for valid browser (tests assert this), translate null or ArgumentException to UserInputException
119+
IBrowserType browser = null;
120+
try
121+
{
122+
browser = PlaywrightObject[browserConfig.Browser];
123+
}
124+
catch (ArgumentException)
125+
{
126+
// Ensure we map any Playwright internal invalid browser exceptions to UserInputException
127+
_singleTestInstanceState.GetLogger().LogError(BrowserNotSupportedErrorMessage);
128+
throw new UserInputException(UserInputException.ErrorMapping.UserInputExceptionInvalidTestSettings.ToString());
129+
}
130+
119131
if (browser == null)
120132
{
121-
_singleTestInstanceState.GetLogger().LogError("Browser not supported by Playwright, for more details check https://playwright.dev/dotnet/docs/browsers");
133+
_singleTestInstanceState.GetLogger().LogError(BrowserNotSupportedErrorMessage);
122134
throw new UserInputException(UserInputException.ErrorMapping.UserInputExceptionInvalidTestSettings.ToString());
123135
}
124136

src/PowerAppsTestEngineWrapper/PowerAppsTestEngineWrapper.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
<PackageReference Include="Microsoft.Data.OData" Version="5.8.4" />
2929
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0" />
3030
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
31-
<PackageReference Include="Microsoft.Playwright" Version="1.52.0" />
31+
<PackageReference Include="Microsoft.Playwright" Version="1.55.0" />
3232
<PackageReference Include="Microsoft.PowerFx.Interpreter" Version="$(PowerFxVersion)" />
3333
<PackageReference Include="Mono.Cecil" Version="0.11.6" />
3434
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />

src/testengine.common.user/testengine.common.user.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
</PropertyGroup>
2323

2424
<ItemGroup>
25-
<PackageReference Include="Microsoft.Playwright" Version="1.52.0" />
25+
<PackageReference Include="Microsoft.Playwright" Version="1.55.0" />
2626
</ItemGroup>
2727

2828
<ItemGroup>

src/testengine.module.mda/testengine.module.mda.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242

4343
<ItemGroup>
4444
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
45-
<PackageReference Include="Microsoft.Playwright" Version="1.52.0" />
45+
<PackageReference Include="Microsoft.Playwright" Version="1.55.0" />
4646
<PackageReference Include="Microsoft.PowerFx.Interpreter" Version="$(PowerFxVersion)" />
4747
<PackageReference Include="System.ComponentModel.Composition" Version="5.0.0" />
4848
</ItemGroup>

src/testengine.module.pause/testengine.module.pause.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343

4444
<ItemGroup>
4545
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
46-
<PackageReference Include="Microsoft.Playwright" Version="1.52.0" />
46+
<PackageReference Include="Microsoft.Playwright" Version="1.55.0" />
4747
<PackageReference Include="Microsoft.PowerFx.Interpreter" Version="$(PowerFxVersion)" />
4848
<PackageReference Include="System.ComponentModel.Composition" Version="5.0.0" />
4949
</ItemGroup>

src/testengine.module.powerapps.portal/testengine.module.powerapps.portal.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949

5050
<ItemGroup>
5151
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
52-
<PackageReference Include="Microsoft.Playwright" Version="1.52.0" />
52+
<PackageReference Include="Microsoft.Playwright" Version="1.55.0" />
5353
<PackageReference Include="Microsoft.PowerFx.Interpreter" Version="$(PowerFxVersion)" />
5454
<PackageReference Include="System.ComponentModel.Composition" Version="5.0.0" />
5555
<PackageReference Include="Microsoft.CSharp" Version="4.7.0" />

src/testengine.module.simulation/testengine.module.simulation.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
<ItemGroup>
2525
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
26-
<PackageReference Include="Microsoft.Playwright" Version="1.52.0" />
26+
<PackageReference Include="Microsoft.Playwright" Version="1.55.0" />
2727
<PackageReference Include="Microsoft.PowerFx.Interpreter" Version="$(PowerFxVersion)" />
2828
<PackageReference Include="System.ComponentModel.Composition" Version="5.0.0" />
2929
</ItemGroup>

0 commit comments

Comments
 (0)