Skip to content

Commit 3805c43

Browse files
author
Shahak Yosef
committed
Merged PR 101891: Temporarily revert safe eval playground changes
We want to release a fix for the JS SDK but we don't want to include the playground safe eval changes. Temporarily reverting the PR so we can create a release. It will be checked-in again afterwards.
1 parent ae2f11e commit 3805c43

5 files changed

Lines changed: 3 additions & 47 deletions

File tree

dist/powerbi-client.d.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1607,8 +1607,6 @@ declare module "service" {
16071607
}
16081608
export interface IService {
16091609
hpm: hpm.HttpPostMessage;
1610-
preComponentCreation: (frame: HTMLIFrameElement) => void;
1611-
customEventHandler: (event: IEvent<any>) => void;
16121610
}
16131611
/**
16141612
* The Power BI Service embed component, which is the entry point to embed all other Power BI components into your application
@@ -1645,14 +1643,6 @@ declare module "service" {
16451643
* @hidden
16461644
*/
16471645
wpmp: wpmp.WindowPostMessageProxy;
1648-
/** An external function used to add custom functionality to embed setIframe. Used in playground safe-eval.
1649-
* @hidden
1650-
*/
1651-
preComponentCreation: (frame: HTMLIFrameElement) => void;
1652-
/** A custom event handler used to override the SDK default event handler. Used in playground safe-eval.
1653-
* @hidden
1654-
*/
1655-
customEventHandler: (event: IEvent<any>) => void;
16561646
private router;
16571647
private uniqueSessionId;
16581648
/**

dist/powerbi.js

Lines changed: 0 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/powerbi.min.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/embed.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -723,10 +723,6 @@ export abstract class Embed {
723723
node.removeChild(node.firstChild);
724724
}
725725

726-
if (this.service.preComponentCreation != null) {
727-
this.service.preComponentCreation(iframeContent);
728-
}
729-
730726
node.appendChild(iframeContent);
731727
this.iframe = <HTMLIFrameElement>node.firstChild;
732728
}

src/service.ts

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,6 @@ export interface IServiceConfiguration extends IDebugOptions {
7272

7373
export interface IService {
7474
hpm: hpm.HttpPostMessage;
75-
preComponentCreation: (frame: HTMLIFrameElement) => void;
76-
customEventHandler: (event: IEvent<any>) => void;
7775
}
7876

7977
/**
@@ -126,14 +124,6 @@ export class Service implements IService {
126124
* @hidden
127125
*/
128126
wpmp: wpmp.WindowPostMessageProxy;
129-
/** An external function used to add custom functionality to embed setIframe. Used in playground safe-eval.
130-
* @hidden
131-
*/
132-
public preComponentCreation: (frame: HTMLIFrameElement) => void = null;
133-
/** A custom event handler used to override the SDK default event handler. Used in playground safe-eval.
134-
* @hidden
135-
*/
136-
public customEventHandler: (event: IEvent<any>) => void = null;
137127
private router: router.Router;
138128
private uniqueSessionId: string;
139129

@@ -542,11 +532,6 @@ export class Service implements IService {
542532
* @hidden
543533
*/
544534
private handleEvent(event: IEvent<any>): void {
545-
if (this.customEventHandler != null) {
546-
this.customEventHandler(event);
547-
return;
548-
}
549-
550535
let embed = utils.find(embed => {
551536
return (embed.config.uniqueId === event.id);
552537
}, this.embeds);

0 commit comments

Comments
 (0)