Skip to content

Commit a52c4e1

Browse files
May HartovMay Hartov
authored andcommitted
Merged PR 840170: removed beta version tag and set as latest from release pipeline
Bug in NPM release pipeline: ESRP task releases package as beta because of package.json config set as latest tasks adds latest tag we end up with released package having both beta and latest tages. Resolution: We don't need to release beta versions - this tag is used for "pre-release or experimental" versions - we don't release such. ESRP task will set latest tag when publishing the package if nothing else is configured (documentation ) no need for set as latest release pipeline stage after the above ---- #### AI description (iteration 1) #### PR Classification Release pipeline and configuration update. #### PR Summary This pull request removes the beta tag setup and associated pipeline stages, ensuring that released packages are now tagged as "latest." - `/.pipelines/powerbi-javascript-npm-release.yml`: Removed stages and tasks related to approval and marking the NPM package with the "latest" tag. - `/package.json`: Deleted the "publishConfig" specifying the "beta" tag, allowing the default latest tag to be applied. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Related work items: #1876417
1 parent 6c6a7c9 commit a52c4e1

2 files changed

Lines changed: 1 addition & 75 deletions

File tree

.pipelines/powerbi-javascript-npm-release.yml

Lines changed: 1 addition & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -135,75 +135,4 @@ extends:
135135
approvers: 'alonyeshurun@microsoft.com'
136136
serviceendpointurl: 'https://api.esrp.microsoft.com'
137137
mainpublisher: 'ESRPRELPACMAN'
138-
domaintenantid: '975f013f-7f24-47e8-a7d3-abc4752bf346'
139-
140-
- stage: Prod_ApprovalToAddLatestTag
141-
displayName: Approval to set the released package as latest
142-
trigger: manual
143-
dependsOn: []
144-
variables:
145-
ob_release_environment: Production
146-
ob_release_usedeploymentjob: true
147-
ob_deploymentjob_environment: PBIEmbed
148-
149-
jobs:
150-
- job: ApprovalToAddLatestTag
151-
displayName: Approval to add the latest tag
152-
pool:
153-
type: release
154-
155-
steps:
156-
- download: PowerbiJavascriptOfficial
157-
158-
- stage: MarkPowerbiJavascriptNpmPackageLatest
159-
displayName: Set as latest
160-
dependsOn:
161-
- Release_External
162-
- Prod_ApprovalToAddLatestTag
163-
condition: succeeded()
164-
165-
jobs:
166-
- job: AddLatestTag
167-
displayName: Add the latest tag on the released version
168-
pool:
169-
name: Azure Pipelines
170-
type: windows
171-
isCustom: true
172-
vmImage: 'windows-latest'
173-
174-
variables:
175-
ob_outputDirectory: '$(OUTPUTROOT)' # this directory is uploaded to pipeline artifacts, reddog and cloudvault. More info at https://aka.ms/obpipelines/artifacts
176-
177-
steps:
178-
- task: DownloadPipelineArtifact@2
179-
displayName: "Download build files from the powerbi-javascript-official pipeline"
180-
inputs:
181-
buildType: 'specific'
182-
project: '4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1' # Embedded
183-
definition: '8483' # powerbi-javascript-Official
184-
buildVersionToDownload: 'latest'
185-
artifactName: 'drop'
186-
targetPath: '$(Pipeline.Workspace)\PublishedNpmArtifact'
187-
188-
- task: PowerShell@2
189-
displayName: 'Extract powerbi-javascript latest version number'
190-
inputs:
191-
targetType: inline
192-
script: |
193-
$packagePath = "$(Pipeline.Workspace)\PublishedNpmArtifact\outputs\package\tgz-package"
194-
$file = Get-ChildItem $packagePath -Filter *.tgz | Select-Object -First 1
195-
$fileName = [System.IO.Path]::GetFileNameWithoutExtension($file.Name)
196-
$version = $fileName -replace 'powerbi-client-', ''
197-
Write-Host "##vso[task.setvariable variable=packageVersion]$version"
198-
199-
- task: Npm@1
200-
displayName: 'npm mark version as latest'
201-
condition: succeeded()
202-
inputs:
203-
command: custom
204-
workingDir: '$(Pipeline.Workspace)\PublishedNpmArtifact\outputs\build\build_artifacts'
205-
verbose: true
206-
customCommand: 'dist-tag add powerbi-client@$(packageVersion) latest'
207-
customEndpoint: 'New Power BI NpmJS'
208-
publishRegistry: useFeed
209-
publishFeed: 'd95dbb95-6687-4730-b306-abe69704b45d' # PowerBI.SDKs
138+
domaintenantid: '975f013f-7f24-47e8-a7d3-abc4752bf346'

package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,6 @@
8282
"powerbi-router": "^0.1",
8383
"window-post-message-proxy": "^0.2.7"
8484
},
85-
"publishConfig": {
86-
"tag": "beta"
87-
},
8885
"overrides": {
8986
"glob-parent": "^6.0.2",
9087
"micromatch": "^4.0.5",

0 commit comments

Comments
 (0)