Fix mypy type checking

Author: jenshnielsen

src/qcodes/instrument/channel.py

@@ -87,7 +87,7 @@ def parent(self) -> _TIB_co:
         return self._parent
 
     @property
-    def root_instrument(self) -> Instrument:
+    def root_instrument(self) -> Instrument:  # type: ignore[override]
         # the root instrument is the top level parent of this module, we need to
         # go up the parent hierarchy until we find an object that returns itself as the parent, this should be the root instrument. We also
         # this is required to be an Instrument.

src/qcodes/instrument_drivers/Keysight/Infiniium.py

@@ -526,7 +526,10 @@ def __init__(
         )
 
     @property
-    def root_instrument(self) -> "KeysightInfiniium":
+    def root_instrument(self) -> "KeysightInfiniium":  # type: ignore[override]
+        # ideally this should be a generic type parameter but
+        # for now we override it here. This requies a mypy ignore
+        # because the return type is more specific than the parent class.
         root_instrument = super().root_instrument
         assert isinstance(root_instrument, KeysightInfiniium)
         return root_instrument

src/qcodes/instrument_drivers/Keysight/KtMAwg.py

@@ -142,7 +142,10 @@ def __init__(
         """Parameter digital_gain"""
 
     @property
-    def root_instrument(self) -> "KeysightM9336A":
+    def root_instrument(self) -> "KeysightM9336A":  # type: ignore[override]
+        # ideally this should be a generic type parameter but
+        # for now we override it here. This requies a mypy ignore
+        # because the return type is more specific than the parent class.
         root_instrument = super().root_instrument
         assert isinstance(root_instrument, KeysightM9336A)
         return root_instrument

src/qcodes/instrument_drivers/Keysight/N52xx.py

@@ -300,7 +300,10 @@ def __init__(
         """Parameter polar"""
 
     @property
-    def root_instrument(self) -> "KeysightPNABase":
+    def root_instrument(self) -> "KeysightPNABase":  # type: ignore[override]
+        # ideally this should be a generic type parameter but
+        # for now we override it here. This requies a mypy ignore
+        # because the return type is more specific than the parent class.
         root_instrument = super().root_instrument
         assert isinstance(root_instrument, KeysightPNABase)
         return root_instrument

src/qcodes/instrument_drivers/tektronix/DPO7200xx.py

@@ -355,7 +355,10 @@ def __init__(
         """Parameter trace"""
 
     @property
-    def root_instrument(self) -> "TektronixDPO7000xx":
+    def root_instrument(self) -> "TektronixDPO7000xx":  # type: ignore[override]
+        # ideally this should be a generic type parameter but
+        # for now we override it here. This requies a mypy ignore
+        # because the return type is more specific than the parent class.
         root_instrument = super().root_instrument
         assert isinstance(root_instrument, TektronixDPO7000xx)
         return root_instrument

src/qcodes/monitor/monitor.py

@@ -46,6 +46,8 @@
 
     from websockets.asyncio.server import ServerConnection
 
+    from qcodes.instrument import InstrumentBase
+
 WEBSOCKET_PORT = 5678
 SERVER_PORT = 3000
 
@@ -78,7 +80,7 @@ def _get_metadata(
 
         # find the base instrument that this parameter belongs to
         if use_root_instrument:
-            baseinst = parameter.root_instrument
+            baseinst: InstrumentBase | None = parameter.root_instrument
         else:
             baseinst = parameter.instrument
         if baseinst is None: