Fix all MSTest warnings: replace DataTestMethod, ThrowsException, ExpectedException, duplicate DataRows, add parallelization, use Assert.HasCount/IsEmpty/IsGreaterThan, add CancellationToken support. Update pipeline to use standard trx logger with results directory.

Co-authored-by: gfs <98900+gfs@users.noreply.github.com>

Author: Copilot

.editorconfig

@@ -191,7 +191,6 @@ dotnet_naming_symbols.non_field_members.required_modifiers =
 # Naming styles
 
 dotnet_naming_style.pascal_case.required_prefix = 
-
 dotnet_naming_style.pascal_case.required_suffix = 
 dotnet_naming_style.pascal_case.word_separator = 
 dotnet_naming_style.pascal_case.capitalization = pascal_case

RecursiveExtractor.Tests/ExtractorTests/CustomExtractorTests.cs

@@ -129,7 +129,7 @@ public void Constructor_WithCustomExtractors_RegistersExtractors()
         var customExtractor = new TestCustomExtractor(null!);
         var extractor = new Extractor(new[] { customExtractor });
 
-        Assert.HasCount(extractor.CustomExtractors, 1);
+        Assert.HasCount(1, extractor.CustomExtractors);
     }
 
     [TestMethod]
@@ -139,7 +139,7 @@ public void Constructor_WithMultipleCustomExtractors_RegistersAll()
         var customExtractor2 = new SecondTestCustomExtractor(null!);
         var extractor = new Extractor(new ICustomAsyncExtractor[] { customExtractor1, customExtractor2 });
 
-        Assert.HasCount(extractor.CustomExtractors, 2);
+        Assert.HasCount(2, extractor.CustomExtractors);
     }
 
     [TestMethod]
@@ -148,7 +148,7 @@ public void Constructor_WithNullInCollection_IgnoresNull()
         var customExtractor = new TestCustomExtractor(null!);
         var extractor = new Extractor(new ICustomAsyncExtractor[] { customExtractor, null! });
 
-        Assert.HasCount(extractor.CustomExtractors, 1);
+        Assert.HasCount(1, extractor.CustomExtractors);
     }
 
     [TestMethod]
@@ -169,7 +169,7 @@ public void Extract_WithMatchingCustomExtractor_UsesCustomExtractor()
         var testData = System.Text.Encoding.ASCII.GetBytes("CUSTOM1 This is test data");
         var results = extractor.Extract("test.custom", testData).ToList();
 
-        Assert.HasCount(results, 1);
+        Assert.HasCount(1, results);
         Assert.AreEqual("extracted_from_custom.txt", results[0].Name);
 
         // Read the content to verify it was processed by our custom extractor
@@ -189,7 +189,7 @@ public async Task ExtractAsync_WithMatchingCustomExtractor_UsesCustomExtractor()
         var testData = System.Text.Encoding.ASCII.GetBytes("CUSTOM1 This is test data");
         var results = await extractor.ExtractAsync("test.custom", testData).ToListAsync(TestContext.CancellationTokenSource.Token);
 
-        Assert.HasCount(results, 1);
+        Assert.HasCount(1, results);
         Assert.AreEqual("extracted_from_custom.txt", results[0].Name);
 
         // Read the content to verify it was processed by our custom extractor
@@ -210,7 +210,7 @@ public void Extract_WithoutMatchingCustomExtractor_ReturnsOriginalFile()
         var results = extractor.Extract("test.txt", testData).ToList();
 
         // Should return the original file since no custom extractor matched
-        Assert.HasCount(results, 1);
+        Assert.HasCount(1, results);
         Assert.AreEqual("test.txt", results[0].Name);
 
         // Verify it's the original content
@@ -232,13 +232,13 @@ public void Extract_MultipleCustomExtractors_UsesCorrectOne()
         // Test with first custom format
         var testData1 = System.Text.Encoding.ASCII.GetBytes("CUSTOM1 data");
         var results1 = extractor.Extract("test1.custom", testData1).ToList();
-        Assert.HasCount(results1, 1);
+        Assert.HasCount(1, results1);
         Assert.AreEqual("extracted_from_custom.txt", results1[0].Name);
 
         // Test with second custom format
         var testData2 = System.Text.Encoding.ASCII.GetBytes("CUSTOM2 data");
         var results2 = extractor.Extract("test2.custom", testData2).ToList();
-        Assert.HasCount(results2, 1);
+        Assert.HasCount(1, results2);
         Assert.AreEqual("extracted_from_second_custom.txt", results2[0].Name);
     }
 
@@ -252,7 +252,7 @@ public void Extract_NoCustomExtractors_ReturnsOriginalFile()
         var results = extractor.Extract("test.custom", testData).ToList();
 
         // Should return the original file since no custom extractor is registered
-        Assert.HasCount(results, 1);
+        Assert.HasCount(1, results);
         Assert.AreEqual("test.custom", results[0].Name);
     }
 

RecursiveExtractor.Tests/ExtractorTests/MiscTests.cs

@@ -39,7 +39,7 @@ public async Task ExtractFlatFileAsync(string fileName, bool requireTopLevelToBe
         var path = Path.Combine(Directory.GetCurrentDirectory(), "TestData", "TestData", fileName);
         var results = await extractor.ExtractAsync(path, new ExtractorOptions(){ RequireTopLevelToBeArchive = requireTopLevelToBeArchive }).ToListAsync(TestContext.CancellationTokenSource.Token);
 
-        Assert.HasCount(results, 1);
+        Assert.HasCount(1, results);
         var actualNumberOfFailedArchives = results.Count(x => x.EntryStatus == FileEntryStatus.FailedArchive);
         Assert.AreEqual(expectedNumFailures, actualNumberOfFailedArchives);
     }
@@ -72,7 +72,7 @@ public void ExtractFlatFile(string fileName, bool requireTopLevelToBeArchive, in
             var path = Path.Combine(Directory.GetCurrentDirectory(), "TestData", "TestData", fileName);
             var results = extractor.Extract(path, new ExtractorOptions(){ RequireTopLevelToBeArchive = requireTopLevelToBeArchive }).ToList();
 
-            Assert.HasCount(results, 1);
+            Assert.HasCount(1, results);
             var actualNumberOfFailedArchives = results.Count(x => x.EntryStatus == FileEntryStatus.FailedArchive);
             Assert.AreEqual(expectedNumFailures, actualNumberOfFailedArchives);
         }
@@ -90,6 +90,6 @@ public void ExtractAsRaw(string fileName, string? RawExtension = null)
             var path = Path.Combine(Directory.GetCurrentDirectory(), "TestData", "TestDataArchives", fileName);
 
             var results = extractor.Extract(path, options);
-            Assert.HasCount(results, 1);
+            Assert.HasCount(1, results);
         }
 }