Update settings container to use source + test name as key (#224)

* update child process dbg settings for easier debugging

* update settings container to use source + testname as the key since testname isnt always unique

Author: spebl

GoogleTestAdapter/Core/Runners/SequentialTestRunner.cs

@@ -1,4 +1,4 @@
-// This file has been modified by Microsoft on 10/2022.
+// This file has been modified by Microsoft on 11/2022.
 
 using System;
 using System.Collections.Generic;
@@ -63,9 +63,10 @@ public void RunTests(IEnumerable<TestCase> testCasesToRun, string baseDir,
 
                         foreach (var testCase in groupedTestCases[executable])
                         {
+                            var key = Path.GetFullPath(testCase.Source) + ":" + testCase.FullyQualifiedName;
                             ITestPropertySettings settings;
                             // Tests with default settings are treated as not having settings and can be run together
-                            if (_settings.TestPropertySettingsContainer.TryGetSettings(testCase.FullyQualifiedName, out settings)
+                            if (_settings.TestPropertySettingsContainer.TryGetSettings(key, out settings)
                                 && (settings.Environment.Count > 0 || Path.GetFullPath(settings.WorkingDirectory) != Path.GetFullPath(finalWorkingDir)))
                             {
                                 RunTestsFromExecutable(

GoogleTestAdapter/Core/Settings/ITestPropertySettingsContainer.cs

@@ -3,6 +3,6 @@ namespace GoogleTestAdapter.Settings
 {
     public interface ITestPropertySettingsContainer
     {
-        bool TryGetSettings(string testName, out ITestPropertySettings settings);
+        bool TryGetSettings(string key, out ITestPropertySettings settings);
     }
 }

GoogleTestAdapter/GoogleTestAdapter.ChildProcessDbgSettings

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <ChildProcessDebuggingSettings IsEnabled="true" xmlns="http://schemas.microsoft.com/vstudio/ChildProcessDebuggingSettings/2014">
-  <DefaultRule Attach="false" />
+  <DefaultRule EngineFilter="[inherit]" />
   <Rule IsEnabled="true" ProcessName="TE.ProcessHost.Managed.exe" EngineFilter="{92ef0900-2251-11d2-b72e-0000f87572ef}" />
   <Rule IsEnabled="true" ProcessName="vstest.discoveryengine.exe" EngineFilter="{92ef0900-2251-11d2-b72e-0000f87572ef}" />
   <Rule IsEnabled="true" ProcessName="vstest.discoveryengine.x86.exe" EngineFilter="{92ef0900-2251-11d2-b72e-0000f87572ef}" />

GoogleTestAdapter/TestAdapter/Settings/TestPropertySettingsContainer.cs

@@ -1,9 +1,11 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license.
+// This file has been modified by Microsoft on 11/2022.
 
 using GoogleTestAdapter.Settings;
 using Microsoft.VisualStudio.TestPlatform.ObjectModel;
 using System.Collections.Generic;
+using System.IO;
 using System.Xml;
 using System.Xml.Serialization;
 
@@ -46,10 +48,10 @@ public override XmlElement ToXml()
             return document.DocumentElement;
         }
 
-        public bool TryGetSettings(string testName, out ITestPropertySettings settings)
+        public bool TryGetSettings(string key, out ITestPropertySettings settings)
         {
             EnsureTestPropertiesMap();
-            return _tests.TryGetValue(testName, out settings);
+            return _tests.TryGetValue(key, out settings);
         }
 
         private void EnsureTestPropertiesMap()
@@ -64,8 +66,9 @@ private void EnsureTestPropertiesMap()
             {
                 foreach (var t in this.Tests)
                 {
+                    var key = Path.GetFullPath(t.Command) + ":" + t.Name;
                     var propertySettings = new TestPropertySettings(t);
-                    _tests.Add(t.Name, propertySettings);
+                    _tests.Add(key, propertySettings);
                 }
             }
         }