Change to removing Naemspace only for run execution now to preserve test case metadata for VS

Author: DavidARaygoza

GoogleTestAdapter/Core/Runners/SequentialTestRunner.cs

@@ -64,7 +64,6 @@ public void RunTests(IEnumerable<TestCase> testCasesToRun, string baseDir,
                         foreach (var testCase in groupedTestCases[executable])
                         {
                             var key = Path.GetFullPath(testCase.Source) + ":" + testCase.FullyQualifiedName;
-
                             ITestPropertySettings settings;
                             // Tests with default settings are treated as not having settings and can be run together
                             if (_settings.TestPropertySettingsContainer.TryGetSettings(key, out settings)
@@ -181,6 +180,24 @@ public static void LogExecutionError(ILogger logger, string executable, string w
         private IEnumerable<TestResult> TryRunTests(string executable, string workingDir, IDictionary<string, string> envVars, bool isBeingDebugged,
             IDebuggedProcessLauncher debuggedLauncher, CommandLineGenerator.Args arguments, IProcessExecutor executor, StreamingStandardOutputTestResultParser streamingParser)
         {
+            foreach (TestCase tc in arguments.TestCases)
+            {
+                // If namespace exists then remove it so we can compare the test display names.
+                //  Using just tc.DisplayName does not work for paramaterized test cases.
+                string fullyQualifiedName = tc.FullyQualifiedName;
+                int frequency = fullyQualifiedName.Where(x => (x == '.')).Count();
+                if (frequency > 1)
+                {
+                    string ns = fullyQualifiedName.Substring(0, fullyQualifiedName.IndexOf('.'));
+                    tc.Namespace = ns;
+                    _logger.LogInfo("NS removing: " + tc.Namespace);
+                    fullyQualifiedName = fullyQualifiedName.Substring(fullyQualifiedName.IndexOf('.') + 1);
+                }
+
+                tc.FullyQualifiedName = fullyQualifiedName;
+                _logger.LogInfo("Test Name after removing NS: " + tc.FullyQualifiedName);
+            }
+
             List<string> consoleOutput;
             if (_settings.UseNewTestExecutionFramework)
             {

GoogleTestAdapter/TestAdapter/TestExecutor.cs

@@ -229,24 +229,6 @@ private void DoRunTests(ICollection<TestCase> testCasesToRun, IRunContext runCon
 
                 _executor = new GoogleTestExecutor(_logger, _settings);
             }
-            foreach (TestCase tc in testCasesToRun)
-            {
-                // If namespace exists then remove it so we can compare the test display names.
-                //  Using just tc.DisplayName does not work for paramaterized test cases.
-                string fullyQualifiedName = tc.FullyQualifiedName;
-                int frequency = fullyQualifiedName.Where(x => (x == '.')).Count();
-                if (frequency > 1)
-                {
-                    string ns = fullyQualifiedName.Substring(0, fullyQualifiedName.IndexOf('.'));
-                    tc.Namespace = ns;
-                    _logger.LogInfo("NS removing: " + tc.Namespace);
-                    fullyQualifiedName = fullyQualifiedName.Substring(fullyQualifiedName.IndexOf('.') + 1);
-                }
-
-                tc.FullyQualifiedName = fullyQualifiedName;
-                _logger.LogInfo("Test Name after removing NS: " + tc.FullyQualifiedName);
-            }
-
             _executor.RunTests(testCasesToRun, reporter, launcher,
                 runContext.IsBeingDebugged, runContext.SolutionDirectory, processExecutor);
             reporter.AllTestsFinished();